From fd8417b5de27c876d51434e17b58f4f152f9c476 Mon Sep 17 00:00:00 2001
From: Dane Everitt <dane@daneeveritt.com>
Date: Sat, 17 Sep 2016 14:51:27 -0400
Subject: [PATCH] Fix a display bug with IP aliasing

---
 app/Models/Server.php                         | 1 +
 resources/views/admin/servers/index.blade.php | 2 +-
 resources/views/admin/servers/view.blade.php  | 8 ++++----
 resources/views/base/index.blade.php          | 2 +-
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/app/Models/Server.php b/app/Models/Server.php
index 655323e0c..e0665ee13 100644
--- a/app/Models/Server.php
+++ b/app/Models/Server.php
@@ -131,6 +131,7 @@ class Server extends Model
             'servers.*',
             'nodes.name as nodeName',
             'locations.short as a_locationShort',
+            'allocations.ip',
             'allocations.ip_alias',
             'allocations.port'
         )->join('nodes', 'servers.node', '=', 'nodes.id')
diff --git a/resources/views/admin/servers/index.blade.php b/resources/views/admin/servers/index.blade.php
index 54eda116e..a1bf5611a 100644
--- a/resources/views/admin/servers/index.blade.php
+++ b/resources/views/admin/servers/index.blade.php
@@ -46,7 +46,7 @@
                     <td><a href="/admin/servers/view/{{ $server->id }}">{{ $server->name }}</a>@if($server->suspended === 1) <span class="label label-warning">Suspended</span>@endif</td>
                     <td><a href="/admin/users/view/{{ $server->owner }}">{{ $server->a_ownerEmail }}</a></td>
                     <td class="hidden-xs"><a href="/admin/nodes/view/{{ $server->node }}">{{ $server->a_nodeName }}</a></td>
-                    <td><code>{{ $server->ip_alias }}:{{ $server->port }}</code> @if($server->ip !== $server->ip_alias)<span class="label label-default">alias</span>@endif</td>
+                    <td><code>@if(!is_null($server->ip_alias)){{ $server->ip_alias }}@else{{ $server->ip }}@endif:{{ $server->port }}</code> @if(!is_null($server->ip_alias))<span class="label label-default">alias</span>@endif</td>
                     <td class="hidden-xs"><code>{{ $server->username }}</code></td>
                 </tr>
             @endforeach
diff --git a/resources/views/admin/servers/view.blade.php b/resources/views/admin/servers/view.blade.php
index 5b5554d6b..1f948b1bd 100644
--- a/resources/views/admin/servers/view.blade.php
+++ b/resources/views/admin/servers/view.blade.php
@@ -115,7 +115,7 @@
                             <tr>
                                 <td>Connection Alias</td>
                                 <td>
-                                    @if($server->ip !== $server->ip_alias)
+                                    @if(!is_null($server->ip_alias))
                                         <code>{{ $server->ip_alias }}:{{ $server->port }}</code>
                                     @else
                                         <span class="label label-default">No Alias Assigned</span>
@@ -236,7 +236,7 @@
                                             <span class="input-group-addon">
                                                 <input type="radio" @if($assignment->ip == $server->ip && $assignment->port == $server->port) checked="checked" @endif name="default" value="{{ $assignment->ip }}:{{ $assignment->port }}"/>
                                             </span>
-                                            <input type="text" class="form-control" value="{{ $assignment->ip_alias }}:{{ $assignment->port }}@if($assignment->ip !== $assignment->ip_alias) (alias of {{ $assignment->ip }})@endif" readonly />
+                                            <input type="text" class="form-control" value="@if(!is_null($assignment->ip_alias)){{ $assignment->ip_alias }}@else{{ $assignment->ip }}@endif:{{ $assignment->port }} @if(!is_null($assignment->ip_alias))(alias of {{ $assignment->ip }})@endif" readonly />
                                         </div>
                                     @endforeach
                                 </div>
@@ -247,7 +247,7 @@
                                             <div>
                                                 <select name="add_additional[]" class="form-control" multiple>
                                                     @foreach ($unassigned as $assignment)
-                                                        <option value="{{ $assignment->ip }}:{{ $assignment->port }}">{{ $assignment->ip_alias }}:{{ $assignment->port }}@if($assignment->ip !== $assignment->ip_alias) (alias of {{ $assignment->ip }})@endif</option>
+                                                        <option value="{{ $assignment->ip }}:{{ $assignment->port }}">@if(!is_null($assignment->ip_alias)){{ $assignment->ip_alias }}@else{{ $assignment->ip }}@endif:{{ $assignment->port }} @if(!is_null($assignment->ip_alias))(alias of {{ $assignment->ip }})@endif</option>
                                                     @endforeach
                                                 </select>
                                             </div>
@@ -260,7 +260,7 @@
                                             <div>
                                                 <select name="remove_additional[]" class="form-control" multiple>
                                                     @foreach ($assigned as $assignment)
-                                                        <option value="{{ $assignment->ip }}:{{ $assignment->port }}" @if($assignment->ip == $server->ip && $assignment->port == $server->port) disabled @endif>{{ $assignment->ip_alias }}:{{ $assignment->port }}@if($assignment->ip !== $assignment->ip_alias) (alias of {{ $assignment->ip }})@endif</option>
+                                                        <option value="{{ $assignment->ip }}:{{ $assignment->port }}">@if(!is_null($assignment->ip_alias)){{ $assignment->ip_alias }}@else{{ $assignment->ip }}@endif:{{ $assignment->port }} @if(!is_null($assignment->ip_alias))(alias of {{ $assignment->ip }})@endif</option>
                                                     @endforeach
                                                 </select>
                                             </div>
diff --git a/resources/views/base/index.blade.php b/resources/views/base/index.blade.php
index a80836256..6df1bc37f 100644
--- a/resources/views/base/index.blade.php
+++ b/resources/views/base/index.blade.php
@@ -59,7 +59,7 @@
                         @endif
                         <td><a href="/server/{{ $server->uuidShort }}">{{ $server->name }}</a></td>
                         <td>{{ $server->nodeName }} ({{ $server->a_locationShort }})</td>
-                        <td><code>{{ $server->ip_alias }}:{{ $server->port }}</code></td>
+                        <td><code>@if(!is_null($server->ip_alias)){{ $server->ip_alias }}@else{{ $server->ip }}@endif:{{ $server->port }}</code></td>
                         <td class="text-center" data-action="players">--</td>
                         <td class="text-center"><span data-action="memory">--</span> / {{ $server->memory === 0 ? '&infin;' : $server->memory }} MB</td>
                         <td class="text-center"><span data-action="cpu" data-cpumax="{{ $server->cpu }}">--</span> %</td>