Mirrors/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2024-11-24 11:52:34 +01:00
Code Issues Releases Wiki Activity

Fixed streamed outputs in more extreme scenarios

Browse Source 
Fixes hitting memory limits where downloaded file sizes are much greater
than memory limit. Stopping and flushing output buffer seemed to stop
limits causing issues when fpassthru is used.
Tested with 24M memory limit and 734M file
This commit is contained in:
Dan Brown 2022-04-02 18:42:15 +01:00
parent 82e8b1577e
commit 6749faa89a
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/Http/Controllers/Controller.php
View File

@ -127,6 +127,7 @@ abstract class Controller extends BaseController
protected function streamedDownloadResponse($stream, string $fileName): StreamedResponse
{
return response()->stream(function() use ($stream) {
ob_end_clean();
fpassthru($stream);
fclose($stream);
}, 200, [