1
0
mirror of https://github.com/BookStackApp/BookStack.git synced 2024-10-30 07:32:39 +01:00

Attachment List: Fixed broken ctrl-click functionality

Fixes #4782
This commit is contained in:
Dan Brown 2024-01-23 15:01:07 +00:00
parent a4fd825fe2
commit 788327fffb
No known key found for this signature in database
GPG Key ID: 46D9F943C24A2EF9
2 changed files with 7 additions and 5 deletions

View File

@ -9,6 +9,8 @@ export class AttachmentsList extends Component {
setup() {
this.container = this.$el;
this.fileLinks = this.$manyRefs.linkTypeFile;
this.setupListeners();
}
@ -27,8 +29,7 @@ export class AttachmentsList extends Component {
}
addOpenQueryToLinks() {
const links = this.container.querySelectorAll('a.attachment-file');
for (const link of links) {
for (const link of this.fileLinks) {
if (link.href.split('?')[1] !== 'open=true') {
link.href += '?open=true';
link.setAttribute('target', '_blank');
@ -37,8 +38,7 @@ export class AttachmentsList extends Component {
}
removeOpenQueryFromLinks() {
const links = this.container.querySelectorAll('a.attachment-file');
for (const link of links) {
for (const link of this.fileLinks) {
link.href = link.href.split('?')[0];
link.removeAttribute('target');
}

View File

@ -2,7 +2,9 @@
@foreach($attachments as $attachment)
<div class="attachment icon-list">
<div class="split-icon-list-item attachment-{{ $attachment->external ? 'link' : 'file' }}">
<a href="{{ $attachment->getUrl() }}" @if($attachment->external) target="_blank" @endif>
<a href="{{ $attachment->getUrl() }}"
refs="attachments-list@link-type-{{ $attachment->external ? 'link' : 'file' }}"
@if($attachment->external) target="_blank" @endif>
<div class="icon">@icon($attachment->external ? 'export' : 'file')</div>
<div class="label">{{ $attachment->name }}</div>
</a>