Applied styleci changes for conversion work

app/Entities/Repos/BookshelfRepo.php

@@ -6,12 +6,10 @@ use BookStack\Actions\ActivityType;
 use BookStack\Entities\Models\Book;
 use BookStack\Entities\Models\Bookshelf;
 use BookStack\Entities\Tools\TrashCan;
-use BookStack\Exceptions\ImageUploadException;
 use BookStack\Exceptions\NotFoundException;
 use BookStack\Facades\Activity;
 use Exception;
 use Illuminate\Contracts\Pagination\LengthAwarePaginator;
-use Illuminate\Http\UploadedFile;
 use Illuminate\Support\Collection;
 
 class BookshelfRepo

app/Entities/Tools/Cloner.php

@@ -89,6 +89,7 @@ class Cloner
 
     /**
      * Convert an entity to a raw data array of input data.
+     *
      * @return array<string, mixed>
      */
     public function entityToInputData(Entity $entity): array

app/Entities/Tools/HierarchyTransformer.php

@@ -45,6 +45,7 @@ class HierarchyTransformer
         $this->trashCan->destroyEntity($chapter);
 
         Activity::add(ActivityType::BOOK_CREATE_FROM_CHAPTER, $book);
+
         return $book;
     }
 
@@ -80,6 +81,7 @@ class HierarchyTransformer
         $shelf->books()->sync($shelfBookSyncData);
 
         Activity::add(ActivityType::BOOKSHELF_CREATE_FROM_BOOK, $shelf);
+
         return $shelf;
     }
 }

app/Http/Controllers/Api/BookApiController.php

@@ -89,7 +89,8 @@ class BookApiController extends ApiController
         return response('', 204);
     }
 
-    protected function rules(): array {
+    protected function rules(): array
+    {
         return [
             'create' => [
                 'name'        => ['required', 'string', 'max:255'],

app/Http/Controllers/BookController.php

@@ -167,7 +167,7 @@ class BookController extends Controller
 
         if ($request->has('image_reset')) {
             $validated['image'] = null;
-        } else if (array_key_exists('image', $validated) && is_null($validated['image'])) {
+        } elseif (array_key_exists('image', $validated) && is_null($validated['image'])) {
             unset($validated['image']);
         }
 

app/Http/Controllers/BookshelfController.php

@@ -167,7 +167,7 @@ class BookshelfController extends Controller
 
         if ($request->has('image_reset')) {
             $validated['image'] = null;
-        } else if (array_key_exists('image', $validated) && is_null($validated['image'])) {
+        } elseif (array_key_exists('image', $validated) && is_null($validated['image'])) {
             unset($validated['image']);
         }
 

app/Http/Controllers/ChapterController.php

@@ -274,7 +274,6 @@ class ChapterController extends Controller
         return redirect($chapter->getUrl());
     }
 
-
     /**
      * Convert the chapter to a book.
      */

tests/Api/BooksApiTest.php

@@ -139,7 +139,7 @@ class BooksApiTest extends TestCase
 
         // Ensure further updates without image do not clear cover image
         $resp = $this->put($this->baseEndpoint . "/{$book->id}", [
-            'name' => 'My updated book again'
+            'name' => 'My updated book again',
         ]);
         $book->refresh();
 

tests/Api/ShelvesApiTest.php

@@ -167,7 +167,7 @@ class ShelvesApiTest extends TestCase
 
         // Ensure further updates without image do not clear cover image
         $resp = $this->put($this->baseEndpoint . "/{$shelf->id}", [
-            'name' => 'My updated shelf again'
+            'name' => 'My updated shelf again',
         ]);
         $shelf->refresh();
 

tests/Entity/ConvertTest.php

@@ -12,7 +12,6 @@ use Tests\TestCase;
 
 class ConvertTest extends TestCase
 {
-
     public function test_chapter_edit_view_shows_convert_option()
     {
         /** @var Chapter $chapter */
@@ -143,5 +142,4 @@ class ConvertTest extends TestCase
         $this->assertNotPermissionError($resp);
         $resp->assertRedirect();
     }
-
 }

tests/OpenGraphTest.php

@@ -8,7 +8,6 @@ use BookStack\Entities\Models\Chapter;
 use BookStack\Entities\Models\Page;
 use BookStack\Entities\Repos\BaseRepo;
 use BookStack\Entities\Repos\BookRepo;
-use BookStack\Entities\Repos\BookshelfRepo;
 use Illuminate\Support\Str;
 use Tests\Uploads\UsesImages;
 

tests/SharedTestHelpers.php

@@ -201,7 +201,7 @@ trait SharedTestHelpers
         /** @var RolePermission $permission */
         $permission = RolePermission::query()->where('name', '=', $permissionName)->firstOrFail();
 
-        $roles = $user->roles()->whereHas('permissions', function($query) use ($permission) {
+        $roles = $user->roles()->whereHas('permissions', function ($query) use ($permission) {
             $query->where('id', '=', $permission->id);
         })->get();