mirror of
https://github.com/BookStackApp/BookStack.git
synced 2024-10-29 23:22:34 +01:00
Fixed local_secure_restricted preventing attachment uploads
Due to option name change and therefore lack of handling. Added test case to cover.
This commit is contained in:
parent
092b6d6378
commit
c76b5e2ec4
@ -41,7 +41,7 @@ class AttachmentService
|
||||
|
||||
// Change to our secure-attachment disk if any of the local options
|
||||
// are used to prevent escaping that location.
|
||||
if ($storageType === 'local' || $storageType === 'local_secure' || $storageType === 'local_secure_with_permissions') {
|
||||
if ($storageType === 'local' || $storageType === 'local_secure' || $storageType === 'local_secure_restricted') {
|
||||
$storageType = 'local_secure_attachments';
|
||||
}
|
||||
|
||||
|
@ -341,4 +341,19 @@ class AttachmentTest extends TestCase
|
||||
|
||||
$this->deleteUploads();
|
||||
}
|
||||
|
||||
public function test_file_upload_works_when_local_secure_restricted_is_in_use()
|
||||
{
|
||||
config()->set('filesystems.attachments', 'local_secure_restricted');
|
||||
|
||||
$page = Page::query()->first();
|
||||
$fileName = 'upload_test_file.txt';
|
||||
|
||||
$upload = $this->asAdmin()->uploadFile($fileName, $page->id);
|
||||
$upload->assertStatus(200);
|
||||
|
||||
$attachment = Attachment::query()->orderBy('id', 'desc')->where('uploaded_to', '=', $page->id)->first();
|
||||
$this->assertFileExists(storage_path($attachment->path));
|
||||
$this->deleteUploads();
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user