Mirrors/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2024-11-23 11:22:33 +01:00
Code Issues Releases Wiki Activity

fix: Actually check if we have correct data

Browse Source
This commit is contained in:
Marc Hagen 2023-09-18 20:04:59 +02:00
parent ea7592509f
commit ca98155373
No known key found for this signature in database
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/Uploads/UserAvatars.php
View File

@ -56,7 +56,7 @@ class UserAvatars
/** /**
* Destroy all user avatars uploaded to the given user. * Destroy all user avatars uploaded to the given user.
*/ */
public function destroyAllForUser(User $user) public function destroyAllForUser(User $user): void
{ {
$profileImages = Image::query()->where('type', '=', 'user') $profileImages = Image::query()->where('type', '=', 'user')
->where('uploaded_to', '=', $user->id) ->where('uploaded_to', '=', $user->id)
@ -70,7 +70,7 @@ class UserAvatars
/** /**
* Save an avatar image from an external service. * Save an avatar image from an external service.
* *
* @throws Exception * @throws HttpFetchException
*/ */
protected function saveAvatarImage(User $user, int $size = 500): Image protected function saveAvatarImage(User $user, int $size = 500): Image
{ {
@ -114,12 +114,14 @@ class UserAvatars
try { try {
$client = $this->http->buildClient(5); $client = $this->http->buildClient(5);
$response = $client->sendRequest(new Request('GET', $url)); $response = $client->sendRequest(new Request('GET', $url));
$imageData = (string) $response->getBody(); if ($response->getStatusCode() !== 200) {
throw new HttpFetchException(trans('errors.cannot_get_image_from_url', ['url' => $url]));
}
return (string) $response->getBody();
} catch (ClientExceptionInterface $exception) { } catch (ClientExceptionInterface $exception) {
throw new HttpFetchException(trans('errors.cannot_get_image_from_url', ['url' => $url]), $exception->getCode(), $exception); throw new HttpFetchException(trans('errors.cannot_get_image_from_url', ['url' => $url]), $exception->getCode(), $exception);
} }
return $imageData;
} }
/** /**