mirror of
https://github.com/BookStackApp/BookStack.git
synced 2024-10-30 15:42:41 +01:00
Reduced calls for s3-based uploads
Combined the public ACL update into the put operation.
This commit is contained in:
parent
140aed3586
commit
f8cdd6e80d
@ -106,8 +106,7 @@ class ImageService
|
||||
}
|
||||
|
||||
try {
|
||||
$storage->put($fullPath, $imageData);
|
||||
$storage->setVisibility($fullPath, 'public');
|
||||
$storage->put($fullPath, $imageData, ['visibility' => 'public']);
|
||||
} catch (Exception $e) {
|
||||
\Log::error('Error when attempting image upload:' . $e->getMessage());
|
||||
throw new ImageUploadException(trans('errors.path_not_writable', ['filePath' => $fullPath]));
|
||||
@ -191,8 +190,7 @@ class ImageService
|
||||
|
||||
$thumbData = $this->resizeImage($storage->get($imagePath), $width, $height, $keepRatio);
|
||||
|
||||
$storage->put($thumbFilePath, $thumbData);
|
||||
$storage->setVisibility($thumbFilePath, 'public');
|
||||
$storage->put($thumbFilePath, $thumbData, ['visibility' => 'public']);
|
||||
$this->cache->put('images-' . $image->id . '-' . $thumbFilePath, $thumbFilePath, 60 * 60 * 72);
|
||||
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user