The 'name' field was really redundant and caused confusion in the
codebase, since the 'Display' name is often used and we have a
'system_name' for the admin and public role.
This fixes#2032, Where external auth group matching has confusing
behaviour as matching was done against the display_name, if no
external_auth field is set, but only roles with a match 'name' field
would be considered.
This also fixes and error where the role users migration, on role
delete, would not actually fire due to mis-matching http body keys.
Looks like this has been an issue from the start. Added some testing to
cover. Fixes#2211.
Also converted phpdoc to typehints in many areas of the reviewed code
during the above.
- Updated comment routes to be simpler.
- Updated comments JS to align better with updated component system.
- Documented available global JS functions/services.
- Removed redundant controller method.
- Added window.$events helpers for validation messages and
success/error.
- Updated JS events system to not be class based for simplicity.
- Added window.trans_plural method to handle pluralisation/replacements
where you already have the translation string itself.
Fixes#1836
Currently fighting between sortable and tinymce mechanisms which prevent
this working due to the different events stopping the drop event while
needing the dragover for cursor placement.
Due to causing content images to be rendered in unexpected ways.
- Also removed CSS filters from other image usage.
- Tweaked header CSS filtering to not be so aggressive.
- Forced WYSIWYG editor to be on its own layer since that would allow
massive larger performance increases in Safari, especially when using
dark mode.
Closes#2045.
Closes#2154.
- Created new dropzone component.
- Added standard component event system using custom DOM events.
- Added tabs component.
- Added ajax-delete-row component.
- Moved Code-editor from vue to component.
- Updated popup code so it background click only hides if the click
originated on the same background. Clicks within the popup will no
longer cause it to hide.
- Added session-level history tracking to code editor.
Added a document to try to define things.
Updated the loading so components are registed dynamically.
Added some standardised ways to reference other elems & define options
- Will focus on title if the value of the field matches the default text
for the current user's language.
- Otherwise will focus on the editor body.
- Added and tested on both editors.
For #2036
- Will now search for a callout on/above the selected node rather than
only using the selected node.
- Issues previously where callout shortcut would not cycle if called
when child formatting was currently selected inside the callout.
For #2061
Generally seems to cause issues when secure images are in use.
Was added during laravel upgrade but laravel does not use this directly
for its web middleware anyway.
- Updated editor, and other area, styles to look okay in dark mode.
- Used tinyMCE theme generator to create dark mode theme.
- Updated tinymce to latest 4x version.
- Most elements done, but still need to do editors, tables and final
pass.
- Toggled only by quick js check at the moment, checking via css media
query. Need to make into user-preference toggle.
For #1234
- Intended to prevent enumeration to check if a user exists.
- Updated messages on both the reqest-reset and set-password elements.
- Also updated notification auto-hide to be dynamic based upon the
amount of words within the notification.
- Added tests to cover.
For #2016
- Moved list to the left of the page to align with other navigational
items.
- Hid list of no shelves, to help hide shelf references if not in use.
- Tweaked test to ensure it wasn't finding shelf name in breadcrumb
rather than list being tested.
- Allowed DRAWIO env option to be passed as URL to point to instance.
- Updated tests to check URL gets passed to pages correctly.
- Update default URL to be the default theme.
For #826
Squashed commit of the following:
commit 23861a31bb2398ca61655c584bd8c75ee9bccdad
Merge: d44acf4b1c6287f2
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 22:18:50 2020 +0000
Merge branch 'master' into l10n_master
commit d44acf4b64
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 19:39:46 2020 +0000
New translations errors.php (Portuguese, Brazilian)
commit c1a4cc5d12
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 19:14:49 2020 +0000
New translations errors.php (Spanish, Argentina)
commit fb3c5dcffc
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 19:14:48 2020 +0000
New translations errors.php (Spanish)
commit f65c84635d
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:42:05 2020 +0000
New translations errors.php (German Informal)
commit 99fba6932a
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:57 2020 +0000
New translations errors.php (French)
commit bc4c9684b5
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:55 2020 +0000
New translations errors.php (Portuguese, Brazilian)
commit 0afce79807
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:43 2020 +0000
New translations errors.php (Russian)
commit f3daf77b95
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:41 2020 +0000
New translations errors.php (Hungarian)
commit 63848278a5
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:40 2020 +0000
New translations errors.php (Italian)
commit 53b5fce93c
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:38 2020 +0000
New translations errors.php (Japanese)
commit 2638f7a663
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:37 2020 +0000
New translations errors.php (Korean)
commit f19ffa468c
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:36 2020 +0000
New translations errors.php (Persian)
commit 477ae0b845
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:34 2020 +0000
New translations errors.php (Polish)
commit 56beebe12c
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:33 2020 +0000
New translations errors.php (German)
commit 2b6540654a
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:32 2020 +0000
New translations errors.php (Portuguese)
commit 80f7275011
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:30 2020 +0000
New translations errors.php (Spanish)
commit 74c65f90ab
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:28 2020 +0000
New translations errors.php (Spanish, Argentina)
commit 3bd9e4fb86
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:27 2020 +0000
New translations errors.php (Swedish)
commit a698db00e3
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:26 2020 +0000
New translations errors.php (Turkish)
commit f3cfc63b5c
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:25 2020 +0000
New translations errors.php (Ukrainian)
commit 61eb76ac89
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:23 2020 +0000
New translations errors.php (Vietnamese)
commit cfda94e2a8
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:22 2020 +0000
New translations errors.php (Slovak)
commit f0659025a9
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:20 2020 +0000
New translations errors.php (Dutch)
commit 27ac377ed6
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:19 2020 +0000
New translations errors.php (Chinese Traditional)
commit 04bf21a325
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:18 2020 +0000
New translations errors.php (Chinese Simplified)
commit 4dd5802979
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:16 2020 +0000
New translations errors.php (Arabic)
commit 368cf2d248
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:11 2020 +0000
New translations errors.php (Slovenian)
commit 52381df7be
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:08 2020 +0000
New translations errors.php (Czech)
commit 7e8330510f
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 14 18:41:07 2020 +0000
New translations errors.php (Danish)
commit 1bf07c6acf
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 22:57:41 2020 +0000
New translations entities.php (Slovenian)
commit 4d2d120b57
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 22:27:35 2020 +0000
New translations entities.php (Slovenian)
commit edfc88eb8e
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 21:55:51 2020 +0000
New translations entities.php (Slovenian)
commit 840ed35d34
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 21:22:08 2020 +0000
New translations entities.php (Slovenian)
commit aa130af285
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 14:02:50 2020 +0000
New translations common.php (Czech)
commit 5007fee528
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 14:02:25 2020 +0000
New translations entities.php (Slovenian)
commit 1ad8874e6b
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 13:30:21 2020 +0000
New translations auth.php (Czech)
commit 56f17ff7d4
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 13:29:57 2020 +0000
New translations entities.php (Slovenian)
commit 33789962cc
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 11:09:18 2020 +0000
New translations components.php (Slovenian)
commit 1002cf9e3b
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 10:08:48 2020 +0000
New translations components.php (Slovenian)
commit d5a6083ae8
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 09:37:23 2020 +0000
New translations components.php (Slovenian)
commit 0d8df3a72e
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 09:07:01 2020 +0000
New translations components.php (Slovenian)
commit 22337688f9
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 09:07:00 2020 +0000
New translations common.php (Slovenian)
commit ff812694e2
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 08:20:44 2020 +0000
New translations common.php (Slovenian)
commit 57b9e04927
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 06:17:11 2020 +0000
New translations auth.php (Spanish)
commit 25343baac1
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 06:16:52 2020 +0000
New translations activities.php (Spanish)
commit a5c72ee5f1
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Wed Mar 11 05:37:55 2020 +0000
New translations activities.php (Spanish)
commit 6a6f28d095
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue Mar 10 15:49:14 2020 +0000
New translations auth.php (Slovenian)
commit 33f30876e1
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue Mar 10 15:18:30 2020 +0000
New translations auth.php (Slovenian)
commit 8bf8bc0fe5
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue Mar 10 14:48:46 2020 +0000
New translations auth.php (Slovenian)
commit 303dc07704
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue Mar 10 14:48:44 2020 +0000
New translations activities.php (Slovenian)
commit c219fb67aa
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue Mar 10 09:59:45 2020 +0000
New translations activities.php (Slovenian)
commit f45b6c6c82
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue Mar 10 08:34:32 2020 +0000
New translations activities.php (Slovenian)
commit 7d690eb13f
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue Mar 10 02:56:48 2020 +0000
New translations entities.php (Russian)
commit 86aab0529e
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Tue Mar 10 02:56:43 2020 +0000
New translations common.php (Russian)
commit 4fc1945543
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 20:37:26 2020 +0000
New translations errors.php (Russian)
commit 09791b736d
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 20:07:52 2020 +0000
New translations settings.php (Russian)
commit 9cb04bea4c
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:50 2020 +0000
New translations validation.php (Slovenian)
commit 7964a5a2a0
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:34 2020 +0000
New translations settings.php (Slovenian)
commit 361be13ff7
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:32 2020 +0000
New translations passwords.php (Slovenian)
commit 9b6a7f0f64
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:31 2020 +0000
New translations pagination.php (Slovenian)
commit a815adc24f
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:30 2020 +0000
New translations errors.php (Slovenian)
commit ae6040af3a
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:28 2020 +0000
New translations entities.php (Slovenian)
commit f1d0177dce
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:26 2020 +0000
New translations components.php (Slovenian)
commit 16ba9f1fe1
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:24 2020 +0000
New translations common.php (Slovenian)
commit caa47464ba
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:23 2020 +0000
New translations auth.php (Slovenian)
commit 4b9a78aef8
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Mon Mar 9 18:49:21 2020 +0000
New translations activities.php (Slovenian)
commit 6a55161fe9
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sun Mar 8 01:36:31 2020 +0000
New translations common.php (French)
commit 94235393fa
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 7 18:49:01 2020 +0000
New translations errors.php (Portuguese, Brazilian)
commit a0f75e7724
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 7 10:24:26 2020 +0000
New translations settings.php (Russian)
commit 65437712a2
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 7 09:37:34 2020 +0000
New translations auth.php (Russian)
commit f7f6a92dcf
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 7 00:01:07 2020 +0000
New translations entities.php (Russian)
commit ac8819edd3
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Sat Mar 7 00:00:57 2020 +0000
New translations settings.php (Russian)
commit f1290f2b87
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Fri Mar 6 23:23:44 2020 +0000
New translations entities.php (Russian)
commit 8efb9bd571
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Fri Mar 6 22:45:53 2020 +0000
New translations entities.php (Russian)
commit 4fd31df14e
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Fri Mar 6 22:45:44 2020 +0000
New translations settings.php (Russian)
commit 262a2b3e4e
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Fri Mar 6 22:11:41 2020 +0000
New translations entities.php (Russian)
commit 15c98a64b8
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Fri Mar 6 15:10:54 2020 +0000
New translations errors.php (French)
commit 7a274db381
Author: Dan Brown <ssddanbrown@googlemail.com>
Date: Fri Mar 6 15:10:43 2020 +0000
New translations settings.php (French)
- Updated logic to take url from referrer rather than pass as a query parameter.
- Added tests to cover functionality.
- Updated 404 page with login action button if not signed in.
- Updated 404 page with text to indicate permissions may be affecting visibility.
Related to #1817 and #1706
Optionally we could consider removing the rule at line 274. This doesn't handle multiple layers of nested lists and would be better covered by the generic rule which checks for an `ol` or `ul` nested inside a `li` which is how MarkDown renders nested lists as HTML.
- Added custom handling, Tracks if contenteditable blocks are being dragged. On drop the selection location will be roughly checked to put the block above or below the cursor block root element.
- Removed different PDF template used on pages.
- Updated export view files to have the intended format passed.
- Shared the export CSS amoung the export templates.
Should hopefully address #1886
- MDN theme appeared fairly bad for markdown use, and the geometric
background was a bit much. Swapped out to default theme.
- Rough-added stickiness to docs sidebar, will need more work once it
starts to expand possible screen height.
- Included tests to cover for LDAP and SAML
- Updated wording for external auth id option.
- Updated 'assertPermissionError' test case to be usable in BrowserKitTests
Base logic in place but needs review and refactor to see if can better
fit into Laravel using 'Guard' system. Currently has issues due to
cookies in use from active session on API.
- Added access-api permission.
- Started user profile UI work.
- Created database table and model for tokens.
- Fixed incorrect templates down migration :(
- Was only used to disable registration when LDAP was enabled.
- Caused saved option not to show on settings page causing confusion.
- Extended setting logic where used to take ldap into account instead of
global override.
- Added warning on setting page to show registration enable setting is
not used while ldap is active.
For #1541
- Extracted logic to get images from paste/drop event into own file to
align usage in both events for both editors.
- Fixed non-ability to drag+drop into WYSIWYG editor.
- Updated check for table data to look for table specific rich-text
instead of just any text since some the old check was too general and
was preventing some legitimate image paste events.
Tested on Chrome and FireFox on Ubuntu.
Attempted to test on Safari via browserstack but environment was
unreliable and could not access folders to test drag/drop of files.
Relates to #1651 and #1697
- Applied since the browser defaults caused outlines to appear very
large in some cases.
- Set default color to use app primary color, to help them blend into
the design a little.
For #1738
- Added fadeIn to animation JS service.
- Updated overlay to use anim service and to recieve a callback for
after-anim actions.
- Updated code editor popup to refresh Codemirror instance layout after
animation has completed.
Fixes#1672
- Codemirror mode mapping value can now be a function to dynamically set
mode depending on actual code content.
- Used above system to set php mode type, depending on if '<?php' tags
exist in content.
Closes#1557
- Aligned and formatted config options.
- Provided way to override onelogin lib options if required.
- Added endpoints in core bookstack routes.
- Provided way to debug details provided by idp and formatted by
bookstack.
- Started on test work
- Handled case of email address already in use.
- Updated PHPdoc of SAML service to use type hinting instead.
- Updated groups to only sync if enabled.
- Updated names of some config props.
- Removed a couple of unused config props.
- Added exception to handle no email on SAML response.
