mirror of
https://github.com/BookStackApp/BookStack.git
synced 2024-11-23 19:32:29 +01:00
7be7d7d1e7
Added test to cover. Started refactoring some of the app error handling in the process of this. Fixes #2696
48 lines
1.6 KiB
PHP
48 lines
1.6 KiB
PHP
<?php namespace Tests;
|
|
|
|
use BookStack\Entities\Models\Book;
|
|
use Illuminate\Support\Facades\Log;
|
|
|
|
class ErrorTest extends TestCase
|
|
{
|
|
|
|
public function test_404_page_does_not_show_login()
|
|
{
|
|
// Due to middleware being handled differently this will not fail
|
|
// if our custom, middleware-loaded handler fails but this is here
|
|
// as a reminder and as a general check in the event of other issues.
|
|
$editor = $this->getEditor();
|
|
$editor->name = 'tester';
|
|
$editor->save();
|
|
|
|
$this->actingAs($editor);
|
|
$notFound = $this->get('/fgfdngldfnotfound');
|
|
$notFound->assertStatus(404);
|
|
$notFound->assertDontSeeText('Log in');
|
|
$notFound->assertSeeText('tester');
|
|
}
|
|
|
|
public function test_item_not_found_does_not_get_logged_to_file()
|
|
{
|
|
$this->actingAs($this->getViewer());
|
|
$handler = $this->withTestLogger();
|
|
$book = Book::query()->first();
|
|
|
|
// Ensure we're seeing errors
|
|
Log::error('cat');
|
|
$this->assertTrue($handler->hasErrorThatContains('cat'));
|
|
|
|
$this->get('/books/arandomnotfouindbook');
|
|
$this->get($book->getUrl('/chapter/arandomnotfouindchapter'));
|
|
$this->get($book->getUrl('/chapter/arandomnotfouindpages'));
|
|
|
|
$this->assertCount(1, $handler->getRecords());
|
|
}
|
|
|
|
public function test_access_to_non_existing_image_location_provides_404_response()
|
|
{
|
|
$resp = $this->actingAs($this->getViewer())->get('/uploads/images/gallery/2021-05/anonexistingimage.png');
|
|
$resp->assertStatus(404);
|
|
$resp->assertSeeText('Image Not Found');
|
|
}
|
|
} |