From 97437b8af3ac20580f8d75178ed320691393f796 Mon Sep 17 00:00:00 2001
From: bopol <bopol@e.email>
Date: Tue, 19 May 2020 21:51:39 +0200
Subject: [PATCH] apply @stypox suggestions

---
 .../java/org/schabi/newpipe/util/ShareUtils.java  | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/app/src/main/java/org/schabi/newpipe/util/ShareUtils.java b/app/src/main/java/org/schabi/newpipe/util/ShareUtils.java
index 1bb460520..a306715e4 100644
--- a/app/src/main/java/org/schabi/newpipe/util/ShareUtils.java
+++ b/app/src/main/java/org/schabi/newpipe/util/ShareUtils.java
@@ -16,36 +16,33 @@ public final class ShareUtils {
      * Open the url with the system default browser.
      * <p>
      * If no browser is set as default, fallbacks to
-     * {@link ShareUtils#openUrlBrowserChooser(Context, String)}
+     * {@link ShareUtils#openInDefaultApp(Context, String)}
      *
      * @param context the context to use
      * @param url     the url to browse
      */
     public static void openUrlInBrowser(final Context context, final String url) {
-        final Intent intent = new Intent(Intent.ACTION_VIEW);
-        intent.setData(Uri.parse(url));
-
         final String defaultBrowserPackageName = getDefaultBrowserPackageName(context);
 
         if (defaultBrowserPackageName.equals("android")) {
             // no browser set as default
-            openUrlBrowserChooser(context, url);
+            openInDefaultApp(context, url);
         } else {
+            final Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
             intent.setPackage(defaultBrowserPackageName);
             context.startActivity(intent);
         }
     }
 
     /**
-     * Open the url with application chooser, including browser and apps able to open url.
+     * Open the url in the default app set to open this type of link
      * <p>
-     * If any app (except browser, typically NewPipe) is set as default,
-     * it will nor open in browser, neither open the chooser, but just the default app.
+     * If no app is set as default, it will open a chooser
      *
      * @param context the context to use
      * @param url     the url to browse
      */
-    private static void openUrlBrowserChooser(final Context context, final String url) {
+    private static void openInDefaultApp(final Context context, final String url) {
         final Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
         context.startActivity(Intent.createChooser(
                 intent, context.getString(R.string.share_dialog_title)));