Mirrors/NewPipe
1
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipe.git synced 2024-11-25 12:32:31 +01:00
Code Issues Releases Activity

Remove "default" from audio track already present message

Browse Source 
We don't know if, on muxed video streams we get for all services which support
multiple audio languages, that the audio language returned is the original one
or not, even if it should be the case.

In order to avoid saying potential false information, this word has been
removed from the string resource (ID and value) and the corresponding layout ID
in the download dialog.
This commit is contained in:
AudricV 2023-05-02 00:11:09 +02:00
parent 22671ca16c
commit d89a3c6c4d
No known key found for this signature in database
GPG Key ID: DA92EC7905614198
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java
View File

@ -448,7 +448,7 @@ public class DownloadDialog extends DialogFragment
dialogBinding.audioStreamSpinner.setVisibility(View.VISIBLE); dialogBinding.audioStreamSpinner.setVisibility(View.VISIBLE);
dialogBinding.audioTrackSpinner.setVisibility( dialogBinding.audioTrackSpinner.setVisibility(
wrappedAudioTracks.size() > 1 ? View.VISIBLE : View.GONE); wrappedAudioTracks.size() > 1 ? View.VISIBLE : View.GONE);
dialogBinding.defaultAudioTrackPresentText.setVisibility(View.GONE); dialogBinding.audioTrackPresentInVideoText.setVisibility(View.GONE);
} }
private void setupVideoSpinner() { private void setupVideoSpinner() {
@ -469,7 +469,7 @@ public class DownloadDialog extends DialogFragment
dialogBinding.audioTrackSpinner.setVisibility( dialogBinding.audioTrackSpinner.setVisibility(
isVideoOnly && wrappedAudioTracks.size() > 1 ? View.VISIBLE : View.GONE); isVideoOnly && wrappedAudioTracks.size() > 1 ? View.VISIBLE : View.GONE);
dialogBinding.defaultAudioTrackPresentText.setVisibility( dialogBinding.audioTrackPresentInVideoText.setVisibility(
!isVideoOnly && wrappedAudioTracks.size() > 1 ? View.VISIBLE : View.GONE); !isVideoOnly && wrappedAudioTracks.size() > 1 ? View.VISIBLE : View.GONE);
} }
@ -484,7 +484,7 @@ public class DownloadDialog extends DialogFragment
setRadioButtonsState(true); setRadioButtonsState(true);
dialogBinding.audioStreamSpinner.setVisibility(View.GONE); dialogBinding.audioStreamSpinner.setVisibility(View.GONE);
dialogBinding.audioTrackSpinner.setVisibility(View.GONE); dialogBinding.audioTrackSpinner.setVisibility(View.GONE);
dialogBinding.defaultAudioTrackPresentText.setVisibility(View.GONE); dialogBinding.audioTrackPresentInVideoText.setVisibility(View.GONE);
} }

6
app/src/main/res/layout/download_dialog.xml
View File

@ -94,7 +94,7 @@
tools:visibility="gone" /> tools:visibility="gone" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView
android:id="@+id/default_audio_track_present_text" android:id="@+id/audio_track_present_in_video_text"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_below="@+id/audio_stream_spinner" android:layout_below="@+id/audio_stream_spinner"
@ -102,14 +102,14 @@
android:layout_marginRight="24dp" android:layout_marginRight="24dp"
android:layout_marginBottom="12dp" android:layout_marginBottom="12dp"
android:gravity="center" android:gravity="center"
android:text="@string/default_audio_track_present" android:text="@string/audio_track_present_in_video"
android:textSize="12sp" /> android:textSize="12sp" />
<org.schabi.newpipe.views.NewPipeTextView <org.schabi.newpipe.views.NewPipeTextView
android:id="@+id/threads_text_view" android:id="@+id/threads_text_view"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_below="@+id/default_audio_track_present_text" android:layout_below="@+id/audio_track_present_in_video_text"
android:layout_marginLeft="24dp" android:layout_marginLeft="24dp"
android:layout_marginRight="24dp" android:layout_marginRight="24dp"
android:layout_marginBottom="6dp" android:layout_marginBottom="6dp"

2
app/src/main/res/values/strings.xml
View File

@ -767,7 +767,7 @@
<string name="enumeration_comma">,</string> <string name="enumeration_comma">,</string>
<string name="toggle_all">Toggle all</string> <string name="toggle_all">Toggle all</string>
<string name="streams_not_yet_supported_removed">Streams which are not yet supported by the downloader are not shown</string> <string name="streams_not_yet_supported_removed">Streams which are not yet supported by the downloader are not shown</string>
<string name="default_audio_track_present">The default audio track should be already present in this stream</string> <string name="audio_track_present_in_video">An audio track should be already present in this stream</string>
<string name="selected_stream_external_player_not_supported">The selected stream is not supported by external players</string> <string name="selected_stream_external_player_not_supported">The selected stream is not supported by external players</string>
<string name="no_audio_streams_available_for_external_players">No audio streams are available for external players</string> <string name="no_audio_streams_available_for_external_players">No audio streams are available for external players</string>
<string name="no_video_streams_available_for_external_players">No video streams are available for external players</string> <string name="no_video_streams_available_for_external_players">No video streams are available for external players</string>