Add the separate utility class PlayButtonHelper to handle the initialization of the listeners.
The ClickListeners on playlist controls had different behaviours. This commit fixes that.
The commit also refactors the way how the app determines whether it is started for the first time. The previous version was not clean and recent in this PR caused it to fail.
The breakage of these tests is related to the channel tabs changes.
The testRememberRecentStreams test method has been removed, as it doesn't seem
to be relevant anymore to managing subscriptions.
YouTube's "Desktop Max" thumbnails are 2560x423, while our previous placeholder banner was 2550x427. The extractor actually returns a lower resolution "Desktop Max" banner at 1060x175, but the ratio wrt 2560x423 is off by ~0.1%
The PNG was optimized with OptiPNG
The previous "main" tab is now just a normal tab returned in getTabs().
Various part of the code that used to handle channels as ListInfo now either take the first (playable, i.e. with streams) tab (e.g. the ChannelTabPlayQueue), or take all of them combined (e.g. the feed).
* added LoadingDialog for improving download experience
* [LoadingDialog] Apply some review comments and make title customizable.
* removed permission handling from loading Dialog
* fix checks
* remove <p> Tag from first sentence
---------
Co-authored-by: rishabaggarwal <Rishabaggarwal@sharechat.com>
Co-authored-by: TobiGr <tobigr@users.noreply.github.com>
The RuntimeException was not explicitly declared and thus not caught at every call of this constructor. This change ensures that this possible exception is handled by the dedicated error handlers.
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Odia)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Malayalam)
Currently translated at 6.6% (5 of 75 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Swedish)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (German)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (German)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Swedish)
Currently translated at 99.7% (684 of 686 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Estonian)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Albanian)
Currently translated at 82.7% (568 of 686 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (French)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Hindi)
Currently translated at 100.0% (686 of 686 strings)
Added translation using Weblate (Burmese)
Translated using Weblate (ryu (generated) (ryu))
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Slovak)
Currently translated at 98.9% (679 of 686 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (German)
Currently translated at 100.0% (686 of 686 strings)
Translated using Weblate (ryu (generated) (ryu))
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Croatian)
Currently translated at 91.8% (628 of 684 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (French)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (ryu (generated) (ryu))
Currently translated at 98.6% (675 of 684 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Odia)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Urdu)
Currently translated at 74.2% (508 of 684 strings)
Translated using Weblate (Vietnamese)
Currently translated at 99.2% (679 of 684 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Korean)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Portuguese (Portugal))
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Portuguese (Portugal))
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Galician)
Currently translated at 99.5% (681 of 684 strings)
Translated using Weblate (Finnish)
Currently translated at 89.9% (615 of 684 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (684 of 684 strings)
Co-authored-by: Agnieszka C <aga_04@o2.pl>
Co-authored-by: Alex25820 <alexs25820@gmail.com>
Co-authored-by: Alexthegib <jcwkgxc@nightorb.com>
Co-authored-by: AudricV <AudricV@users.noreply.hosted.weblate.org>
Co-authored-by: C. Rüdinger <Mail-an-CR@web.de>
Co-authored-by: Eric <hamburger2048@users.noreply.hosted.weblate.org>
Co-authored-by: Fjuro <ifjuro@proton.me>
Co-authored-by: GET100PERCENT <eraofphysics@yahoo.com>
Co-authored-by: Hoseok Seo <ddinghoya@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Igor Rückert <igorruckert@yahoo.com.br>
Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Co-authored-by: J. Lavoie <j.lavoie@net-c.ca>
Co-authored-by: Jani Kinnunen <janikinnunen340@gmail.com>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: Joel A <joeax910@student.liu.se>
Co-authored-by: Jorge Pelaez <jorpelae@yahoo.co.jp>
Co-authored-by: Linerly <linerly@protonmail.com>
Co-authored-by: Milan Šalka <salka.milan@googlemail.com>
Co-authored-by: Milo Ivir <mail@milotype.de>
Co-authored-by: Philip Goto <philip.goto@gmail.com>
Co-authored-by: Priit Jõerüüt <hwlate@joeruut.com>
Co-authored-by: Rex_sa <rex.sa@pm.me>
Co-authored-by: Sergio Marques <so.boston.android@gmail.com>
Co-authored-by: ShareASmile <aapshergill@gmail.com>
Co-authored-by: Shifa Graphics <shifagraphix@gmail.com>
Co-authored-by: TXRdev Archive <lckphanaf9999@gmail.com>
Co-authored-by: Vasilis K <skyhirules@gmail.com>
Co-authored-by: VfBFan <drop0815@posteo.de>
Co-authored-by: W L <wl@mailhole.de>
Co-authored-by: WB <dln0@proton.me>
Co-authored-by: Weblate <noreply@weblate.org>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Co-authored-by: kuragehime <kuragehime641@gmail.com>
Co-authored-by: nautilusx <translate@disroot.org>
Co-authored-by: random r <epsilin@yopmail.com>
Co-authored-by: ssantos <ssantos@web.de>
Co-authored-by: tellmeY18 <vysakh_b190622ec@nitc.ac.in>
Co-authored-by: thami simo <simo.azad@gmail.com>
Co-authored-by: Макар Разин <makarrazin14@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ml/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pt/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pt_PT/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/
Translation: NewPipe/Metadata
Currently translated at 5.3% (4 of 75 strings)
Translated using Weblate (Urdu)
Currently translated at 73.2% (501 of 684 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Polish)
Currently translated at 61.3% (46 of 75 strings)
Translated using Weblate (Hindi)
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (75 of 75 strings)
Translated using Weblate (Estonian)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Hindi)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (684 of 684 strings)
Translated using Weblate (German)
Currently translated at 100.0% (684 of 684 strings)
Co-authored-by: Agnieszka C <aga_04@o2.pl>
Co-authored-by: Eric <hamburger2048@users.noreply.hosted.weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: Priit Jõerüüt <hwlate@joeruut.com>
Co-authored-by: Rex_sa <rex.sa@pm.me>
Co-authored-by: ShareASmile <aapshergill@gmail.com>
Co-authored-by: Shifa Graphics <shifagraphix@gmail.com>
Co-authored-by: Vasilis K <skyhirules@gmail.com>
Co-authored-by: VfBFan <drop0815@posteo.de>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Co-authored-by: random r <epsilin@yopmail.com>
Co-authored-by: rickeesingh <rickeesingh231@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ar/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/hi/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/it/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pa/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ur/
Translation: NewPipe/Metadata
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Hindi)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (French)
Currently translated at 93.2% (69 of 74 strings)
Translated using Weblate (Toki Pona)
Currently translated at 6.5% (45 of 683 strings)
Translated using Weblate (Toki Pona)
Currently translated at 2.7% (2 of 74 strings)
Translated using Weblate (French)
Currently translated at 100.0% (683 of 683 strings)
Added translation using Weblate (Toki Pona)
Translated using Weblate (ryu (generated) (ryu))
Currently translated at 96.3% (658 of 683 strings)
Translated using Weblate (English (United Kingdom))
Currently translated at 8.3% (57 of 683 strings)
Translated using Weblate (Portuguese (Portugal))
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Hindi)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (French)
Currently translated at 100.0% (683 of 683 strings)
Co-authored-by: Eric <hamburger2048@users.noreply.hosted.weblate.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: John Donne <akheron@zaclys.net>
Co-authored-by: Linerly <linerly@protonmail.com>
Co-authored-by: Rex_sa <rex.sa@pm.me>
Co-authored-by: ShareASmile <aapshergill@gmail.com>
Co-authored-by: Translator <kvb@tuta.io>
Co-authored-by: Weblate <noreply@weblate.org>
Co-authored-by: William <Electroboss@users.noreply.hosted.weblate.org>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: kuragehime <kuragehime641@gmail.com>
Co-authored-by: ssantos <ssantos@web.de>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/tok/
Translation: NewPipe/Metadata
Currently translated at 72.9% (54 of 74 strings)
Translated using Weblate (Estonian)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Hindi)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Swedish)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (German)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (683 of 683 strings)
Translated using Weblate (Dutch)
Currently translated at 64.8% (48 of 74 strings)
Translated using Weblate (German)
Currently translated at 81.0% (60 of 74 strings)
Translated using Weblate (Albanian)
Currently translated at 81.0% (552 of 681 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (French)
Currently translated at 93.2% (69 of 74 strings)
Translated using Weblate (Vietnamese)
Currently translated at 33.7% (25 of 74 strings)
Translated using Weblate (Bulgarian)
Currently translated at 66.5% (453 of 681 strings)
Translated using Weblate (Finnish)
Currently translated at 87.3% (595 of 681 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (German)
Currently translated at 81.0% (60 of 74 strings)
Translated using Weblate (Vietnamese)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (Japanese)
Currently translated at 12.1% (9 of 74 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (Vietnamese)
Currently translated at 32.4% (24 of 74 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (Hindi)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (Vietnamese)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (74 of 74 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (Romanian)
Currently translated at 96.0% (654 of 681 strings)
Translated using Weblate (Japanese)
Currently translated at 99.7% (679 of 681 strings)
Translated using Weblate (Korean)
Currently translated at 12.1% (9 of 74 strings)
Translated using Weblate (Korean)
Currently translated at 12.1% (9 of 74 strings)
Translated using Weblate (Vietnamese)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (Korean)
Currently translated at 100.0% (681 of 681 strings)
Translated using Weblate (German)
Currently translated at 79.7% (59 of 74 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (681 of 681 strings)
Co-authored-by: Agnieszka C <aga_04@o2.pl>
Co-authored-by: AhHyeon An <toto1444@gmail.com>
Co-authored-by: AioiLight <info@aioilight.space>
Co-authored-by: Alex25820 <alexs25820@gmail.com>
Co-authored-by: Anonymous <deni76@tutanota.com>
Co-authored-by: Anxhelo Lushka <anxhelo1995@gmail.com>
Co-authored-by: Arsi Kiikka <arsikiikka20@gmail.com>
Co-authored-by: David Braz <davidbrazps2@gmail.com>
Co-authored-by: Edward <edwardchirita@mailbox.org>
Co-authored-by: Eric <hamburger2048@users.noreply.hosted.weblate.org>
Co-authored-by: Etienne Barrier <etienne.barrier@gmail.com>
Co-authored-by: Fjuro <ifjuro@proton.me>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Igor Rückert <igorruckert@yahoo.com.br>
Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: MJ Kim <faith@users.noreply.hosted.weblate.org>
Co-authored-by: Philip Goto <philip.goto@gmail.com>
Co-authored-by: Priit Jõerüüt <hwlate@joeruut.com>
Co-authored-by: Rex_sa <rex.sa@pm.me>
Co-authored-by: ShareASmile <aapshergill@gmail.com>
Co-authored-by: TXRdev Archive <lckphanaf9999@gmail.com>
Co-authored-by: Vasilis K <skyhirules@gmail.com>
Co-authored-by: VfBFan <drop0815@posteo.de>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Co-authored-by: kuragehime <kuragehime641@gmail.com>
Co-authored-by: nautilusx <translate@disroot.org>
Co-authored-by: ngocanhtve <ngocanh.tve@gmail.com>
Co-authored-by: random r <epsilin@yopmail.com>
Co-authored-by: ssantos <ssantos@web.de>
Co-authored-by: zmni <zmni@outlook.com>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ar/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ja/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ko/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/nl/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sv/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/vi/
Translation: NewPipe/Metadata
- don't check for isAudioOnly == !videoEnabled, as this prevents enabling again
video and text tracks renderers in some cases;
- when reloading play queue manager if that's needed, disable or enable video
and text tracks renderers, as they may need to be enabled again in some cases
like starting a video in main player, opening play queue, switching to
background player on it and switching back to main player;
- disable or enable video renderers also for streams with AUDIO_STREAM
StreamType, as doing so doesn't raise any issue and simplifies code;
- reword and move some comments to make them easier to understand.
- fix checkstyle errors
- tests do not run in order, so each one has to do its own assertions separately from what others did
- the uid of an entity in the database needn't be the same of the one created in-memory, since the uid gets assigned upon inserting in the database
- some database functions return a `Completable` that doesn't do anything until it is subscribed to or awaited, so I added `.awaitBlocking()` where needed
- the data of an entity in-memory does not get updated automatically when the corresponding entity in the database is changed, so some tests have been removed
- `manager.insertSubscription` only inserts recent streams, so they need to have a date set on them (I also made related items hardcoded and not dependent on what the channel is currently doing)
