From 0a04fad85b272b4e6a72def37b6fc05b63fb83b7 Mon Sep 17 00:00:00 2001
From: Bogdan <mynameisbogdan@users.noreply.github.com>
Date: Mon, 14 Aug 2023 00:03:18 +0300
Subject: [PATCH] Show warning when using the docker update mechanism

(cherry picked from commit cc538c4b2d33a1734c45c0667776d946596107e9)
---
 frontend/src/Settings/General/UpdateSettings.js  | 1 +
 frontend/src/System/Updates/Updates.js           | 3 +--
 src/NzbDrone.Common/Extensions/PathExtensions.cs | 2 +-
 src/NzbDrone.Core/Localization/Core/en.json      | 1 +
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/frontend/src/Settings/General/UpdateSettings.js b/frontend/src/Settings/General/UpdateSettings.js
index b94ab7d33..95e8eccda 100644
--- a/frontend/src/Settings/General/UpdateSettings.js
+++ b/frontend/src/Settings/General/UpdateSettings.js
@@ -76,6 +76,7 @@ function UpdateSettings(props) {
                 type={inputTypes.CHECK}
                 name="updateAutomatically"
                 helpText={translate('UpdateAutomaticallyHelpText')}
+                helpTextWarning={updateMechanism.value === 'docker' ? translate('AutomaticUpdatesDisabledDocker', { appName: 'Radarr' }) : undefined}
                 onChange={onInputChange}
                 {...updateAutomatically}
               />
diff --git a/frontend/src/System/Updates/Updates.js b/frontend/src/System/Updates/Updates.js
index f2c78811d..1f53e1b74 100644
--- a/frontend/src/System/Updates/Updates.js
+++ b/frontend/src/System/Updates/Updates.js
@@ -112,7 +112,6 @@ class Updates extends Component {
                   name={icons.CHECK_CIRCLE}
                   size={30}
                 />
-
                 <div className={styles.message}>
                   {translate('OnLatestVersion')}
                 </div>
@@ -151,7 +150,7 @@ class Updates extends Component {
 
                           {
                             update.branch === 'master' ?
-                              null:
+                              null :
                               <Label
                                 className={styles.label}
                               >
diff --git a/src/NzbDrone.Common/Extensions/PathExtensions.cs b/src/NzbDrone.Common/Extensions/PathExtensions.cs
index 1ce4aef40..e41cfb5d0 100644
--- a/src/NzbDrone.Common/Extensions/PathExtensions.cs
+++ b/src/NzbDrone.Common/Extensions/PathExtensions.cs
@@ -150,7 +150,7 @@ public static bool IsParentPath(this string parentPath, string childPath)
 
         public static bool IsPathValid(this string path, PathValidationType validationType)
         {
-            if (path.ContainsInvalidPathChars() || string.IsNullOrWhiteSpace(path))
+            if (string.IsNullOrWhiteSpace(path) || path.ContainsInvalidPathChars())
             {
                 return false;
             }
diff --git a/src/NzbDrone.Core/Localization/Core/en.json b/src/NzbDrone.Core/Localization/Core/en.json
index 143b392b6..e4d251123 100644
--- a/src/NzbDrone.Core/Localization/Core/en.json
+++ b/src/NzbDrone.Core/Localization/Core/en.json
@@ -90,6 +90,7 @@
   "Automatic": "Automatic",
   "AutomaticAdd": "Automatic Add",
   "AutomaticSearch": "Automatic Search",
+  "AutomaticUpdatesDisabledDocker": "Automatic updates are not directly supported when using the Docker update mechanism. You will need to update the container image outside of {appName} or use a script",
   "AvailabilityDelay": "Availability Delay",
   "AvailabilityDelayHelpText": "Amount of time before or after available date to search for Movie",
   "Backup": "Backup",