Mirrors/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr.git synced 2024-08-18 16:29:41 +02:00
Code Issues Releases Wiki Activity

Avoid using GetAllMovies in DeleteBadMediaCovers

Browse Source
This commit is contained in:
Qstick 2023-07-09 23:19:21 -05:00
parent 7a5ae56a96
commit 1c99ce8876
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/NzbDrone.Core.Test/HealthCheck/Checks/DeleteBadMediaCovers.cs → src/NzbDrone.Core.Test/HealthCheck/Checks/DeleteBadMediaCoversFixture.cs
View File

@ -20,25 +20,25 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks
public class DeleteBadMediaCoversFixture : CoreTest<DeleteBadMediaCovers> public class DeleteBadMediaCoversFixture : CoreTest<DeleteBadMediaCovers>
{ {
private List<MetadataFile> _metadata; private List<MetadataFile> _metadata;
private List<Movie> _movies; private Dictionary<int, string> _movies;
[SetUp] [SetUp]
public void Setup() public void Setup()
{ {
_movies = Builder<Movie>.CreateListOfSize(1) _movies = new Dictionary<int, string>
.All() {
.With(c => c.Path = "C:\\Movie\\".AsOsAgnostic()) { 1, "C:\\Movie\\".AsOsAgnostic() }
.Build().ToList(); };
_metadata = Builder<MetadataFile>.CreateListOfSize(1) _metadata = Builder<MetadataFile>.CreateListOfSize(1)
.Build().ToList(); .Build().ToList();
Mocker.GetMock<IMovieService>() Mocker.GetMock<IMovieService>()
.Setup(c => c.GetAllMovies()) .Setup(c => c.AllMoviePaths())
.Returns(_movies); .Returns(_movies);
Mocker.GetMock<IMetadataFileService>() Mocker.GetMock<IMetadataFileService>()
.Setup(c => c.GetFilesByMovie(_movies.First().Id)) .Setup(c => c.GetFilesByMovie(_movies.First().Key))
.Returns(_metadata); .Returns(_metadata);
Mocker.GetMock<IConfigService>().SetupGet(c => c.CleanupMetadataImages).Returns(true); Mocker.GetMock<IConfigService>().SetupGet(c => c.CleanupMetadataImages).Returns(true);
@ -73,7 +73,7 @@ public void should_not_run_if_flag_is_false()
Subject.Clean(); Subject.Clean();
Mocker.GetMock<IConfigService>().VerifySet(c => c.CleanupMetadataImages = true, Times.Never()); Mocker.GetMock<IConfigService>().VerifySet(c => c.CleanupMetadataImages = true, Times.Never());
Mocker.GetMock<IMovieService>().Verify(c => c.GetAllMovies(), Times.Never()); Mocker.GetMock<IMovieService>().Verify(c => c.AllMoviePaths(), Times.Never());
AssertImageWasNotRemoved(); AssertImageWasNotRemoved();
} }

6
src/NzbDrone.Core/Housekeeping/Housekeepers/DeleteBadMediaCovers.cs
View File

@ -37,18 +37,18 @@ public void Clean()
return; return;
} }
var movies = _movieService.GetAllMovies(); var movies = _movieService.AllMoviePaths();
foreach (var movie in movies) foreach (var movie in movies)
{ {
var images = _metaFileService.GetFilesByMovie(movie.Id) var images = _metaFileService.GetFilesByMovie(movie.Key)
.Where(c => c.LastUpdated > new DateTime(2014, 12, 27) && c.RelativePath.EndsWith(".jpg", StringComparison.InvariantCultureIgnoreCase)); .Where(c => c.LastUpdated > new DateTime(2014, 12, 27) && c.RelativePath.EndsWith(".jpg", StringComparison.InvariantCultureIgnoreCase));
foreach (var image in images) foreach (var image in images)
{ {
try try
{ {
var path = Path.Combine(movie.Path, image.RelativePath); var path = Path.Combine(movie.Value, image.RelativePath);
if (!IsValid(path)) if (!IsValid(path))
{ {
_logger.Debug("Deleting invalid image file " + path); _logger.Debug("Deleting invalid image file " + path);