diff --git a/src/NzbDrone.Core.Test/Datastore/Converters/CommandConverterFixture.cs b/src/NzbDrone.Core.Test/Datastore/Converters/CommandConverterFixture.cs index ef5b5dc1a..db8077c5c 100644 --- a/src/NzbDrone.Core.Test/Datastore/Converters/CommandConverterFixture.cs +++ b/src/NzbDrone.Core.Test/Datastore/Converters/CommandConverterFixture.cs @@ -1,7 +1,10 @@ +using System.Data; using System.Data.SQLite; using FluentAssertions; +using Moq; using NUnit.Framework; using NzbDrone.Core.Datastore.Converters; +using NzbDrone.Core.Messaging.Commands; using NzbDrone.Core.Movies.Commands; using NzbDrone.Core.Test.Framework; @@ -42,6 +45,14 @@ public void should_return_command_when_getting_json_from_db() Subject.Parse(data).Should().BeOfType(); } + [Test] + public void should_return_unknown_command_when_getting_json_from_db() + { + var data = "{\"name\": \"EnsureMediaCovers\"}"; + + Subject.Parse(data).Should().BeOfType(); + } + [Test] public void should_return_null_for_null_value_when_getting_from_db() { diff --git a/src/NzbDrone.Core/Datastore/Converters/CommandConverter.cs b/src/NzbDrone.Core/Datastore/Converters/CommandConverter.cs index ad6e53545..37271bdab 100644 --- a/src/NzbDrone.Core/Datastore/Converters/CommandConverter.cs +++ b/src/NzbDrone.Core/Datastore/Converters/CommandConverter.cs @@ -27,7 +27,11 @@ public override Command Parse(object value) if (impType == null) { - throw new CommandNotFoundException(contract); + var result = JsonSerializer.Deserialize(stringValue, SerializerSettings); + + result.ContractName = contract; + + return result; } return (Command)JsonSerializer.Deserialize(stringValue, impType, SerializerSettings); diff --git a/src/NzbDrone.Core/Messaging/Commands/CommandExecutor.cs b/src/NzbDrone.Core/Messaging/Commands/CommandExecutor.cs index ee1946b1e..fdd7e18af 100644 --- a/src/NzbDrone.Core/Messaging/Commands/CommandExecutor.cs +++ b/src/NzbDrone.Core/Messaging/Commands/CommandExecutor.cs @@ -71,8 +71,7 @@ private void ExecuteCommand(TCommand command, CommandModel commandMode try { - var handlerContract = typeof(IExecute<>).MakeGenericType(command.GetType()); - handler = (IExecute)_serviceFactory.Build(handlerContract); + handler = (IExecute)_serviceFactory.Build(typeof(IExecute)); _logger.Trace("{0} -> {1}", command.GetType().Name, handler.GetType().Name); diff --git a/src/NzbDrone.Core/Messaging/Commands/UnknownCommand.cs b/src/NzbDrone.Core/Messaging/Commands/UnknownCommand.cs new file mode 100644 index 000000000..fa579916e --- /dev/null +++ b/src/NzbDrone.Core/Messaging/Commands/UnknownCommand.cs @@ -0,0 +1,11 @@ +namespace NzbDrone.Core.Messaging.Commands +{ + public class UnknownCommand : Command + { + public override bool SendUpdatesToClient => false; + + public override string CompletionMessage => "Skipped"; + + public string ContractName { get; set; } + } +} diff --git a/src/NzbDrone.Core/Messaging/Commands/UnknownCommandExecutor.cs b/src/NzbDrone.Core/Messaging/Commands/UnknownCommandExecutor.cs new file mode 100644 index 000000000..08fb2725d --- /dev/null +++ b/src/NzbDrone.Core/Messaging/Commands/UnknownCommandExecutor.cs @@ -0,0 +1,24 @@ +using System; +using System.Collections.Generic; +using System.Linq; +using System.Text; +using System.Threading.Tasks; +using NLog; + +namespace NzbDrone.Core.Messaging.Commands +{ + public class UnknownCommandExecutor : IExecute + { + private readonly Logger _logger; + + public UnknownCommandExecutor(Logger logger) + { + _logger = logger; + } + + public void Execute(UnknownCommand message) + { + _logger.Debug("Ignoring unknown command {0}", message.ContractName); + } + } +}