From 4d1dbfe55907a4ef6890fd5b3f797d6cebe6aa91 Mon Sep 17 00:00:00 2001
From: Taloth Saldono <Taloth@users.noreply.github.com>
Date: Sun, 3 May 2020 18:48:20 +0200
Subject: [PATCH] Lock CommandQueueManager.PushMany too

---
 .../Messaging/Commands/CommandQueueManager.cs | 53 ++++++++++---------
 1 file changed, 28 insertions(+), 25 deletions(-)

diff --git a/src/NzbDrone.Core/Messaging/Commands/CommandQueueManager.cs b/src/NzbDrone.Core/Messaging/Commands/CommandQueueManager.cs
index 1071aebea..8d2b62af7 100644
--- a/src/NzbDrone.Core/Messaging/Commands/CommandQueueManager.cs
+++ b/src/NzbDrone.Core/Messaging/Commands/CommandQueueManager.cs
@@ -57,39 +57,42 @@ public List<CommandModel> PushMany<TCommand>(List<TCommand> commands)
         {
             _logger.Trace("Publishing {0} commands", commands.Count);
 
-            var commandModels = new List<CommandModel>();
-            var existingCommands = _commandQueue.QueuedOrStarted();
-
-            foreach (var command in commands)
+            lock (_commandQueue)
             {
-                var existing = existingCommands.SingleOrDefault(c => c.Name == command.Name && CommandEqualityComparer.Instance.Equals(c.Body, command));
+                var commandModels = new List<CommandModel>();
+                var existingCommands = _commandQueue.QueuedOrStarted();
 
-                if (existing != null)
+                foreach (var command in commands)
                 {
-                    continue;
+                    var existing = existingCommands.FirstOrDefault(c => c.Name == command.Name && CommandEqualityComparer.Instance.Equals(c.Body, command));
+
+                    if (existing != null)
+                    {
+                        continue;
+                    }
+
+                    var commandModel = new CommandModel
+                    {
+                        Name = command.Name,
+                        Body = command,
+                        QueuedAt = DateTime.UtcNow,
+                        Trigger = CommandTrigger.Unspecified,
+                        Priority = CommandPriority.Normal,
+                        Status = CommandStatus.Queued
+                    };
+
+                    commandModels.Add(commandModel);
                 }
 
-                var commandModel = new CommandModel
+                _repo.InsertMany(commandModels);
+
+                foreach (var commandModel in commandModels)
                 {
-                    Name = command.Name,
-                    Body = command,
-                    QueuedAt = DateTime.UtcNow,
-                    Trigger = CommandTrigger.Unspecified,
-                    Priority = CommandPriority.Normal,
-                    Status = CommandStatus.Queued
-                };
+                    _commandQueue.Add(commandModel);
+                }
 
-                commandModels.Add(commandModel);
+                return commandModels;
             }
-
-            _repo.InsertMany(commandModels);
-
-            foreach (var commandModel in commandModels)
-            {
-                _commandQueue.Add(commandModel);
-            }
-
-            return commandModels;
         }
 
         public CommandModel Push<TCommand>(TCommand command, CommandPriority priority = CommandPriority.Normal, CommandTrigger trigger = CommandTrigger.Unspecified)