From 5baeba18cbb515127c96168a1ed3d71d40ad8507 Mon Sep 17 00:00:00 2001 From: ItsME6969 <89707006+ItsME6969@users.noreply.github.com> Date: Sun, 28 May 2023 12:26:48 -0500 Subject: [PATCH] Fixed: Correctly parse SCENE and P2P BluRay DISKS releases (#8595) * Update QualityParserFixture.cs Added Releases following P2P naming convention * Update QualityParser.cs Added support for P2P BR-DISK naming convention * Update src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs Co-authored-by: Bogdan * Update QualityParserFixture.cs --------- Co-authored-by: Bogdan --- .../ParserTests/QualityParserFixture.cs | 16 +++++++++++++++- src/NzbDrone.Core/Parser/QualityParser.cs | 2 +- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs b/src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs index de6245e2e..6d9906bdb 100644 --- a/src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs +++ b/src/NzbDrone.Core.Test/ParserTests/QualityParserFixture.cs @@ -275,7 +275,6 @@ public void should_parse_bluray720p_quality(string title, bool proper) [TestCase("Movie.Name.2011.1080p.UHD.BluRay.DD5.1.HDR.x265-CtrlHD.mkv", false)] [TestCase("Movie.Name.2016.German.DTS.DL.1080p.UHDBD.x265-TDO.mkv", false)] [TestCase("Movie.Name.2021.1080p.BDLight.x265-AVCDVD", false)] - [TestCase("Random.Title.2010.1080p.HD.DVD.AVC.DDP.5.1-GRouP", false)] [TestCase("Movie.Title.2012.German.DL.1080p.UHD2BD.x264-QfG", false)] public void should_parse_bluray1080p_quality(string title, bool proper) { @@ -344,6 +343,21 @@ public void should_parse_remux2160p_quality(string title) [TestCase("Movie Name.1993..BD25.ISO")] [TestCase("Movie.Title.2012.Bluray.1080p.3D.AVC.DTS-HD.MA.5.1.iso")] [TestCase("Movie.Title.1996.Bluray.ISO")] + [TestCase("Random.Title.2010.1080p.HD.DVD.AVC.DDP.5.1-GRouP")] + [TestCase("Movie Title 2005 1080p USA Blu-ray AVC DTS-HD MA 5.1-PTP")] + [TestCase("Movie Title 2014 1080p Blu-ray AVC DTS-HD MA 5.1-PTP")] + [TestCase("Movie Title 1976 2160p UHD Blu-ray DTS-HD MA 5.1 DV HDR HEVC-UNTOUCHED")] + [TestCase("Movie Title 2004 1080p FRA Blu-ray VC-1 TrueHD 5.1-HDBEE")] + [TestCase("BD25.Movie.Title.1994.1080p.DTS-HD")] + [TestCase("Movie.Title.1997.1080p.NL.BD-50")] + [TestCase("Movie Title 2009 3D BD 2009 UNTOUCHED")] + [TestCase("Movie.Title.1982.1080p.HD.DVD.VC-1.DD+.5.1")] + [TestCase("Movie.Title.2007.1080p.HD.DVD.DD+.AVC")] + [TestCase("Movie.Title.2008.1080i.XXX.Blu-ray.MPEG-2.LPCM2.0.ISO")] + [TestCase("Movie.Title.2008.BONUS.GERMAN.SUBBED.COMPLETE.BLURAY")] + [TestCase("The German 2021 Bluray AVC")] + [TestCase("German.Only.Movie.2021.French.1080p.BluRay.AVC-UNTAVC")] + [TestCase("Movie.Title.2008.US.Directors.Cut.UHD.BD66.Blu-ray")] public void should_parse_brdisk_1080p_quality(string title) { ParseAndVerifyQuality(title, Source.BLURAY, false, Resolution.R1080p, Modifier.BRDISK); diff --git a/src/NzbDrone.Core/Parser/QualityParser.cs b/src/NzbDrone.Core/Parser/QualityParser.cs index 4cc2b8917..99aec304a 100644 --- a/src/NzbDrone.Core/Parser/QualityParser.cs +++ b/src/NzbDrone.Core/Parser/QualityParser.cs @@ -41,7 +41,7 @@ public class QualityParser private static readonly Regex MPEG2Regex = new (@"\b(?MPEG[-_. ]?2)\b"); - private static readonly Regex BRDISKRegex = new (@"\b(COMPLETE|ISO|BDISO|BD25|BD50|BR.?DISK)\b", + private static readonly Regex BRDISKRegex = new (@"^(?!.*\b((?proper)\b",