Mirrors/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr.git synced 2024-11-04 10:02:40 +01:00
Code Issues Releases Wiki Activity

Fixed: Convert MonoOnly to PosixOnly

Browse Source
This commit is contained in:
ta264 2019-10-14 21:21:00 +01:00 committed by Qstick
parent 2b39865251
commit 5c07b39b04
15 changed files with 42 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/NzbDrone.Common.Test/DiskTests/DiskTransferServiceFixture.cs
View File

@ -37,7 +37,7 @@ public void SetUp()
[Test]
public void should_use_verified_transfer_on_mono()
{
MonoOnly();
PosixOnly();
Subject.VerificationMode.Should().Be(DiskTransferVerificationMode.TryTransactional);
}

2
src/NzbDrone.Common.Test/DiskTests/FreeSpaceFixtureBase.cs
View File

@ -31,7 +31,7 @@ public void should_get_free_space_for_folder_that_doesnt_exist()
[Test]
public void should_be_able_to_check_space_on_ramdrive()
{
MonoOnly();
PosixOnly();
Subject.GetAvailableSpace("/run/").Should().NotBe(0);
}

2
src/NzbDrone.Common.Test/EnsureTest/PathExtensionFixture.cs
View File

@ -19,7 +19,7 @@ public void EnsureWindowsPath(string path)
[TestCase(@"/var/user/file with, comma.mkv")]
public void EnsureLinuxPath(string path)
{
MonoOnly();
PosixOnly();
Ensure.That(path, () => path).IsValidPath();
}
}

10
src/NzbDrone.Common.Test/PathExtensionFixture.cs
View File

@ -52,7 +52,7 @@ public void Clean_Path_Windows(string dirty, string clean)
[TestCase(@"//CAPITAL//lower// ", @"/CAPITAL/lower")]
public void Clean_Path_Linux(string dirty, string clean)
{
MonoOnly();
PosixOnly();
var result = dirty.CleanFilePath();
result.Should().Be(clean);
@ -152,14 +152,14 @@ public void path_should_return_parent_windows(string path, string parentPath)
[TestCase(@"/test", "/")]
public void path_should_return_parent_mono(string path, string parentPath)
{
MonoOnly();
PosixOnly();
path.GetParentPath().Should().Be(parentPath);
}
[Test]
public void path_should_return_parent_for_oversized_path()
{
MonoOnly();
PosixOnly();
// This test will fail on Windows if long path support is not enabled: https://www.howtogeek.com/266621/how-to-make-windows-10-accept-file-paths-over-260-characters/
// It will also fail if the app isn't configured to use long path (such as resharper): https://blogs.msdn.microsoft.com/jeremykuhne/2016/07/30/net-4-6-2-and-long-paths-on-windows-10/
@ -232,7 +232,7 @@ public void get_actual_casing_should_return_actual_casing_for_local_dir_in_windo
[Test]
public void get_actual_casing_should_return_original_value_in_linux()
{
MonoOnly();
PosixOnly();
var path = Directory.GetCurrentDirectory();
path.GetActualCasing().Should().Be(path);
path.GetActualCasing().Should().Be(path);
@ -306,7 +306,7 @@ public void GetAncestorFolders_should_return_all_ancestors_in_path_Windows()
[Test]
public void GetAncestorFolders_should_return_all_ancestors_in_path_Linux()
{
MonoOnly();
PosixOnly();
var path = @"/Test/TV/Series Title";
var result = path.GetAncestorFolders();

2
src/NzbDrone.Common/EnvironmentInfo/RuntimeInfo.cs
View File

@ -138,6 +138,7 @@ private static bool InternalIsTesting()
{
var currentAssemblyLocation = typeof(RuntimeInfo).Assembly.Location;
if (currentAssemblyLocation.ToLower().Contains("_output")) return true;
if (currentAssemblyLocation.ToLower().Contains("_tests")) return true;
}
catch
{
@ -148,6 +149,7 @@ private static bool InternalIsTesting()
if (lowerCurrentDir.Contains("vsts")) return true;
if (lowerCurrentDir.Contains("buildagent")) return true;
if (lowerCurrentDir.Contains("_output")) return true;
if (lowerCurrentDir.Contains("_tests")) return true;
return false;
}

2
src/NzbDrone.Core.Test/Download/CompletedDownloadServiceFixture.cs
View File

@ -347,7 +347,7 @@ public void should_warn_if_path_is_not_valid_for_windows()
[Test]
public void should_warn_if_path_is_not_valid_for_linux()
{
MonoOnly();
PosixOnly();
_trackedDownload.DownloadItem.OutputPath = new OsPath(@"C:\Invalid\Mono\Path");

10
src/NzbDrone.Core.Test/HealthCheck/Checks/MonoDebugFixture.cs
View File

@ -1,4 +1,5 @@
using NUnit.Framework;
using NUnit.Framework;
using NzbDrone.Common.EnvironmentInfo;
using NzbDrone.Core.HealthCheck.Checks;
using NzbDrone.Core.Test.Framework;
using NzbDrone.Test.Common;
@ -17,9 +18,12 @@ private void GivenHasStackFrame(bool hasStackFrame)
}
[Test]
public void should_return_ok_if_windows()
public void should_return_ok_if_not_mono()
{
WindowsOnly();
if (PlatformInfo.IsMono)
{
throw new IgnoreException("non mono specific test");
}
Subject.Check().ShouldBeOk();
}

6
src/NzbDrone.Core.Test/HealthCheck/Checks/UpdateCheckFixture.cs
View File

@ -31,7 +31,7 @@ public void should_return_error_when_app_folder_is_write_protected()
[Test]
public void should_return_error_when_app_folder_is_write_protected_and_update_automatically_is_enabled()
{
MonoOnly();
PosixOnly();
const string startupFolder = @"/opt/nzbdrone";
@ -53,7 +53,7 @@ public void should_return_error_when_app_folder_is_write_protected_and_update_au
[Test]
public void should_return_error_when_ui_folder_is_write_protected_and_update_automatically_is_enabled()
{
MonoOnly();
PosixOnly();
const string startupFolder = @"/opt/nzbdrone";
const string uiFolder = @"/opt/nzbdrone/UI";
@ -80,7 +80,7 @@ public void should_return_error_when_ui_folder_is_write_protected_and_update_aut
[Test]
public void should_not_return_error_when_app_folder_is_write_protected_and_external_script_enabled()
{
MonoOnly();
PosixOnly();
Mocker.GetMock<IConfigFileProvider>()
.Setup(s => s.UpdateAutomatically)

2
src/NzbDrone.Core.Test/MediaFiles/MediaFileServiceTests/FilterFixture.cs
View File

@ -111,7 +111,7 @@ public void filter_should_return_none_existing_files_ignoring_case()
[Test]
public void filter_should_return_none_existing_files_not_ignoring_case()
{
MonoOnly();
PosixOnly();
var files = new List<string>()
{

2
src/NzbDrone.Core.Test/MediaFiles/MovieImport/Specifications/NotUnpackingSpecificationFixture.cs
View File

@ -74,7 +74,7 @@ public void should_return_false_if_in_working_folder_and_last_write_time_was_rec
[Test]
public void should_return_false_if_unopacking_on_linux()
{
MonoOnly();
PosixOnly();
GivenInWorkingFolder();
GivenLastWriteTimeUtc(DateTime.UtcNow.AddDays(-5));

8
src/NzbDrone.Core.Test/UpdateTests/UpdateServiceFixture.cs
View File

@ -181,7 +181,7 @@ public void should_not_extract_if_verification_fails()
}
[Test]
[Platform("Mono")]
[Platform(Exclude="Win")]
public void should_run_script_if_configured()
{
const string scriptPath = "/tmp/nzbdrone/update.sh";
@ -194,7 +194,7 @@ public void should_run_script_if_configured()
}
[Test]
[Platform("Mono")]
[Platform(Exclude="Win")]
public void should_throw_if_script_is_not_set()
{
const string scriptPath = "/tmp/nzbdrone/update.sh";
@ -208,7 +208,7 @@ public void should_throw_if_script_is_not_set()
}
[Test]
[Platform("Mono")]
[Platform(Exclude="Win")]
public void should_throw_if_script_is_null()
{
const string scriptPath = "/tmp/nzbdrone/update.sh";
@ -222,7 +222,7 @@ public void should_throw_if_script_is_null()
}
[Test]
[Platform("Mono")]
[Platform(Exclude="Win")]
public void should_throw_if_script_path_does_not_exist()
{
const string scriptPath = "/tmp/nzbdrone/update.sh";

4
src/NzbDrone.Core.Test/ValidationTests/SystemFolderValidatorFixture.cs
View File

@ -51,7 +51,7 @@ public void should_not_be_valid_if_child_of_windows_folder()
[Test]
public void should_not_be_valid_if_set_to_bin_folder()
{
MonoOnly();
PosixOnly();
var bin = OsInfo.IsOsx ? "/System" : "/bin";
var movie = Builder<Movie>.CreateNew()
@ -64,7 +64,7 @@ public void should_not_be_valid_if_set_to_bin_folder()
[Test]
public void should_not_be_valid_if_child_of_bin_folder()
{
MonoOnly();
PosixOnly();
var bin = OsInfo.IsOsx ? "/System" : "/bin";
var movie = Builder<Movie>.CreateNew()

4
src/NzbDrone.Mono.Test/DiskProviderTests/DiskProviderFixture.cs
View File

@ -13,12 +13,12 @@
namespace NzbDrone.Mono.Test.DiskProviderTests
{
[TestFixture]
[Platform("Mono")]
[Platform(Exclude="Win")]
public class DiskProviderFixture : DiskProviderFixtureBase<DiskProvider>
{
public DiskProviderFixture()
{
MonoOnly();
PosixOnly();
}
protected override void SetWritePermissions(string path, bool writable)

6
src/NzbDrone.Mono.Test/DiskProviderTests/FreeSpaceFixture.cs
View File

@ -1,16 +1,16 @@
using NUnit.Framework;
using NUnit.Framework;
using NzbDrone.Common.Test.DiskTests;
using NzbDrone.Mono.Disk;
namespace NzbDrone.Mono.Test.DiskProviderTests
{
[TestFixture]
[Platform("Mono")]
[Platform(Exclude="Win")]
public class FreeSpaceFixture : FreeSpaceFixtureBase<DiskProvider>
{
public FreeSpaceFixture()
{
MonoOnly();
PosixOnly();
}
}
}

8
src/NzbDrone.Test.Common/TestBase.cs
View File

@ -162,6 +162,14 @@ protected void WindowsOnly()
}
}
protected void PosixOnly()
{
if (OsInfo.IsWindows)
{
throw new IgnoreException("non windows specific test");
}
}
protected void MonoOnly()
{
if (!PlatformInfo.IsMono)