mirror of
https://github.com/Radarr/Radarr.git
synced 2024-10-27 06:02:33 +01:00
Fixed: Update Mono version check now minimum is 5.20
This commit is contained in:
parent
d210082dad
commit
8428de7a00
@ -28,9 +28,9 @@ private void GivenOutput(string version)
|
|||||||
.Returns(new Version(version));
|
.Returns(new Version(version));
|
||||||
}
|
}
|
||||||
|
|
||||||
[TestCase("5.18")]
|
|
||||||
[TestCase("5.20")]
|
[TestCase("5.20")]
|
||||||
[TestCase("6.4")]
|
[TestCase("6.4")]
|
||||||
|
[TestCase("6.12")]
|
||||||
public void should_return_ok(string version)
|
public void should_return_ok(string version)
|
||||||
{
|
{
|
||||||
GivenOutput(version);
|
GivenOutput(version);
|
||||||
@ -71,6 +71,7 @@ public void should_return_warning(string version)
|
|||||||
[TestCase("5.12")]
|
[TestCase("5.12")]
|
||||||
[TestCase("5.14")]
|
[TestCase("5.14")]
|
||||||
[TestCase("5.16")]
|
[TestCase("5.16")]
|
||||||
|
[TestCase("5.18")]
|
||||||
public void should_return_error(string version)
|
public void should_return_error(string version)
|
||||||
{
|
{
|
||||||
GivenOutput(version);
|
GivenOutput(version);
|
||||||
|
@ -26,19 +26,9 @@ public override HealthCheck Check()
|
|||||||
|
|
||||||
var monoVersion = _platformInfo.Version;
|
var monoVersion = _platformInfo.Version;
|
||||||
|
|
||||||
// Known buggy Mono versions
|
|
||||||
if (monoVersion == new Version("4.4.0") || monoVersion == new Version("4.4.1"))
|
|
||||||
{
|
|
||||||
_logger.Debug("Mono version {0}", monoVersion);
|
|
||||||
return new HealthCheck(GetType(),
|
|
||||||
HealthCheckResult.Error,
|
|
||||||
$"Currently installed Mono version {monoVersion} has a bug that causes issues connecting to indexers/download clients. You should upgrade to a higher version",
|
|
||||||
"#currently_installed_mono_version_is_old_and_unsupported");
|
|
||||||
}
|
|
||||||
|
|
||||||
// Currently best stable Mono version (5.18 gets us .net 4.7.2 support)
|
// Currently best stable Mono version (5.18 gets us .net 4.7.2 support)
|
||||||
var bestVersion = new Version("5.20");
|
var bestVersion = new Version("5.20");
|
||||||
var targetVersion = new Version("5.18");
|
var targetVersion = new Version("5.20");
|
||||||
if (monoVersion >= targetVersion)
|
if (monoVersion >= targetVersion)
|
||||||
{
|
{
|
||||||
_logger.Debug("Mono version is {0} or better: {1}", targetVersion, monoVersion);
|
_logger.Debug("Mono version is {0} or better: {1}", targetVersion, monoVersion);
|
||||||
@ -46,7 +36,7 @@ public override HealthCheck Check()
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Stable Mono versions
|
// Stable Mono versions
|
||||||
var stableVersion = new Version("5.18");
|
var stableVersion = new Version("5.20");
|
||||||
if (monoVersion >= stableVersion)
|
if (monoVersion >= stableVersion)
|
||||||
{
|
{
|
||||||
_logger.Debug("Mono version is {0} or better: {1}", stableVersion, monoVersion);
|
_logger.Debug("Mono version is {0} or better: {1}", stableVersion, monoVersion);
|
||||||
@ -56,7 +46,7 @@ public override HealthCheck Check()
|
|||||||
"#currently_installed_mono_version_is_supported_but_upgrading_is_recommended");
|
"#currently_installed_mono_version_is_supported_but_upgrading_is_recommended");
|
||||||
}
|
}
|
||||||
|
|
||||||
var oldVersion = new Version("5.4");
|
var oldVersion = new Version("5.20");
|
||||||
if (monoVersion >= oldVersion)
|
if (monoVersion >= oldVersion)
|
||||||
{
|
{
|
||||||
return new HealthCheck(GetType(),
|
return new HealthCheck(GetType(),
|
||||||
|
Loading…
Reference in New Issue
Block a user