From 8753c232c79ec3e9e39cf4f1c7414f8dec067239 Mon Sep 17 00:00:00 2001
From: vawen <vawenus@gmail.com>
Date: Tue, 29 Dec 2015 13:25:36 +0100
Subject: [PATCH] Fix: Paths with colons prevent Sonarr from communicating with
 Transmission

Issue #954
---
 .../TransmissionTests/TransmissionFixture.cs  | 27 +++++++++++++++++++
 .../Clients/Transmission/Transmission.cs      |  4 +++
 2 files changed, 31 insertions(+)

diff --git a/src/NzbDrone.Core.Test/Download/DownloadClientTests/TransmissionTests/TransmissionFixture.cs b/src/NzbDrone.Core.Test/Download/DownloadClientTests/TransmissionTests/TransmissionFixture.cs
index cfdebdcce..0c81a1d47 100644
--- a/src/NzbDrone.Core.Test/Download/DownloadClientTests/TransmissionTests/TransmissionFixture.cs
+++ b/src/NzbDrone.Core.Test/Download/DownloadClientTests/TransmissionTests/TransmissionFixture.cs
@@ -19,6 +19,7 @@ public class TransmissionFixture : DownloadClientFixtureBase<Transmission>
         protected TransmissionTorrent _downloading;
         protected TransmissionTorrent _failed;
         protected TransmissionTorrent _completed;
+        protected TransmissionTorrent _magnet;
         protected Dictionary<string, object> _transmissionConfigItems;
 
         [SetUp]
@@ -80,6 +81,17 @@ public void Setup()
                         DownloadDir = "somepath"
                     };
 
+            _magnet = new TransmissionTorrent
+            {
+                HashString = "HASH",
+                IsFinished = false,
+                Status = TransmissionTorrentStatus.Downloading,
+                Name = _title,
+                TotalSize = 0,
+                LeftUntilDone = 100,
+                DownloadDir = "somepath"
+            };
+
             Mocker.GetMock<ITorrentFileInfoReader>()
                   .Setup(s => s.GetHashFromTorrentFile(It.IsAny<byte[]>()))
                   .Returns("CBC2F069FE8BB2F544EAE707D75BCD3DE9DCF951");
@@ -171,6 +183,14 @@ protected void PrepareClientToReturnCompletedItem()
                 });
         }
 
+        protected void PrepareClientToReturnMagnetItem()
+        {
+            GivenTorrents(new List<TransmissionTorrent>
+                {
+                    _magnet
+                });
+        }
+
         [Test]
         public void queued_item_should_have_required_properties()
         {
@@ -203,6 +223,13 @@ public void completed_download_should_have_required_properties()
             VerifyCompleted(item);
         }
 
+        [Test]
+        public void magnet_download_should_not_return_the_item()
+        {
+            PrepareClientToReturnMagnetItem();
+            Subject.GetItems().Count().Should().Be(0);
+        }
+
         [Test]
         public void Download_should_return_unique_id()
         {
diff --git a/src/NzbDrone.Core/Download/Clients/Transmission/Transmission.cs b/src/NzbDrone.Core/Download/Clients/Transmission/Transmission.cs
index 4c37bbbbf..75f39787b 100644
--- a/src/NzbDrone.Core/Download/Clients/Transmission/Transmission.cs
+++ b/src/NzbDrone.Core/Download/Clients/Transmission/Transmission.cs
@@ -99,6 +99,10 @@ public override IEnumerable<DownloadClientItem> GetItems()
 
             foreach (var torrent in torrents)
             {
+                // If totalsize == 0 the torrent is a magnet downloading metadata
+                if (torrent.TotalSize == 0)
+                    continue;
+
                 var outputPath = _remotePathMappingService.RemapRemoteToLocal(Settings.Host, new OsPath(torrent.DownloadDir));
 
                 if (Settings.TvCategory.IsNotNullOrWhiteSpace())