From 9ea753011b2781b830645574c960918693cee07d Mon Sep 17 00:00:00 2001 From: Taloth Saldono Date: Sat, 21 May 2016 23:02:02 +0200 Subject: [PATCH] Added round-robin over httpbin.org hosts for httpclient tests. --- .../Http/HttpClientFixture.cs | 71 +++++++++---------- 1 file changed, 32 insertions(+), 39 deletions(-) diff --git a/src/NzbDrone.Common.Test/Http/HttpClientFixture.cs b/src/NzbDrone.Common.Test/Http/HttpClientFixture.cs index 5ea03c912..d4a74e32a 100644 --- a/src/NzbDrone.Common.Test/Http/HttpClientFixture.cs +++ b/src/NzbDrone.Common.Test/Http/HttpClientFixture.cs @@ -22,7 +22,11 @@ namespace NzbDrone.Common.Test.Http [TestFixture(typeof(ManagedHttpDispatcher))] [TestFixture(typeof(CurlHttpDispatcher))] public class HttpClientFixture : TestBase where TDispatcher : IHttpDispatcher - { + { + private static string[] _httpBinHosts = new[] { "eu.httpbin.org", "httpbin.org" }; + private static int _httpBinRandom; + private string _httpBinHost; + [SetUp] public void SetUp() { @@ -32,15 +36,19 @@ public void SetUp() Mocker.SetConstant>(new IHttpRequestInterceptor[0]); Mocker.SetConstant(Mocker.Resolve()); + // Used for manual testing of socks proxies. //Mocker.GetMock() // .Setup(v => v.GetProxySettings(It.IsAny())) // .Returns(new HttpProxySettings(ProxyType.Socks5, "127.0.0.1", 5476, "", false)); + + // Roundrobin over the two servers, to reduce the chance of hitting the ratelimiter. + _httpBinHost = _httpBinHosts[_httpBinRandom++ % _httpBinHosts.Length]; } [Test] public void should_execute_simple_get() { - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); var response = Subject.Execute(request); @@ -50,7 +58,7 @@ public void should_execute_simple_get() [Test] public void should_execute_https_get() { - var request = new HttpRequest("https://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("https://{0}/get", _httpBinHost)); var response = Subject.Execute(request); @@ -60,7 +68,7 @@ public void should_execute_https_get() [Test] public void should_execute_typed_get() { - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); var response = Subject.Get(request); @@ -72,7 +80,7 @@ public void should_execute_simple_post() { var message = "{ my: 1 }"; - var request = new HttpRequest("http://eu.httpbin.org/post"); + var request = new HttpRequest(string.Format("http://{0}/post", _httpBinHost)); request.SetContent(message); var response = Subject.Post(request); @@ -83,7 +91,7 @@ public void should_execute_simple_post() [TestCase("gzip")] public void should_execute_get_using_gzip(string compression) { - var request = new HttpRequest("http://eu.httpbin.org/" + compression); + var request = new HttpRequest(string.Format("http://{0}/{1}", _httpBinHost, compression)); var response = Subject.Get(request); @@ -99,7 +107,7 @@ public void should_execute_get_using_gzip(string compression) [TestCase(HttpStatusCode.BadGateway)] public void should_throw_on_unsuccessful_status_codes(int statusCode) { - var request = new HttpRequest("http://eu.httpbin.org/status/" + statusCode); + var request = new HttpRequest(string.Format("http://{0}/status/{1}", _httpBinHost, statusCode)); var exception = Assert.Throws(() => Subject.Get(request)); @@ -111,7 +119,7 @@ public void should_throw_on_unsuccessful_status_codes(int statusCode) [Test] public void should_not_follow_redirects_when_not_in_production() { - var request = new HttpRequest("http://eu.httpbin.org/redirect/1"); + var request = new HttpRequest(string.Format("http://{0}/redirect/1", _httpBinHost)); Subject.Get(request); @@ -121,7 +129,7 @@ public void should_not_follow_redirects_when_not_in_production() [Test] public void should_follow_redirects() { - var request = new HttpRequest("http://eu.httpbin.org/redirect/1"); + var request = new HttpRequest(string.Format("http://{0}/redirect/1", _httpBinHost)); request.AllowAutoRedirect = true; Subject.Get(request); @@ -132,7 +140,7 @@ public void should_follow_redirects() [Test] public void should_send_user_agent() { - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); var response = Subject.Get(request); @@ -146,7 +154,7 @@ public void should_send_user_agent() [TestCase("Accept", "text/xml, text/rss+xml, application/rss+xml")] public void should_send_headers(string header, string value) { - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); request.Headers.Add(header, value); var response = Subject.Get(request); @@ -169,7 +177,7 @@ public void should_not_download_file_with_error() [Test] public void should_send_cookie() { - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); request.Cookies["my"] = "cookie"; var response = Subject.Get(request); @@ -226,12 +234,12 @@ public void should_not_send_cookie_to_other_host() [Test] public void should_not_store_response_cookie() { - var requestSet = new HttpRequest("http://eu.httpbin.org/cookies/set?my=cookie"); + var requestSet = new HttpRequest(string.Format("http://{0}/cookies/set?my=cookie", _httpBinHost)); requestSet.AllowAutoRedirect = false; var responseSet = Subject.Get(requestSet); - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); var response = Subject.Get(request); @@ -243,13 +251,13 @@ public void should_not_store_response_cookie() [Test] public void should_store_response_cookie() { - var requestSet = new HttpRequest("http://eu.httpbin.org/cookies/set?my=cookie"); + var requestSet = new HttpRequest(string.Format("http://{0}/cookies/set?my=cookie", _httpBinHost)); requestSet.AllowAutoRedirect = false; requestSet.StoreResponseCookie = true; var responseSet = Subject.Get(requestSet); - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); var response = Subject.Get(request); @@ -265,14 +273,14 @@ public void should_store_response_cookie() [Test] public void should_overwrite_response_cookie() { - var requestSet = new HttpRequest("http://eu.httpbin.org/cookies/set?my=cookie"); + var requestSet = new HttpRequest(string.Format("http://{0}/cookies/set?my=cookie", _httpBinHost)); requestSet.AllowAutoRedirect = false; requestSet.StoreResponseCookie = true; requestSet.Cookies["my"] = "oldcookie"; var responseSet = Subject.Get(requestSet); - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); var response = Subject.Get(request); @@ -288,7 +296,7 @@ public void should_overwrite_response_cookie() [Test] public void should_throw_on_http429_too_many_requests() { - var request = new HttpRequest("http://eu.httpbin.org/status/429"); + var request = new HttpRequest(string.Format("http://{0}/status/429", _httpBinHost)); Assert.Throws(() => Subject.Get(request)); @@ -308,7 +316,7 @@ public void should_call_interceptor() .Setup(v => v.PostResponse(It.IsAny())) .Returns(r => r); - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); Subject.Get(request); @@ -330,7 +338,7 @@ public void should_parse_malformed_cloudflare_cookie(string culture) { // the date is bad in the below - should be 13-Jul-2016 string malformedCookie = @"__cfduid=d29e686a9d65800021c66faca0a29b4261436890790; expires=Wed, 13-Jul-16 16:19:50 GMT; path=/; HttpOnly"; - var requestSet = new HttpRequestBuilder("http://eu.httpbin.org/response-headers") + var requestSet = new HttpRequestBuilder(string.Format("http://{0}/response-headers", _httpBinHost)) .AddQueryParam("Set-Cookie", malformedCookie) .Build(); @@ -339,7 +347,7 @@ public void should_parse_malformed_cloudflare_cookie(string culture) var responseSet = Subject.Get(requestSet); - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); var response = Subject.Get(request); @@ -364,7 +372,7 @@ public void should_reject_malformed_domain_cookie(string malformedCookie) try { // the date is bad in the below - should be 13-Jul-2016 - string url = "http://eu.httpbin.org/response-headers?Set-Cookie=" + Uri.EscapeUriString(malformedCookie); + string url = string.Format("http://{0}/response-headers?Set-Cookie={1}", _httpBinHost, Uri.EscapeUriString(malformedCookie)); var requestSet = new HttpRequest(url); requestSet.AllowAutoRedirect = false; @@ -372,7 +380,7 @@ public void should_reject_malformed_domain_cookie(string malformedCookie) var responseSet = Subject.Get(requestSet); - var request = new HttpRequest("http://eu.httpbin.org/get"); + var request = new HttpRequest(string.Format("http://{0}/get", _httpBinHost)); var response = Subject.Get(request); @@ -384,21 +392,6 @@ public void should_reject_malformed_domain_cookie(string malformedCookie) { } } - - public void should_submit_formparameters_in_body() - { - Assert.Fail(); - } - - public void should_submit_attachments_as_multipart() - { - Assert.Fail(); - } - - public void should_submit_formparameters_as_multipart_if_attachments_exist() - { - Assert.Fail(); - } } public class HttpBinResource