Mirrors/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr.git synced 2024-09-11 20:12:41 +02:00
Code Issues Releases Wiki Activity

Bump minimum Mono version to 5.18

Browse Source 
Fixes #4722
This commit is contained in:
Qstick 2020-08-12 22:07:23 -04:00
parent 487546d6f3
commit c96ffafe50
3 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/NzbDrone.Core.Test/HealthCheck/Checks/MonoVersionCheckFixture.cs
View File

@ -30,6 +30,7 @@ private void GivenOutput(string version)
[TestCase("5.18")] [TestCase("5.18")]
[TestCase("5.20")] [TestCase("5.20")]
[TestCase("6.4")]
public void should_return_ok(string version) public void should_return_ok(string version)
{ {
GivenOutput(version); GivenOutput(version);
@ -37,7 +38,6 @@ public void should_return_ok(string version)
Subject.Check().ShouldBeOk(); Subject.Check().ShouldBeOk();
} }
[TestCase("5.16")]
public void should_return_notice(string version) public void should_return_notice(string version)
{ {
GivenOutput(version); GivenOutput(version);
@ -45,8 +45,6 @@ public void should_return_notice(string version)
Subject.Check().ShouldBeNotice(); Subject.Check().ShouldBeNotice();
} }
[TestCase("5.4")]
[TestCase("5.8")]
public void should_return_warning(string version) public void should_return_warning(string version)
{ {
GivenOutput(version); GivenOutput(version);
@ -67,6 +65,12 @@ public void should_return_warning(string version)
[TestCase("4.2")] [TestCase("4.2")]
[TestCase("4.4.0")] [TestCase("4.4.0")]
[TestCase("4.4.1")] [TestCase("4.4.1")]
[TestCase("5.4")]
[TestCase("5.8")]
[TestCase("5.10")]
[TestCase("5.12")]
[TestCase("5.14")]
[TestCase("5.16")]
public void should_return_error(string version) public void should_return_error(string version)
{ {
GivenOutput(version); GivenOutput(version);

18
src/NzbDrone.Core/HealthCheck/Checks/MonoVersionCheck.cs
View File

@ -46,30 +46,28 @@ public override HealthCheck Check()
} }
// Stable Mono versions // Stable Mono versions
var stableVersion = new Version("5.16"); var stableVersion = new Version("5.18");
if (monoVersion >= stableVersion) if (monoVersion >= stableVersion)
{ {
_logger.Debug("Mono version is {0} or better: {1}", stableVersion, monoVersion); _logger.Debug("Mono version is {0} or better: {1}", stableVersion, monoVersion);
return new HealthCheck(GetType(), return new HealthCheck(GetType(),
HealthCheckResult.Notice, HealthCheckResult.Notice,
$"Currently installed Mono version {monoVersion} is supported but upgrading to {bestVersion} is recommended.", string.Format(_localizationService.GetLocalizedString("MonoVersionCheckUpgradeRecommendedMessage"), monoVersion, bestVersion),
"#currently-installed-mono-version-is-supported-but-upgrading-is-recommended"); "#currently-installed-mono-version-is-supported-but-upgrading-is-recommended");
} }
// Old but supported Mono versions, there are known bugs var oldVersion = new Version("5.4");
var supportedVersion = new Version("5.4"); if (monoVersion >= oldVersion)
if (monoVersion >= supportedVersion)
{ {
_logger.Debug("Mono version is {0} or better: {1}", supportedVersion, monoVersion);
return new HealthCheck(GetType(), return new HealthCheck(GetType(),
HealthCheckResult.Warning, HealthCheckResult.Error,
$"Currently installed Mono version {monoVersion} is supported but has some known issues. Please upgrade Mono to version {bestVersion}.", string.Format(_localizationService.GetLocalizedString("MonoVersionCheckUpgradeRecommendedMessage"), monoVersion, bestVersion),
"#currently-installed-mono-version-is-supported-but-upgrading-is-recommended"); "#currently-installed-mono-version-is-old-and-unsupported");
} }
return new HealthCheck(GetType(), return new HealthCheck(GetType(),
HealthCheckResult.Error, HealthCheckResult.Error,
$"Currently installed Mono version {monoVersion} is old and unsupported. Please upgrade Mono to version {bestVersion}.", string.Format(_localizationService.GetLocalizedString("MonoVersionCheckUpgradeRecommendedMessage"), monoVersion, bestVersion),
"#currently-installed-mono-version-is-old-and-unsupported"); "#currently-installed-mono-version-is-old-and-unsupported");
} }

3
src/NzbDrone.Core/Localization/Core/en.json
View File

@ -143,6 +143,9 @@
"MonitoredOnly": "Monitored Only", "MonitoredOnly": "Monitored Only",
"MonoNotNetCoreCheckMessage": "Please upgrade to the .NET Core version of Radarr", "MonoNotNetCoreCheckMessage": "Please upgrade to the .NET Core version of Radarr",
"MonoTlsCheckMessage": "Radarr Mono 4.x tls workaround still enabled, consider removing MONO_TLS_PROVIDER=legacy environment option", "MonoTlsCheckMessage": "Radarr Mono 4.x tls workaround still enabled, consider removing MONO_TLS_PROVIDER=legacy environment option",
"MonoVersionCheckNotSupportedMessage": "Currently installed Mono version {0} is no longer supported. Please upgrade Mono to version {1}.",
"MonoVersionCheckOldNotSupportedMessage": "Currently installed Mono version {0} is old and unsupported. Please upgrade Mono to version {1}.",
"MonoVersionCheckUpgradeRecommendedMessage": "Currently installed Mono version {0} is supported but upgrading to {1} is recommended.",
"Month": "Month", "Month": "Month",
"MoreInfo": "More Info", "MoreInfo": "More Info",
"MountCheckMessage": "Mount containing a movie path is mounted read-only: ", "MountCheckMessage": "Mount containing a movie path is mounted read-only: ",