From d5c1f588396d4160d7afa217d52c86c55fe8f47a Mon Sep 17 00:00:00 2001 From: Bogdan Date: Wed, 26 Jul 2023 09:25:24 +0300 Subject: [PATCH] Fixed: Ensure validation for Auto Tagging specifications --- .../AutoTagging/AutoTaggingController.cs | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/Radarr.Api.V3/AutoTagging/AutoTaggingController.cs b/src/Radarr.Api.V3/AutoTagging/AutoTaggingController.cs index 6b08692c2..981382c0a 100644 --- a/src/Radarr.Api.V3/AutoTagging/AutoTaggingController.cs +++ b/src/Radarr.Api.V3/AutoTagging/AutoTaggingController.cs @@ -1,10 +1,12 @@ using System.Collections.Generic; using System.Linq; using FluentValidation; +using FluentValidation.Results; using Microsoft.AspNetCore.Mvc; using NzbDrone.Common.Extensions; using NzbDrone.Core.AutoTagging; using NzbDrone.Core.AutoTagging.Specifications; +using NzbDrone.Core.Validation; using Radarr.Http; using Radarr.Http.REST; using Radarr.Http.REST.Attributes; @@ -52,6 +54,9 @@ protected override AutoTaggingResource GetResourceById(int id) public ActionResult Create(AutoTaggingResource autoTagResource) { var model = autoTagResource.ToModel(_specifications); + + Validate(model); + return Created(_autoTaggingService.Insert(model).Id); } @@ -60,6 +65,9 @@ public ActionResult Create(AutoTaggingResource autoTagResou public ActionResult Update(AutoTaggingResource resource) { var model = resource.ToModel(_specifications); + + Validate(model); + _autoTaggingService.Update(model); return Accepted(model.Id); @@ -85,5 +93,23 @@ public object GetTemplates() return schema; } + + private void Validate(AutoTag definition) + { + foreach (var validationResult in definition.Specifications.Select(spec => spec.Validate())) + { + VerifyValidationResult(validationResult); + } + } + + private void VerifyValidationResult(ValidationResult validationResult) + { + var result = new NzbDroneValidationResult(validationResult.Errors); + + if (!result.IsValid) + { + throw new ValidationException(result.Errors); + } + } } }