From 6a489a0b8fe4f7c8c77cd3420d43c6ef88cfebbc Mon Sep 17 00:00:00 2001 From: Mark McDowall Date: Wed, 9 Jan 2019 17:51:54 -0800 Subject: [PATCH] Fixed: Importing of completed download when not a child of the download client output path --- .../MediaFiles/ImportApprovedEpisodesFixture.cs | 16 ++++++++++++++++ .../EpisodeImport/ImportApprovedEpisodes.cs | 10 ++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/NzbDrone.Core.Test/MediaFiles/ImportApprovedEpisodesFixture.cs b/src/NzbDrone.Core.Test/MediaFiles/ImportApprovedEpisodesFixture.cs index d6755949a..e947bd476 100644 --- a/src/NzbDrone.Core.Test/MediaFiles/ImportApprovedEpisodesFixture.cs +++ b/src/NzbDrone.Core.Test/MediaFiles/ImportApprovedEpisodesFixture.cs @@ -374,6 +374,22 @@ namespace NzbDrone.Core.Test.MediaFiles Mocker.GetMock().Verify(v => v.Add(It.Is(c => c.OriginalFilePath == $"{name}.mkv"))); } + [Test] + public void should_use_folder_info_release_title_to_find_relative_path_when_file_is_not_in_download_client_item_output_directory() + { + var name = "Series.Title.S01E01.720p.HDTV.x264-Sonarr"; + var outputPath = Path.Combine(@"C:\Test\Unsorted\TV\".AsOsAgnostic(), name); + var localEpisode = _approvedDecisions.First().LocalEpisode; + + _downloadClientItem.OutputPath = new OsPath(Path.Combine(@"C:\Test\Unsorted\TV-Other\".AsOsAgnostic(), name)); + localEpisode.FolderEpisodeInfo = new ParsedEpisodeInfo { ReleaseTitle = name }; + localEpisode.Path = Path.Combine(outputPath, "subfolder", name + ".mkv"); + + Subject.Import(new List { _approvedDecisions.First() }, true, _downloadClientItem); + + Mocker.GetMock().Verify(v => v.Add(It.Is(c => c.OriginalFilePath == $"{name}\\subfolder\\{name}.mkv".AsOsAgnostic()))); + } + [Test] public void should_delete_existing_metadata_files_with_the_same_path() { diff --git a/src/NzbDrone.Core/MediaFiles/EpisodeImport/ImportApprovedEpisodes.cs b/src/NzbDrone.Core/MediaFiles/EpisodeImport/ImportApprovedEpisodes.cs index b2b62d0e5..c923523e5 100644 --- a/src/NzbDrone.Core/MediaFiles/EpisodeImport/ImportApprovedEpisodes.cs +++ b/src/NzbDrone.Core/MediaFiles/EpisodeImport/ImportApprovedEpisodes.cs @@ -162,12 +162,18 @@ namespace NzbDrone.Core.MediaFiles.EpisodeImport private string GetOriginalFilePath(DownloadClientItem downloadClientItem, LocalEpisode localEpisode) { + var path = localEpisode.Path; + if (downloadClientItem != null) { - return downloadClientItem.OutputPath.Directory.ToString().GetRelativePath(localEpisode.Path); + var outputDirectory = downloadClientItem.OutputPath.Directory.ToString(); + + if (outputDirectory.IsParentPath(path)) + { + return outputDirectory.GetRelativePath(path); + } } - var path = localEpisode.Path; var folderEpisodeInfo = localEpisode.FolderEpisodeInfo; if (folderEpisodeInfo != null)