From 88a45822ae86379e03da525b34e874f93fea266c Mon Sep 17 00:00:00 2001
From: Ivandro Jao <Ivandrofly@gmail.com>
Date: Wed, 23 Oct 2024 11:29:35 +0100
Subject: [PATCH 1/4] Remove outdated pre-compilation tasks from project file

The pre-compilation tasks referencing NHunspell and executing OS-specific scripts were removed from the project file. This cleanup streamlines the build process and removes dependencies on external scripts that are no longer necessary.

Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
---
 src/ui/SubtitleEdit.csproj | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/src/ui/SubtitleEdit.csproj b/src/ui/SubtitleEdit.csproj
index 4a3b9e09c..12db7acac 100644
--- a/src/ui/SubtitleEdit.csproj
+++ b/src/ui/SubtitleEdit.csproj
@@ -284,17 +284,7 @@
     <Compile Remove="Logic\VideoPlayers\DirectShowLib2005.cs" />
     <EmbeddedResource Remove="Forms\GetDictionaries.resx" />
   </ItemGroup>
-  <Target Name="BeforeCompile">
-    <XmlPeek XmlInputPath="$(ProjectDir)packages.config" Query="//package[@id='NHunspell']/@version">
-      <Output TaskParameter="Result" PropertyName="HunspellVersion" />
-    </XmlPeek>
-    <PropertyGroup>
-      <HunspellDir>..\..\packages\NHunspell.$(HunspellVersion)\content\</HunspellDir>
-    </PropertyGroup>
-    <Copy SourceFiles="@(HunspellAssemblies -> '$(HunspellDir)%(Identity)')" DestinationFolder="$(OutputPath)" SkipUnchangedFiles="True" />
-    <Exec Condition="'$(OS)' == 'Windows_NT'" Command="%22$(SolutionDir)\build_helpers.bat%22 rev %22$(ConfigurationName)%22" />
-    <Exec Condition="'$(OS)' == 'Unix'" Command="bash $(ProjectDir)../../build_helpers.sh rev $(ConfigurationName)" />
-  </Target>
+
   <Target Name="BeforeClean">
     <Delete Files="@(HunspellAssemblies -> '$(OutputPath)%(Identity)')" />
   </Target>

From 424e21628b4073b7eda14dc6244d176a6dcab9f4 Mon Sep 17 00:00:00 2001
From: Ivandro Jao <Ivandrofly@gmail.com>
Date: Wed, 23 Oct 2024 12:23:11 +0100
Subject: [PATCH 2/4] Remove obsolete pre-clean target from project file

Deleted the BeforeClean target that was removing HunspellAssemblies from the output path. This target is no longer necessary and simplifies the build process.

Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
---
 src/ui/SubtitleEdit.csproj | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/ui/SubtitleEdit.csproj b/src/ui/SubtitleEdit.csproj
index 12db7acac..938f9dc99 100644
--- a/src/ui/SubtitleEdit.csproj
+++ b/src/ui/SubtitleEdit.csproj
@@ -284,8 +284,4 @@
     <Compile Remove="Logic\VideoPlayers\DirectShowLib2005.cs" />
     <EmbeddedResource Remove="Forms\GetDictionaries.resx" />
   </ItemGroup>
-
-  <Target Name="BeforeClean">
-    <Delete Files="@(HunspellAssemblies -> '$(OutputPath)%(Identity)')" />
-  </Target>
 </Project>
\ No newline at end of file

From 33700ae363031dd3a8cabfee03920e37912fdba6 Mon Sep 17 00:00:00 2001
From: Ivandro Jao <Ivandrofly@gmail.com>
Date: Wed, 23 Oct 2024 12:54:12 +0100
Subject: [PATCH 3/4] Add build helpers target to SubtitleEdit project

Moved the build helpers target from LibSE.csproj to SubtitleEdit.csproj. This change ensures that the build helper scripts are invoked during the build process of the SubtitleEdit project, enhancing consistency and maintainability.

Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
---
 src/libse/LibSE.csproj     | 7 +------
 src/ui/SubtitleEdit.csproj | 6 ++++++
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/libse/LibSE.csproj b/src/libse/LibSE.csproj
index 8a11fc29a..d7ba02d96 100644
--- a/src/libse/LibSE.csproj
+++ b/src/libse/LibSE.csproj
@@ -37,12 +37,7 @@
 			<LastGenOutput>Resources.Designer.cs</LastGenOutput>
 		</EmbeddedResource>
 	</ItemGroup>
-
-	<Target Name="InvokeBuildHelpers" BeforeTargets="BeforeCompile;CoreCompile">
-		<Exec Condition="'$(OS)' == 'Windows_NT'" Command="%22$(SolutionDir)build_helpers.bat%22 rev %22$(ConfigurationName)%22" />
-		<Exec Condition="'$(OS)' == 'Unix'" Command="bash $(ProjectDir)../../build_helpers.sh rev $(ConfigurationName)" />
-	</Target>
-
+	
 	<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
 		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 	</PropertyGroup>
diff --git a/src/ui/SubtitleEdit.csproj b/src/ui/SubtitleEdit.csproj
index 938f9dc99..c0bbe106a 100644
--- a/src/ui/SubtitleEdit.csproj
+++ b/src/ui/SubtitleEdit.csproj
@@ -284,4 +284,10 @@
     <Compile Remove="Logic\VideoPlayers\DirectShowLib2005.cs" />
     <EmbeddedResource Remove="Forms\GetDictionaries.resx" />
   </ItemGroup>
+
+  <Target Name="InvokeBuildHelpers" BeforeTargets="BeforeCompile;CoreCompile">
+    <Exec Condition="'$(OS)' == 'Windows_NT'" Command="%22$(SolutionDir)build_helpers.bat%22 rev %22$(ConfigurationName)%22" />
+    <Exec Condition="'$(OS)' == 'Unix'" Command="bash $(ProjectDir)../../build_helpers.sh rev $(ConfigurationName)" />
+  </Target>
+  
 </Project>
\ No newline at end of file

From 04a27f38c70249c7862f543fac0cc14aede5a999 Mon Sep 17 00:00:00 2001
From: Ivandro Jao <Ivandrofly@gmail.com>
Date: Wed, 23 Oct 2024 12:57:23 +0100
Subject: [PATCH 4/4] Remove redundant newline in SubtitleEdit project file

This change removes an unnecessary newline at the end of src/ui/SubtitleEdit.csproj. This helps maintain consistency and cleanliness in the project file formatting.

Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
---
 src/ui/SubtitleEdit.csproj | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/ui/SubtitleEdit.csproj b/src/ui/SubtitleEdit.csproj
index c0bbe106a..5715fea04 100644
--- a/src/ui/SubtitleEdit.csproj
+++ b/src/ui/SubtitleEdit.csproj
@@ -284,10 +284,8 @@
     <Compile Remove="Logic\VideoPlayers\DirectShowLib2005.cs" />
     <EmbeddedResource Remove="Forms\GetDictionaries.resx" />
   </ItemGroup>
-
   <Target Name="InvokeBuildHelpers" BeforeTargets="BeforeCompile;CoreCompile">
     <Exec Condition="'$(OS)' == 'Windows_NT'" Command="%22$(SolutionDir)build_helpers.bat%22 rev %22$(ConfigurationName)%22" />
     <Exec Condition="'$(OS)' == 'Unix'" Command="bash $(ProjectDir)../../build_helpers.sh rev $(ConfigurationName)" />
   </Target>
-  
 </Project>
\ No newline at end of file