Merge pull request #4385 from OmrSi/no-overlap-in-insert-new-subtitle-at-video-pos

No overlap in insert new subtitle at video pos
This commit is contained in:
Nikolaj Olsson 2020-09-22 19:14:06 +02:00 committed by GitHub
commit 1022c76a89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -8505,7 +8505,7 @@ namespace Nikse.SubtitleEdit.Forms
newParagraph.EndTime.TotalMilliseconds = newParagraph.StartTime.TotalMilliseconds + Configuration.Settings.General.NewEmptyDefaultMs;
if (next != null && newParagraph.EndTime.TotalMilliseconds > next.StartTime.TotalMilliseconds)
{
newParagraph.EndTime.TotalMilliseconds = next.StartTime.TotalMilliseconds - 1;
newParagraph.EndTime.TotalMilliseconds = next.StartTime.TotalMilliseconds - Configuration.Settings.General.MinimumMillisecondsBetweenLines;
}
if (newParagraph.StartTime.TotalMilliseconds > newParagraph.EndTime.TotalMilliseconds)
@ -19230,8 +19230,19 @@ namespace Nikse.SubtitleEdit.Forms
index++;
}
// prevent overlap
var endTotalMilliseconds = videoPositionInMilliseconds + Configuration.Settings.General.NewEmptyDefaultMs;
var next = _subtitle.Paragraphs[index];
if (next != null)
{
if (endTotalMilliseconds > next.StartTime.TotalMilliseconds - Configuration.Settings.General.MinimumMillisecondsBetweenLines)
{
endTotalMilliseconds = next.StartTime.TotalMilliseconds - Configuration.Settings.General.MinimumMillisecondsBetweenLines;
}
}
// create and insert
var newParagraph = new Paragraph(string.Empty, videoPositionInMilliseconds, videoPositionInMilliseconds + Configuration.Settings.General.NewEmptyDefaultMs);
var newParagraph = new Paragraph(string.Empty, videoPositionInMilliseconds, endTotalMilliseconds);
SetStyleForNewParagraph(newParagraph, index);
if (_networkSession != null)
{