Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-11-22 03:02:35 +01:00
Code Issues Projects Releases Wiki Activity

Handle subtitles as connected that turn out to be so when chaining

Browse Source
This commit is contained in:
Martijn van Berkel (Flitskikker) 2024-10-18 22:24:59 +02:00
parent 30ba6afdba
commit 13cfef9144
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/libse/Forms/TimeCodesBeautifier.cs
View File

@ -111,7 +111,7 @@ namespace Nikse.SubtitleEdit.Core.Forms
} }
} }
private bool FixConnectedSubtitles(Paragraph leftParagraph = null, Paragraph rightParagraph = null) private bool FixConnectedSubtitles(Paragraph leftParagraph = null, Paragraph rightParagraph = null, bool checkConnected = true)
{ {
if (leftParagraph == null || rightParagraph == null) if (leftParagraph == null || rightParagraph == null)
{ {
@ -140,7 +140,7 @@ namespace Nikse.SubtitleEdit.Core.Forms
var subtitlesAreConnected = distance < Configuration.Settings.BeautifyTimeCodes.Profile.ConnectedSubtitlesTreatConnected; var subtitlesAreConnected = distance < Configuration.Settings.BeautifyTimeCodes.Profile.ConnectedSubtitlesTreatConnected;
if (subtitlesAreConnected) if (subtitlesAreConnected || !checkConnected)
{ {
var newLeftOutCueFrame = MillisecondsToFrames(leftParagraph.EndTime.TotalMilliseconds); var newLeftOutCueFrame = MillisecondsToFrames(leftParagraph.EndTime.TotalMilliseconds);
var newRightInCueFrame = MillisecondsToFrames(rightParagraph.StartTime.TotalMilliseconds); var newRightInCueFrame = MillisecondsToFrames(rightParagraph.StartTime.TotalMilliseconds);
@ -545,7 +545,17 @@ namespace Nikse.SubtitleEdit.Core.Forms
var performGeneralChaining = false; var performGeneralChaining = false;
if (isRightInCueOnShotChange) if (isLeftOutCueOnShotChange && isRightInCueOnShotChange
&& bestLeftOutCueFrameInfo.result == FindBestCueResult.SnappedToRedZone && bestRightInCueFrameInfo.result == FindBestCueResult.SnappedToRedZone
&& bestLeftOutCueFrame == bestRightInCueFrame)
{
// If both cues are being snapped to the exact same shot change, the subtitles really are connected
// So, handle using the designated function, ignoring the "treat connected" value (because otherwise it would have handled it before going into this function)
FixConnectedSubtitles(leftParagraph, rightParagraph, checkConnected: false);
return true;
}
else if (isRightInCueOnShotChange)
{ {
// The right in cue is on a shot change // The right in cue is on a shot change
// Try to chain the subtitles // Try to chain the subtitles