Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-11-22 03:02:35 +01:00
Code Issues Projects Releases Wiki Activity

Refactor video dimension validation in GenerateVideoWithHardSubs

Browse Source 
This commit refactors the validation of video dimensions in GenerateVideoWithHardSubs class. Instead of checking width and height separately, a new Dimension object is created and validated with IsValid(). This simplifies the code and improves readability.

Signed-off-by: Ivandro Jao <ivandrofly@gmail.com>
This commit is contained in:
Ivandro Jao 2024-04-30 12:41:32 +01:00
parent 93c9e9947a
commit 6323937c30
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ui/Forms/GenerateVideoWithHardSubs.cs
View File

@ -2202,14 +2202,15 @@ namespace Nikse.SubtitleEdit.Forms
vInfo = UiUtil.GetVideoInfo(videoFileName); vInfo = UiUtil.GetVideoInfo(videoFileName);
} }
if (vInfo.Width == 0 || vInfo.Height == 0) var dimension = new Dimension(vInfo.Height, vInfo.Width);
// skip audio or damaged files
if (!dimension.IsValid())
{ {
SeLogger.Error("Skipping burn-in file with no video: " + videoFileName); SeLogger.Error("Skipping burn-in file with no video: " + videoFileName);
// return; // skip audio or damaged files
return new Dimension();
} }
return new Dimension(vInfo.Height, vInfo.Width); return dimension;
} }
private void deleteToolStripMenuItem_Click(object sender, EventArgs e) private void deleteToolStripMenuItem_Click(object sender, EventArgs e)