Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-10-27 22:42:38 +01:00
Code Issues Projects Releases Wiki Activity

ITT: Do not add "region" attribute if all is the default bottom

Browse Source
This commit is contained in:
niksedk 2023-05-06 08:09:45 +02:00
parent 2092fc0d4f
commit 6709c2b890
1 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/libse/SubtitleFormats/ItunesTimedText.cs
View File

@ -1,6 +1,7 @@
using Nikse.SubtitleEdit.Core.Common;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Xml;
namespace Nikse.SubtitleEdit.Core.SubtitleFormats
@ -236,29 +237,35 @@ namespace Nikse.SubtitleEdit.Core.SubtitleFormats
}
}
var hasAlignmentTags = subtitle.Paragraphs.Any(p => p.Text.Contains("{\\an", StringComparison.Ordinal));
var headerStyles = GetStylesFromHeader(subtitle.Header);
var isDefaultAlignmentBottom = body.Attributes["region"] == null && body.Attributes["region"].InnerText == "bottom";
foreach (var p in subtitle.Paragraphs)
{
var paragraph = xml.CreateElement("p", "http://www.w3.org/ns/ttml");
var text = p.Text;
var regionP = xml.CreateAttribute("region");
if (text.StartsWith("{\\an7}", StringComparison.Ordinal) || text.StartsWith("{\\an8}", StringComparison.Ordinal) || text.StartsWith("{\\an9}", StringComparison.Ordinal))
if (hasAlignmentTags || isDefaultAlignmentBottom)
{
if (hasTopRegion)
var regionP = xml.CreateAttribute("region");
if (text.StartsWith("{\\an7}", StringComparison.Ordinal) || text.StartsWith("{\\an8}", StringComparison.Ordinal) || text.StartsWith("{\\an9}", StringComparison.Ordinal))
{
regionP.InnerText = "top";
if (hasTopRegion)
{
regionP.InnerText = "top";
paragraph.Attributes.Append(regionP);
}
}
else if (hasBottomRegion)
{
regionP.InnerText = "bottom";
paragraph.Attributes.Append(regionP);
}
}
else if (hasBottomRegion)
{
regionP.InnerText = "bottom";
paragraph.Attributes.Append(regionP);
}
if (text.StartsWith("{\\an", StringComparison.Ordinal) && text.Length > 6 && text[5] == '}')
{
text = text.Remove(0, 6);
if (text.StartsWith("{\\an", StringComparison.Ordinal) && text.Length > 6 && text[5] == '}')
{
text = text.Remove(0, 6);
}
}
if (convertedFromSubStationAlpha)