Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-10-27 14:32:35 +01:00
Code Issues Projects Releases Wiki Activity

Replace magic numbers with named constants

Browse Source 
This commit replaces magic numbers in the retry mechanism with named constants. In "UpdateLanguageFiles", the hardcoded delay of 10ms between retries has been replaced by the variable 'delayBetweenRetries'. Similarly, in "UpdateAssemblyInfo", the number of retries set to 10 has been replaced with 'maxRetries' and 'delayBetweenRetries' is used for the time gap between each attempt. This makes the code more readable and maintainable.
This commit is contained in:
Ivandro Jao 2023-07-23 13:54:55 +01:00
parent e4ff1ac262
commit 9bcf49e286
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/UpdateAssemblyInfo/Program.cs
View File

@ -225,7 +225,9 @@ namespace UpdateAssemblyInfo
private static void SaveWithRetry(string fileName, string content)
{
for (int i = 0; i < 10; i++)
const int maxRetries = 10;
var delayBetweenRetries = TimeSpan.FromMilliseconds(10);
for (var i = 0; i <= maxRetries; i++)
{
try
{
@ -234,10 +236,14 @@ namespace UpdateAssemblyInfo
}
catch
{
System.Threading.Thread.Sleep(10);
if (i == maxRetries)
{
throw;
}
System.Threading.Thread.Sleep(delayBetweenRetries);
}
}
File.WriteAllText(fileName, content, Encoding.UTF8);
}
private static void GetRepositoryVersions(out VersionInfo currentRepositoryVersion, out VersionInfo latestRepositoryVersion)

2
src/UpdateLanguageFiles/Program.cs
View File

@ -109,7 +109,7 @@ namespace UpdateLanguageFiles
throw;
}
System.Threading.Thread.Sleep(10);
System.Threading.Thread.Sleep(delayBetweenRetries);
}
}
}