From a330e673814f1e16ab399776a7c85d7cf1c0488a Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Fri, 5 Sep 2014 03:15:08 +0300 Subject: [PATCH] CA2211: Non-constant fields should not be visible. --- src/Logic/DetectEncoding/EncodingTools.cs | 6 +++--- src/Logic/IfoParser.cs | 4 ++-- src/Logic/SubtitleFormats/Pac.cs | 2 +- src/Logic/SubtitleFormats/UnknownSubtitle59.cs | 4 ++-- src/Logic/TimeCode.cs | 2 +- src/Logic/Utilities.cs | 10 +++++----- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/Logic/DetectEncoding/EncodingTools.cs b/src/Logic/DetectEncoding/EncodingTools.cs index c0b77da35..ef52ef9ef 100644 --- a/src/Logic/DetectEncoding/EncodingTools.cs +++ b/src/Logic/DetectEncoding/EncodingTools.cs @@ -11,13 +11,13 @@ namespace Nikse.SubtitleEdit.Logic.DetectEncoding public static class EncodingTools { // this only contains ascii, default windows code page and unicode - public static int[] PreferredEncodingsForStream; + static int[] PreferredEncodingsForStream; // this contains all codepages, sorted by preference and byte usage - public static int[] PreferredEncodings; + static int[] PreferredEncodings; // this contains all codepages, sorted by preference and byte usage - public static int[] AllEncodings; + static int[] AllEncodings; /// diff --git a/src/Logic/IfoParser.cs b/src/Logic/IfoParser.cs index ac1cce9e3..6dd989f73 100644 --- a/src/Logic/IfoParser.cs +++ b/src/Logic/IfoParser.cs @@ -84,13 +84,13 @@ namespace Nikse.SubtitleEdit.Logic readonly List ArrayOfCodingMode = new List { "MPEG1", "MPEG2" }; readonly List ArrayOfNTSCResolution = new List { "720x480", "704x480", "352x480", "352x240" }; readonly List ArrayOfPALResolution = new List { "720x576", "704x576", "352x576", "352x288" }; - public static List ArrayOfLanguageCode = new List { " ", "aa", "ab", "af", "am", "ar", "as", "ay", "az", "ba", "be", "bg", "bh", "bi", "bn", "bo", "br", "ca", "co", "cs", "cy", "da", "de", "dz", "el", + public static readonly List ArrayOfLanguageCode = new List { " ", "aa", "ab", "af", "am", "ar", "as", "ay", "az", "ba", "be", "bg", "bh", "bi", "bn", "bo", "br", "ca", "co", "cs", "cy", "da", "de", "dz", "el", "en", "eo", "es", "et", "eu", "fa", "fi", "fj", "fo", "fr", "fy", "ga", "gd", "gl", "gn", "gu", "ha", "he", "hi", "hr", "hu", "hy", "ia", "id", "ie", "ik", "in", "is", "it", "iu", "iw", "ja", "ji", "jw", "ka", "kk", "kl", "km", "kn", "ko", "ks", "ku", "ky", "la", "ln", "lo", "lt", "lv", "mg", "mi", "mk", "ml", "mn", "mo", "mr", "ms", "mt", "my", "na", "ne", "nl", "no", "oc", "om", "or", "pa", "pl", "ps", "pt", "qu", "rm", "rn", "ro", "ru", "rw", "sa", "sd", "sg", "sh", "si", "sk", "sl", "sm", "sn", "so", "sq", "sr", "ss", "st", "su", "sv", "sw", "ta", "te", "tg", "th", "ti", "tk", "tl", "tn", "to", "tr", "ts", "tt", "tw", "ug", "uk", "ur", "uz", "vi", "vo", "wo", "xh", "yi", "yo", "za", "zh", "zu", ""}; - public static List ArrayOfLanguage = new List { "Not Specified", "Afar", "Abkhazian", "Afrikaans", "Amharic", "Arabic", "Assamese", "Aymara", "Azerbaijani", "Bashkir", "Byelorussian", "Bulgarian", "Bihari", "Bislama", "Bengali; Bangla", "Tibetan", "Breton", "Catalan", "Corsican", "Czech(Ceske)", "Welsh", "Dansk", "Deutsch", "Bhutani", "Greek", + public static readonly List ArrayOfLanguage = new List { "Not Specified", "Afar", "Abkhazian", "Afrikaans", "Amharic", "Arabic", "Assamese", "Aymara", "Azerbaijani", "Bashkir", "Byelorussian", "Bulgarian", "Bihari", "Bislama", "Bengali; Bangla", "Tibetan", "Breton", "Catalan", "Corsican", "Czech(Ceske)", "Welsh", "Dansk", "Deutsch", "Bhutani", "Greek", "English", "Esperanto", "Espanol", "Estonian", "Basque", "Persian", "Suomi", "Fiji", "Faroese", "Français", "Frisian", "Irish", "Scots Gaelic", "Galician", "Guarani", "Gujarati", "Hausa", "Hebrew", "Hindi", "Hrvatski", "Magyar", "Armenian", "Interlingua", "Indonesian", "Interlingue", "Inupiak", "Indonesian", "Islenska", "Italiano", "Inuktitut", "Hebrew", "Japanese", "Yiddish", "Javanese", "Georgian", "Kazakh", "Greenlandic", "Cambodian", "Kannada", "Korean", "Kashmiri", "Kurdish", "Kirghiz", "Latin", "Lingala", "Laothian", "Lithuanian", "Latvian, Lettish", "Malagasy", "Maori", "Macedonian", "Malayalam", "Mongolian", "Moldavian", "Marathi", "Malay", "Maltese", "Burmese", "Nauru", "Nepali", "Nederlands", "Norsk", "Occitan", "(Afan) Oromo", "Oriya", "Punjabi", "Polish", "Pashto, Pushto", "Portugues", "Quechua", "Rhaeto-Romance", "Kirundi", "Romanian", "Russian", "Kinyarwanda", "Sanskrit", "Sindhi", "Sangho", diff --git a/src/Logic/SubtitleFormats/Pac.cs b/src/Logic/SubtitleFormats/Pac.cs index bdc6a7fac..ec70e28bf 100644 --- a/src/Logic/SubtitleFormats/Pac.cs +++ b/src/Logic/SubtitleFormats/Pac.cs @@ -13,7 +13,7 @@ namespace Nikse.SubtitleEdit.Logic.SubtitleFormats public class Pac : SubtitleFormat { - public static TimeCode PacNullTime = new TimeCode(655, 35, 00, 0); + public static readonly TimeCode PacNullTime = new TimeCode(655, 35, 00, 0); /// /// Contains Swedish, Danish, German, Spanish, and French letters diff --git a/src/Logic/SubtitleFormats/UnknownSubtitle59.cs b/src/Logic/SubtitleFormats/UnknownSubtitle59.cs index a0d69a1a4..01ef31fe2 100644 --- a/src/Logic/SubtitleFormats/UnknownSubtitle59.cs +++ b/src/Logic/SubtitleFormats/UnknownSubtitle59.cs @@ -8,8 +8,8 @@ namespace Nikse.SubtitleEdit.Logic.SubtitleFormats public class UnknownSubtitle59 : SubtitleFormat { - public static Regex RegexTimeCodes = new Regex(@"^\d\d\:\d\d\:\d\d\t.+\t\d\d\:\d\d\:\d\d$", RegexOptions.Compiled); - public static Regex RegexTimeCodes2 = new Regex(@"^\d\d\:\d\d\:\d\d.+\d\d\:\d\d\:\d\d$", RegexOptions.Compiled); + public static readonly Regex RegexTimeCodes = new Regex(@"^\d\d\:\d\d\:\d\d\t.+\t\d\d\:\d\d\:\d\d$", RegexOptions.Compiled); + public static readonly Regex RegexTimeCodes2 = new Regex(@"^\d\d\:\d\d\:\d\d.+\d\d\:\d\d\:\d\d$", RegexOptions.Compiled); static Regex regexStartOnly = new Regex(@"^\d\d\:\d\d\:\d\d\t.+$", RegexOptions.Compiled); static Regex regexEndOnly = new Regex(@"\d\d\:\d\d\:\d\d$", RegexOptions.Compiled); public override string Extension diff --git a/src/Logic/TimeCode.cs b/src/Logic/TimeCode.cs index e8be1f348..ca28d0d71 100644 --- a/src/Logic/TimeCode.cs +++ b/src/Logic/TimeCode.cs @@ -5,7 +5,7 @@ namespace Nikse.SubtitleEdit.Logic { public class TimeCode { - public static TimeCode MaxTime = new TimeCode(99, 59, 59, 999); + public static readonly TimeCode MaxTime = new TimeCode(99, 59, 59, 999); double _totalMilliseconds; diff --git a/src/Logic/Utilities.cs b/src/Logic/Utilities.cs index 803ae5eec..a06e6f127 100644 --- a/src/Logic/Utilities.cs +++ b/src/Logic/Utilities.cs @@ -2361,11 +2361,11 @@ namespace Nikse.SubtitleEdit.Logic return userWordListXmlFileName; } - public static string UppercaseLetters = GetLetters(true, false, false); - public static string LowercaseLetters = GetLetters(false, true, false); - public static string LowercaseLettersWithNumbers = GetLetters(false, true, true); - public static string AllLetters = GetLetters(true, true, false); - public static string AllLettersAndNumbers = GetLetters(true, true, true); + public static readonly string UppercaseLetters = GetLetters(true, false, false); + public static readonly string LowercaseLetters = GetLetters(false, true, false); + public static readonly string LowercaseLettersWithNumbers = GetLetters(false, true, true); + public static readonly string AllLetters = GetLetters(true, true, false); + public static readonly string AllLettersAndNumbers = GetLetters(true, true, true); private static string GetLetters(bool uppercase, bool lowercase, bool numbers) {