Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-10-26 15:02:35 +02:00
Code Issues Projects Releases Wiki Activity

Refactor FixCasingAfterTitles to use class fields.

Browse Source 
Extracted the arrays `_titles` and `_notChangeWords` as readonly class fields to reduce redundancy and improve readability. Adjusted the associated logic to reference these fields instead of creating new arrays within the method.

Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
This commit is contained in:
Ivandro Jao 2024-07-25 23:24:30 +01:00
parent 7b0c79c5ee
commit a5a039effd
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/libse/Common/FixCasing.cs
View File

@ -159,24 +159,25 @@ namespace Nikse.SubtitleEdit.Core.Common
return text;
}
private readonly string[] _titles = { "Mrs.", "Miss.", "Mr.", "Ms.", "Dr." };
private readonly string[] _notChangeWords = { "does", "has", "will", "is", "and", "for", "but", "or", "of" };
private string FixCasingAfterTitles(string input)
{
var text = input;
var titles = new[] { "Mrs.", "Miss.", "Mr.", "Ms.", "Dr." };
var notChangeWords = new[] { "does", "has", "will", "is", "and", "for", "but", "or", "of" };
for (int i = 0; i < text.Length - 4; i++)
{
var start = text.Substring(i);
foreach (var title in titles)
var textFromIndex = text.Substring(i);
foreach (var title in _titles)
{
if (start.StartsWith(title, StringComparison.OrdinalIgnoreCase))
if (textFromIndex.StartsWith(title, StringComparison.OrdinalIgnoreCase))
{
var idx = i + title.Length;
if (idx < text.Length - 2 && text[idx] == ' ')
{
idx++;
var words = text.Substring(idx).Split(' ', '\r', '\n', ',', '"', '?', '!', '.', '\'');
if (words.Length > 0 && !notChangeWords.Contains(words[0]))
if (words.Length > 0 && !_notChangeWords.Contains(words[0]))
{
var upper = text[idx].ToString().ToUpperInvariant();
text = text.Remove(idx, 1).Insert(idx, upper);