Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-10-27 22:42:38 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2240 from ivandrofly/listview-01

Browse Source 
[SubtitleListView] - No need to call string.replace.
This commit is contained in:
Nikolaj Olsson 2017-02-24 09:40:10 +01:00 committed by GitHub
commit b395fc9ec3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Controls/SubtitleListView.cs
View File

@ -964,7 +964,6 @@ namespace Nikse.SubtitleEdit.Controls
if (_settings.Tools.ListViewSyntaxColorLongLines)
{
int noOfLines = paragraph.NumberOfLines;
string s = HtmlUtil.RemoveHtmlTags(paragraph.Text, true);
foreach (string line in s.SplitToLines())
{
@ -974,8 +973,10 @@ namespace Nikse.SubtitleEdit.Controls
return;
}
}
s = s.Replace(Environment.NewLine, string.Empty); // we don't count new line in total length
if (s.Length <= Configuration.Settings.General.SubtitleLineMaximumLength * noOfLines)
int noOfLines = paragraph.NumberOfLines;
// Length excluding new line characters. (\r\n)
int len = noOfLines > 1 ? s.Length - Environment.NewLine.Length * (noOfLines - 1) : s.Length;
if (len <= Configuration.Settings.General.SubtitleLineMaximumLength * noOfLines)
{
if (noOfLines > Configuration.Settings.Tools.ListViewSyntaxMoreThanXLinesX && _settings.Tools.ListViewSyntaxMoreThanXLines)
item.SubItems[ColumnIndexText].BackColor = Configuration.Settings.Tools.ListViewSyntaxErrorColor;