Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-11-21 18:52:36 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #8251 from ivandrofly/feature/listview-operators

Browse Source 
Refactor list view item checking actions
This commit is contained in:
Nikolaj Olsson 2024-04-27 19:09:30 +02:00 committed by GitHub
commit bb9b53a995
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
19 changed files with 70 additions and 181 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/ui/Forms/ApplyDurationLimits.cs
View File

@ -338,21 +338,9 @@ namespace Nikse.SubtitleEdit.Forms
}
}
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
}
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e) => listViewFixes.CheckAll();
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e) => listViewFixes.InvertCheck();
private void checkBoxCheckShotChanges_CheckedChanged(object sender, EventArgs e)
{

16
src/ui/Forms/Assa/SubStationAlphaStylesCategoriesImportExport.cs
View File

@ -125,20 +125,8 @@ namespace Nikse.SubtitleEdit.Forms.Assa
}
}
private void ToolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewCategories.Items)
{
item.Checked = true;
}
}
private void ToolStripMenuItemSelectAll_Click(object sender, EventArgs e) => listViewCategories.CheckAll();
private void ToolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewCategories.Items)
{
item.Checked = !item.Checked;
}
}
private void ToolStripMenuItemInverseSelection_Click(object sender, EventArgs e) => listViewCategories.InvertCheck();
}
}

10
src/ui/Forms/AutoBreakUnbreakLines.cs
View File

@ -251,18 +251,12 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
}
private void AutoBreakUnbreakLines_FormClosing(object sender, FormClosingEventArgs e)

10
src/ui/Forms/BatchConvert.cs
View File

@ -3977,18 +3977,12 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewConvertOptions.Items)
{
item.Checked = true;
}
listViewConvertOptions.CheckAll();
}
private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewConvertOptions.Items)
{
item.Checked = !item.Checked;
}
listViewConvertOptions.InvertCheck();
}
private void listViewInputFiles_ColumnClick(object sender, ColumnClickEventArgs e)

10
src/ui/Forms/ChangeCasingNames.cs
View File

@ -335,18 +335,12 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
}
private void toolStripMenuItem1SelectAll_Click(object sender, EventArgs e)

36
src/ui/Forms/FixCommonErrors.cs
View File

@ -1145,21 +1145,9 @@ namespace Nikse.SubtitleEdit.Forms
listViewFixes.Sort();
}
private void ButtonSelectAllClick(object sender, EventArgs e)
{
foreach (ListViewItem item in listView1.Items)
{
item.Checked = true;
}
}
private void ButtonSelectAllClick(object sender, EventArgs e) => listView1.CheckAll();
private void ButtonInverseSelectionClick(object sender, EventArgs e)
{
foreach (ListViewItem item in listView1.Items)
{
item.Checked = !item.Checked;
}
}
private void ButtonInverseSelectionClick(object sender, EventArgs e) => listView1.InvertCheck();
private void ListViewFixesSelectedIndexChanged(object sender, EventArgs e)
{
@ -1370,18 +1358,12 @@ namespace Nikse.SubtitleEdit.Forms
private void ButtonFixesSelectAllClick(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
}
private void ButtonFixesInverseClick(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
}
private void ButtonFixesApplyClick(object sender, EventArgs e)
@ -1948,18 +1930,12 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
}
private void setCurrentFixesAsDefaultToolStripMenuItem_Click(object sender, EventArgs e)

10
src/ui/Forms/MergeShortLines.cs
View File

@ -346,18 +346,12 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
}
}
}

10
src/ui/Forms/MergeTextWithSameTimeCodes.cs
View File

@ -297,18 +297,12 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
}
private void checkBoxMakeDialog_CheckedChanged(object sender, EventArgs e)

10
src/ui/Forms/ModifySelection.cs
View File

@ -691,18 +691,12 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
}
private void ModifySelection_Resize(object sender, EventArgs e)

20
src/ui/Forms/MultipleReplace.cs
View File

@ -570,18 +570,12 @@ namespace Nikse.SubtitleEdit.Forms
private void buttonReplacesSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
}
private void buttonReplacesInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
}
private void contextMenuStrip1_Opening(object sender, System.ComponentModel.CancelEventArgs e)
@ -1446,18 +1440,12 @@ namespace Nikse.SubtitleEdit.Forms
private void selectAllToolStripMenuItem_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewRules.Items)
{
item.Checked = true;
}
listViewRules.CheckAll();
}
private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewRules.Items)
{
item.Checked = !item.Checked;
}
listViewRules.InvertCheck();
}
private void ContextMenuStripListViewFixesOpening(object sender, System.ComponentModel.CancelEventArgs e)

10
src/ui/Forms/MultipleReplaceExportImport.cs
View File

@ -136,18 +136,12 @@ namespace Nikse.SubtitleEdit.Forms
private void selectAllToolStripMenuItem_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = true;
}
listViewExportStyles.CheckAll();
}
private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = !item.Checked;
}
listViewExportStyles.InvertCheck();
}
}
}

7
src/ui/Forms/Ocr/BinaryOcrTrain.cs
View File

@ -328,12 +328,7 @@ namespace Nikse.SubtitleEdit.Forms.Ocr
private void SelectAll_Click(object sender, EventArgs e)
{
listViewFonts.BeginUpdate();
foreach (ListViewItem fontItem in listViewFonts.Items)
{
fontItem.Checked = true;
}
listViewFonts.EndUpdate();
listViewFonts.CheckAll();
}
public void InitializeDetectFont(BinaryOcrBitmap bob, string text)

6
src/ui/Forms/Ocr/VobSubCharactersImport.cs
View File

@ -143,11 +143,7 @@ namespace Nikse.SubtitleEdit.Forms.Ocr
private void buttonFixesSelectAll_Click(object sender, EventArgs e)
{
listView1.ItemChecked -= listView1_ItemChecked;
foreach (ListViewItem item in listView1.Items)
{
item.Checked = true;
}
listView1.CheckAll();
foreach (ListViewData d in _data)
{

10
src/ui/Forms/Options/SettingsProfileExport.cs
View File

@ -76,18 +76,12 @@ namespace Nikse.SubtitleEdit.Forms.Options
private void selectAllToolStripMenuItem_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = true;
}
listViewExportStyles.CheckAll();
}
private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = !item.Checked;
}
listViewExportStyles.InvertCheck();
}
}
}

10
src/ui/Forms/SplitLongLines.cs
View File

@ -718,10 +718,7 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
listViewFixes.ItemChecked -= listViewFixes_ItemChecked;
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = true;
}
listViewFixes.CheckAll();
listViewFixes.ItemChecked += listViewFixes_ItemChecked;
GeneratePreview(false);
}
@ -729,10 +726,7 @@ namespace Nikse.SubtitleEdit.Forms
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
listViewFixes.ItemChecked -= listViewFixes_ItemChecked;
foreach (ListViewItem item in listViewFixes.Items)
{
item.Checked = !item.Checked;
}
listViewFixes.InvertCheck();
listViewFixes.ItemChecked += listViewFixes_ItemChecked;
GeneratePreview(false);
}

10
src/ui/Forms/Styles/SubStationAlphaStylesExport.cs
View File

@ -186,18 +186,12 @@ namespace Nikse.SubtitleEdit.Forms.Styles
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = true;
}
listViewExportStyles.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = !item.Checked;
}
listViewExportStyles.InvertCheck();
}
}
}

10
src/ui/Forms/VTT/WebVttImportExport.cs
View File

@ -145,18 +145,12 @@ namespace Nikse.SubtitleEdit.Forms.VTT
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = true;
}
listViewExportStyles.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = !item.Checked;
}
listViewExportStyles.InvertCheck();
}
}
}

10
src/ui/Forms/VTT/WebVttStylePicker.cs
View File

@ -57,18 +57,12 @@ namespace Nikse.SubtitleEdit.Forms.VTT
private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = true;
}
listViewExportStyles.CheckAll();
}
private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
{
foreach (ListViewItem item in listViewExportStyles.Items)
{
item.Checked = !item.Checked;
}
listViewExportStyles.InvertCheck();
}
private void listViewExportStyles_SelectedIndexChanged(object sender, EventArgs e)

30
src/ui/Logic/UiUtil.cs
View File

@ -1121,6 +1121,36 @@ namespace Nikse.SubtitleEdit.Logic
public static void AutoSizeLastColumn(this ListView listView) =>
listView.Columns[listView.Columns.Count - 1].Width = -2;
public static void CheckAll(this ListView lv)
{
lv.BeginUpdate();
foreach (ListViewItem item in lv.Items)
{
item.Checked = true;
}
lv.EndUpdate();
}
public static void InvertCheck(this ListView lv)
{
lv.BeginUpdate();
foreach (ListViewItem item in lv.Items)
{
item.Checked = !item.Checked;
}
lv.EndUpdate();
}
public static void UncheckAll(this ListView lv)
{
lv.BeginUpdate();
foreach (ListViewItem item in lv.Items)
{
item.Checked = false;
}
lv.EndUpdate();
}
public static void SelectAll(this ListView lv)
{
lv.BeginUpdate();