Merge pull request #8251 from ivandrofly/feature/listview-operators

Refactor list view item checking actions

src/ui/Forms/ApplyDurationLimits.cs

@@ -338,21 +338,9 @@ namespace Nikse.SubtitleEdit.Forms
             }
         }
 
-        private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
+        private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e) => listViewFixes.CheckAll();
-        {
-            foreach (ListViewItem item in listViewFixes.Items)
-            {
-                item.Checked = true;
-            }
-        }
 
-        private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
+        private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e) => listViewFixes.InvertCheck();
-        {
-            foreach (ListViewItem item in listViewFixes.Items)
-            {
-                item.Checked = !item.Checked;
-            }
-        }
 
         private void checkBoxCheckShotChanges_CheckedChanged(object sender, EventArgs e)
         {

src/ui/Forms/Assa/SubStationAlphaStylesCategoriesImportExport.cs

@@ -125,20 +125,8 @@ namespace Nikse.SubtitleEdit.Forms.Assa
             }
         }
 
-        private void ToolStripMenuItemSelectAll_Click(object sender, EventArgs e)
+        private void ToolStripMenuItemSelectAll_Click(object sender, EventArgs e) => listViewCategories.CheckAll();
-        {
-            foreach (ListViewItem item in listViewCategories.Items)
-            {
-                item.Checked = true;
-            }
-        }
 
-        private void ToolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
+        private void ToolStripMenuItemInverseSelection_Click(object sender, EventArgs e) => listViewCategories.InvertCheck();
-        {
-            foreach (ListViewItem item in listViewCategories.Items)
-            {
-                item.Checked = !item.Checked;
-            }
-        }
     }
 }

src/ui/Forms/AutoBreakUnbreakLines.cs

@@ -251,18 +251,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void AutoBreakUnbreakLines_FormClosing(object sender, FormClosingEventArgs e)

src/ui/Forms/BatchConvert.cs

@@ -3977,18 +3977,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewConvertOptions.Items)
+            listViewConvertOptions.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewConvertOptions.Items)
+            listViewConvertOptions.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void listViewInputFiles_ColumnClick(object sender, ColumnClickEventArgs e)

src/ui/Forms/ChangeCasingNames.cs

@@ -335,18 +335,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void toolStripMenuItem1SelectAll_Click(object sender, EventArgs e)

src/ui/Forms/FixCommonErrors.cs

@@ -1145,21 +1145,9 @@ namespace Nikse.SubtitleEdit.Forms
             listViewFixes.Sort();
         }
 
-        private void ButtonSelectAllClick(object sender, EventArgs e)
+        private void ButtonSelectAllClick(object sender, EventArgs e) => listView1.CheckAll();
-        {
-            foreach (ListViewItem item in listView1.Items)
-            {
-                item.Checked = true;
-            }
-        }
 
-        private void ButtonInverseSelectionClick(object sender, EventArgs e)
+        private void ButtonInverseSelectionClick(object sender, EventArgs e) => listView1.InvertCheck();
-        {
-            foreach (ListViewItem item in listView1.Items)
-            {
-                item.Checked = !item.Checked;
-            }
-        }
 
         private void ListViewFixesSelectedIndexChanged(object sender, EventArgs e)
         {
@@ -1370,18 +1358,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void ButtonFixesSelectAllClick(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void ButtonFixesInverseClick(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void ButtonFixesApplyClick(object sender, EventArgs e)
@@ -1948,18 +1930,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void setCurrentFixesAsDefaultToolStripMenuItem_Click(object sender, EventArgs e)

src/ui/Forms/MergeShortLines.cs

@@ -346,18 +346,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
     }
 }

src/ui/Forms/MergeTextWithSameTimeCodes.cs

@@ -297,18 +297,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void checkBoxMakeDialog_CheckedChanged(object sender, EventArgs e)

src/ui/Forms/ModifySelection.cs

@@ -691,18 +691,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void ModifySelection_Resize(object sender, EventArgs e)

src/ui/Forms/MultipleReplace.cs

@@ -570,18 +570,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void buttonReplacesSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void buttonReplacesInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void contextMenuStrip1_Opening(object sender, System.ComponentModel.CancelEventArgs e)
@@ -1446,18 +1440,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void selectAllToolStripMenuItem_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewRules.Items)
+            listViewRules.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewRules.Items)
+            listViewRules.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void ContextMenuStripListViewFixesOpening(object sender, System.ComponentModel.CancelEventArgs e)

src/ui/Forms/MultipleReplaceExportImport.cs

@@ -136,18 +136,12 @@ namespace Nikse.SubtitleEdit.Forms
 
         private void selectAllToolStripMenuItem_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
     }
 }

src/ui/Forms/Ocr/BinaryOcrTrain.cs

@@ -328,12 +328,7 @@ namespace Nikse.SubtitleEdit.Forms.Ocr
 
         private void SelectAll_Click(object sender, EventArgs e)
         {
-            listViewFonts.BeginUpdate();
+            listViewFonts.CheckAll();
-            foreach (ListViewItem fontItem in listViewFonts.Items)
-            {
-                fontItem.Checked = true;
-            }
-            listViewFonts.EndUpdate();
         }
 
         public void InitializeDetectFont(BinaryOcrBitmap bob, string text)

src/ui/Forms/Ocr/VobSubCharactersImport.cs

@@ -143,11 +143,7 @@ namespace Nikse.SubtitleEdit.Forms.Ocr
         private void buttonFixesSelectAll_Click(object sender, EventArgs e)
         {
             listView1.ItemChecked -= listView1_ItemChecked;
-
+            listView1.CheckAll();
-            foreach (ListViewItem item in listView1.Items)
-            {
-                item.Checked = true;
-            }
 
             foreach (ListViewData d in _data)
             {

src/ui/Forms/Options/SettingsProfileExport.cs

@@ -76,18 +76,12 @@ namespace Nikse.SubtitleEdit.Forms.Options
 
         private void selectAllToolStripMenuItem_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
     }
 }

src/ui/Forms/SplitLongLines.cs

@@ -718,10 +718,7 @@ namespace Nikse.SubtitleEdit.Forms
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
             listViewFixes.ItemChecked -= listViewFixes_ItemChecked;
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.CheckAll();
-            {
-                item.Checked = true;
-            }
             listViewFixes.ItemChecked += listViewFixes_ItemChecked;
             GeneratePreview(false);
         }
@@ -729,10 +726,7 @@ namespace Nikse.SubtitleEdit.Forms
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
             listViewFixes.ItemChecked -= listViewFixes_ItemChecked;
-            foreach (ListViewItem item in listViewFixes.Items)
+            listViewFixes.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
             listViewFixes.ItemChecked += listViewFixes_ItemChecked;
             GeneratePreview(false);
         }

src/ui/Forms/Styles/SubStationAlphaStylesExport.cs

@@ -186,18 +186,12 @@ namespace Nikse.SubtitleEdit.Forms.Styles
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
     }
 }

src/ui/Forms/VTT/WebVttImportExport.cs

@@ -145,18 +145,12 @@ namespace Nikse.SubtitleEdit.Forms.VTT
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
     }
 }

src/ui/Forms/VTT/WebVttStylePicker.cs

@@ -57,18 +57,12 @@ namespace Nikse.SubtitleEdit.Forms.VTT
 
         private void toolStripMenuItemSelectAll_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.CheckAll();
-            {
-                item.Checked = true;
-            }
         }
 
         private void toolStripMenuItemInverseSelection_Click(object sender, EventArgs e)
         {
-            foreach (ListViewItem item in listViewExportStyles.Items)
+            listViewExportStyles.InvertCheck();
-            {
-                item.Checked = !item.Checked;
-            }
         }
 
         private void listViewExportStyles_SelectedIndexChanged(object sender, EventArgs e)

src/ui/Logic/UiUtil.cs

@@ -1121,6 +1121,36 @@ namespace Nikse.SubtitleEdit.Logic
         public static void AutoSizeLastColumn(this ListView listView) =>
             listView.Columns[listView.Columns.Count - 1].Width = -2;
 
+        public static void CheckAll(this ListView lv)
+        {
+            lv.BeginUpdate();
+            foreach (ListViewItem item in lv.Items)
+            {
+                item.Checked = true;
+            }
+            lv.EndUpdate();
+        }
+        
+        public static void InvertCheck(this ListView lv)
+        {
+            lv.BeginUpdate();
+            foreach (ListViewItem item in lv.Items)
+            {
+                item.Checked = !item.Checked;
+            }
+            lv.EndUpdate();
+        }
+        
+        public static void UncheckAll(this ListView lv)
+        {
+            lv.BeginUpdate();
+            foreach (ListViewItem item in lv.Items)
+            {
+                item.Checked = false;
+            }
+            lv.EndUpdate();
+        }
+        
         public static void SelectAll(this ListView lv)
         {
             lv.BeginUpdate();