From 31bb4b3324bc6824a975f9197715e71f21361bcf Mon Sep 17 00:00:00 2001 From: ivandroly Date: Mon, 20 Jul 2015 19:58:38 +0000 Subject: [PATCH] Prefer item.SubItems.Add() --- src/Forms/FixCommonErrors.cs | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/src/Forms/FixCommonErrors.cs b/src/Forms/FixCommonErrors.cs index 06f67bc5f..82dd9d911 100644 --- a/src/Forms/FixCommonErrors.cs +++ b/src/Forms/FixCommonErrors.cs @@ -483,12 +483,8 @@ namespace Nikse.SubtitleEdit.Forms private void AddFixActionItemToListView(FixItem fi) { var item = new ListViewItem(string.Empty) { Tag = fi, Checked = fi.DefaultChecked }; - - var subItem = new ListViewItem.ListViewSubItem(item, fi.Name); - item.SubItems.Add(subItem); - subItem = new ListViewItem.ListViewSubItem(item, fi.Example); - item.SubItems.Add(subItem); - + item.SubItems.Add(fi.Name); + item.SubItems.Add(fi.Example); listView1.Items.Add(item); } @@ -496,19 +492,11 @@ namespace Nikse.SubtitleEdit.Forms { if (_onlyListFixes) { - var item = new ListViewItem(string.Empty) { Checked = true }; - - var subItem = new ListViewItem.ListViewSubItem(item, p.Number.ToString(CultureInfo.InvariantCulture)); - item.SubItems.Add(subItem); - subItem = new ListViewItem.ListViewSubItem(item, action); - item.SubItems.Add(subItem); - subItem = new ListViewItem.ListViewSubItem(item, before.Replace(Environment.NewLine, Configuration.Settings.General.ListViewLineSeparatorString)); - item.SubItems.Add(subItem); - subItem = new ListViewItem.ListViewSubItem(item, after.Replace(Environment.NewLine, Configuration.Settings.General.ListViewLineSeparatorString)); - item.SubItems.Add(subItem); - - item.Tag = p; // save paragraph in Tag - + var item = new ListViewItem(string.Empty) { Checked = true, Tag = p }; + item.SubItems.Add(p.Number.ToString(CultureInfo.InvariantCulture)); + item.SubItems.Add(action); + item.SubItems.Add(before.Replace(Environment.NewLine, Configuration.Settings.General.ListViewLineSeparatorString)); + item.SubItems.Add(after.Replace(Environment.NewLine, Configuration.Settings.General.ListViewLineSeparatorString)); listViewFixes.Items.Add(item); } }