Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-11-23 11:42:36 +01:00
Code Issues Projects Releases Wiki Activity

Make ShowStatus method private

Browse Source 
Updated `ShowStatus` method to be private to encapsulate its use within the class. Corrected comments for grammatical consistency and changed deSelectedFixes to a HashSet for better performance. Simplified the conditional check with `HasSentenceEnding` to improve readability.

Signed-off-by: Ivandro Jao <Ivandrofly@gmail.com>
This commit is contained in:
Ivandro Jao 2024-11-02 20:23:57 +00:00
parent 6dd564b588
commit cff84f15a6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ui/Forms/FixCommonErrors.cs
View File

@ -663,7 +663,7 @@ namespace Nikse.SubtitleEdit.Forms
return _allowedFixes.Contains(p.Number.ToString(CultureInfo.InvariantCulture) + "|" + action);
}
public void ShowStatus(string message)
private void ShowStatus(string message)
{
message = message.Replace(Environment.NewLine, " ");
if (message.Length > 103)
@ -712,10 +712,10 @@ namespace Nikse.SubtitleEdit.Forms
if (_nameList == null)
{
string languageTwoLetterCode = LanguageAutoDetect.AutoDetectGoogleLanguage(Subtitle);
// Will contains both one word names and multi names
// Will contains both one-word names and multi names
var namesList = new NameList(Configuration.DictionariesDirectory, languageTwoLetterCode, Configuration.Settings.WordLists.UseOnlineNames, Configuration.Settings.WordLists.NamesUrl);
_nameList = namesList.GetNames();
// Multi word names.
// Multi-word names.
foreach (var name in namesList.GetMultiNames())
{
_nameList.Add(name);
@ -1474,7 +1474,7 @@ namespace Nikse.SubtitleEdit.Forms
listViewFixes.BeginUpdate();
// save de-selected fixes
var deSelectedFixes = new List<string>();
var deSelectedFixes = new HashSet<string>();
foreach (ListViewItem item in listViewFixes.Items)
{
if (!item.Checked)
@ -1751,7 +1751,7 @@ namespace Nikse.SubtitleEdit.Forms
string oldText = currentParagraph.Text;
var lines = currentParagraph.Text.SplitToLines();
if (lines.Count == 2 && (lines[0].EndsWith('.') || lines[0].EndsWith('!') || lines[0].EndsWith('?')))
if (lines.Count == 2 && lines[0].HasSentenceEnding())
{
currentParagraph.Text = Utilities.AutoBreakLine(lines[0], Language);
newParagraph.Text = Utilities.AutoBreakLine(lines[1], Language);