Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-11-21 18:52:36 +01:00
Code Issues Projects Releases Wiki Activity

Refactor text change notifications in NikseComboBox

Browse Source 
The previous implementation of the text change notifications and value change events in NikseComboBox was repetitive and cluttered. This commit streamlines that by introducing a new method, NotifyTextChanged(), that handles these events. The new approach contributes to code maintainability and readability.

Signed-off-by: Ivandro Jao <ivandrofly@gmail.com>
This commit is contained in:
Ivandro Jao 2024-04-02 13:00:57 +01:00
parent 31ed11f60a
commit e1f439534d
1 changed files with 4 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/ui/Controls/NikseComboBox.cs
View File

@ -107,12 +107,7 @@ namespace Nikse.SubtitleEdit.Controls
_selectedIndex = value;
_textBox.Text = string.Empty;
if (!_loading)
{
SelectedIndexChanged?.Invoke(this, EventArgs.Empty);
SelectedValueChanged?.Invoke(this, EventArgs.Empty);
TextChanged?.Invoke(this, EventArgs.Empty);
}
NotifyTextChanged();
if (!_skipPaint)
{
@ -138,9 +133,7 @@ namespace Nikse.SubtitleEdit.Controls
_listView.Items[_selectedIndex].Focused = true;
}
SelectedIndexChanged?.Invoke(this, EventArgs.Empty);
SelectedValueChanged?.Invoke(this, EventArgs.Empty);
TextChanged?.Invoke(this, EventArgs.Empty);
NotifyTextChanged();
}
if (!_skipPaint)
@ -1025,13 +1018,7 @@ namespace Nikse.SubtitleEdit.Controls
Invalidate();
}
if (!_loading)
{
SelectedIndexChanged?.Invoke(this, EventArgs.Empty);
SelectedValueChanged?.Invoke(this, EventArgs.Empty);
TextChanged?.Invoke(this, EventArgs.Empty);
}
NotifyTextChanged();
}
else
{
@ -1060,12 +1047,7 @@ namespace Nikse.SubtitleEdit.Controls
_textBox.Focus();
_textBox.SelectionLength = 0;
if (!_loading)
{
SelectedIndexChanged?.Invoke(this, EventArgs.Empty);
SelectedValueChanged?.Invoke(this, EventArgs.Empty);
TextChanged?.Invoke(this, EventArgs.Empty);
}
NotifyTextChanged();
return;
}