Mirrors/backupninja
1
0
Fork 0
mirror of https://0xacab.org/liberate/backupninja.git synced 2024-11-08 20:02:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

ninjahelper.in: remove runtime overzealous perms checks on the helpers

Browse Source
This commit is contained in:
intrigeri 2006-10-07 02:44:05 +00:00
parent c836982f43
commit 26e33dcc47
2 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -85,6 +85,10 @@ version 0.9.4 -- unreleased
. Fix configdirectory error that forced you to use /etc/backup.d, thanks anarcat . Fix configdirectory error that forced you to use /etc/backup.d, thanks anarcat
. When determining which backup actions to list, find now follows . When determining which backup actions to list, find now follows
symlinks for $configdirectory symlinks for $configdirectory
. Stop checking helpers perms: both "make install" and distros packages
install them with appropriate permissions, it's overzealous to check
this at runtime, and is more complicated to do with current
admingroup option.
dup.helper: dup.helper:
. Fix: signing was enabled with symmetric encryption. . Fix: signing was enabled with symmetric encryption.
changed cron permissions to 644 changed cron permissions to 644

18
src/ninjahelper.in
View File

@ -4,23 +4,6 @@
#################################################### ####################################################
## Functions ## Functions
function check_perms() {
local file=$1
local perms=`ls -ld $file`
group_w_perm=${perms:5:1}
world_w_perm=${perms:8:1}
if [ "$group_w_perm" == "w" -o "$world_w_perm" == "w" ]; then
echo $perms
echo "helper scripts must not be group or world writable! Dying on file $file"
exit
fi
if [ `ls -ld $file | awk '{print $3}'` != "root" ]; then
echo "helper scripts must be owned by root! Dying on file $file"
exit
fi
}
## ##
## returns the next available file name given a file ## returns the next available file name given a file
## in the form @CFGDIR@/backup.d/10.sys ## in the form @CFGDIR@/backup.d/10.sys
@ -238,7 +221,6 @@ getconf scriptdirectory @datadir@
# load all the helpers # load all the helpers
HELPERS="" HELPERS=""
for file in `find $scriptdirectory -follow -name '*.helper'`; do for file in `find $scriptdirectory -follow -name '*.helper'`; do
check_perms $file
. $file . $file
if [ $? != 0 ]; then if [ $? != 0 ]; then
echo "An error occurred while loading $file. Hit return to continue." echo "An error occurred while loading $file. Hit return to continue."