Security fix: duplicity handler used to put the gpg passphase on the command line.

This commit is contained in:
intrigeri 2005-08-20 15:37:57 +00:00
parent bfe530dc59
commit 6b6154879b
2 changed files with 7 additions and 6 deletions

View File

@ -15,7 +15,8 @@ nicelevel = 19
[gpg]
# passphrase needed to unlock the GnuPG key
password = "a_very_complicated_passphrase"
# NB: do not quote it, and it should not contain any quote
password = a_very_complicated_passphrase
# default is no, for backward compatibility with backupninja <= 0.5.
# when set to yes, encryptkey option must be set below.

View File

@ -131,17 +131,17 @@ execstr=${execstr//\\*/\\\\\\*}
debug "duplicity $execstr --exclude '**' / $execstr_serverpart"
if [ ! $test ]; then
export PASSPHRASE=$password
output=`nice -n $nicelevel \
su -c \
"export PASSPHRASE=$password \
&& duplicity $execstr --exclude '**' / $execstr_serverpart 2>&1"`
"duplicity $execstr --exclude '**' / $execstr_serverpart 2>&1"`
code=$?
if [ "$code" == "0" ]; then
if [ $code -eq 0 ]; then
debug $output
info "Duplicity finished successfully."
else
warning $output
warning "Duplicity failed."
debug $output
fatal "Duplicity failed."
fi
fi