Commit Graph

30 Commits

Author SHA1 Message Date
Jerome Charaoui
0ec7752dd3 Cleanup tariling whitespace 2021-01-22 11:24:14 -05:00
Jerome Charaoui
eabda5615c Remove vserver support (fixes #11289)
This is probably completely unused by now, as vservers have been
superseeded by alternative technology for many years already.
2021-01-02 15:27:32 -05:00
Jerome Charaoui
bc9be0d576 Attempt to sanitize the database identifiers
Removing the quote and semicolon characters should be sufficient to
prevent breaking out of the shell command, but this may need reviewed
by someone more knowlegeable in shell scripting.
2018-03-16 16:52:39 -04:00
intrigeri
e0b4375400 Quote command output strings passed to logging functions.
Thanks to @Gackiewicz for the report!

Closes #11278
2018-01-10 10:44:33 +00:00
ibauer
711ea76dd1 #11148: skip dumping information|performance_schema in mysql handler
- Escaped single quotes as described in https://stackoverflow.com/questions/1250079/how-to-escape-single-quotes-within-single-quoted-strings
2017-08-03 15:30:51 +02:00
ibauer
436e57ec29 #11148: skip dumping information|performance_schema in mysql handler
- Replaced nested single quotes with escaped double quotes
2017-07-28 10:54:32 +02:00
ibauer
7d7d853123 #11148: skip dumping information|performance_schema in mysql handler
- Removed escaping as it is not needed and wrong
2017-07-21 16:47:20 +02:00
ibauer
44a7ee8912 #11148: skip dumping information|performance_schema in mysql handler 2017-07-21 16:12:39 +02:00
intrigeri
e96a894bb8 mysql: fix non-qualified table name extraction (Closes: Redmine#4373). 2014-02-22 13:34:57 +00:00
intrigeri
29e2c75ede mysql: make "nodata" option compatible with compress=no. 2013-12-26 15:42:22 +00:00
intrigeri
b05065625c mysql: use --skip-events when backing up the performance_schema database (Closes: #673572) 2012-05-20 13:11:12 +02:00
intrigeri
b99ccd6303 mysql: Don't attempt to dump performance_schema database (Redmine#3741).
Locking its tables require privileges the 'debian-sys-maint'@'localhost' user is
generally not granted.
2012-01-24 01:25:08 +01:00
intrigeri
6aca9c822b All handlers: stop using "local VAR" outside functions. (Closes: #530647) 2011-04-25 18:55:58 +02:00
intrigeri
13f247afeb Fix reliance on bash for pipefail. (Closes: #602374)
Thanks to Sergio Talens-Oliag <sto@debian.org> for the bug report and patch.
2010-11-07 13:07:26 +01:00
intrigeri
4015578106 Fix code logic to make dbusername/dbpassword actually usable (Closes Redmine bug #2264) 2010-06-24 16:53:58 +02:00
intrigeri
9179c59b50 mysql: don't lock tables in the information_schema database (Closes: #587011) 2010-06-24 16:18:44 +02:00
intrigeri
aeca6912a8 Added GZIP_OPTS option, defaulting to --rsyncable.
... so that this option can be disabled on systems that don't support it.
This also allows to use another compression program, such as pbzip2 on SMP
machines (closes Roundup bug #2405).
2010-06-14 19:06:59 +02:00
intrigeri
47313bca65 ldap,mysql,pgsql: use bash pipefail option so that failed dumps are reported as such
This should fix Redmine bug #1340.

This option makes pipelines return as status the value of the last (rightmost)
command to exit with a non-zero status, or zero if all commands exit
successfully. See bash(1) for details.

E.g. this prevents the following from exiting with status 0 (!) if pg_dumpall
fails:

        pg_dumpall | gzip
2010-01-08 23:40:23 +01:00
intrigeri
a53e8a531a Fix indentation of previously cherry-picked patch 2010-01-05 13:11:57 +01:00
intrigeri
d65fa0c058 Cherry-picked "fixes for mysql handler for mysqld inside a vserver"
This commit (64edfccf76) was wrongly committed to
the debian branch.

Conflicts:

	handlers/mysql.in
2010-01-05 13:09:38 +01:00
intrigeri
f4ab3148f1 mysql, pgsql: Quote output filenames
... to support shell meta-characters in database names.
Closes Redmine bug #617.
2009-12-25 02:33:13 +01:00
intrigeri
f967264717 ldap, mysql, pgsql: use gzip's --rsyncable option 2009-11-19 20:27:46 +01:00
Matthijs Kooijman
78884142e7 Add a vim modeline with indentation settings.
The modelines added match the emacs lines already present and also set
the filetype to sh (just like the emacs lines).
2009-05-23 10:42:20 +02:00
Matthijs Kooijman
4ecaae9405 Make all indentation consistent.
Previously, there were many indentation styles in use: Real tabs, 2, 3
or 4 spaces, mixing these within the same file, function or even within
a single line.

This commit changes all bash scripts in the handlers, src and lib dirs
to use consistent indentation: three spaces are now used everywhere.
Other files (e.g. Makefiles) are left untouched.

Additionally, this commit removes all trailing whitespace.
2009-05-23 10:34:16 +02:00
intrigeri
94861df686 mysql: fix 'mysqladmin ping' use, see changelog for details 2009-01-12 22:47:30 +00:00
intrigeri
2cfcdd636d mysql: new sqldumpoptions config variable (Closes: #502966) 2008-12-09 11:40:03 +00:00
intrigeri
88b787718d pgsql, mysql, svn: use new vservers_running function from lib/vserver (factorization++) 2008-06-24 15:55:10 +00:00
Micah Anderson
19dbc0aaee add patch from matthew palmer to enhance mysql database selection (Closes: #452039) 2007-11-20 01:28:49 +00:00
Micah Anderson
3cf6de4374 added nodata option to mysql handler, thanks to Daniel Bonniot (Closes: 408829) 2007-11-02 00:52:55 +00:00
intrigeri
579ea902ba fixed autotools build, broken since r466, inhandlers/Makefile.am 2007-10-12 17:06:09 +00:00