Commit Graph

30 Commits

Author SHA1 Message Date
phlummox
258d04aee0 Fix https://0xacab.org/liberate/backupninja/-/issues/11328 2022-03-11 06:30:23 +00:00
Jerome Charaoui
b94b3639ff restic: use eval to execute restic
Without it, the single-quoted paths on the command-line are interperted
literally, leading restic find all include paths invalid...
2021-01-12 19:25:39 -05:00
Jerome Charaoui
f71d6882c6 restic: quote string and path values in command options
Make this consistent with the borg handler. Allows users to use paths
that include spaces in them and prevents shell globbing when the restic
command is called. According to the restic docs, if glob paths are
needed, they should be read from a file (--files-from).
2021-01-12 14:40:14 -05:00
Jerome Charaoui
a8df514531 restic: remove defaults for include/exclude
Making this consistent with the borg handler. Users should think about
what they need to be backup. The example file is there to provide a
baseline.
2021-01-12 14:37:53 -05:00
Jerome Charaoui
362fe316a4 restic: skip init when test mode enabled 2021-01-12 14:36:35 -05:00
Jerome Charaoui
b013dc759b restic: init repository if needed, by default
Add backup/init config directive (defaults to yes) to control whether
the repository should be initialized if it doesn't exist. Since we need
to attempt to connect to the repository to verify if init is needed,
remove the testconnect parameter so that the handler just tests the
connection every time it runs.
2021-01-11 20:46:12 -05:00
Jerome Charaoui
36638fa6ed restic: simplify connection tests
Replace convoluted code to test SFTP and REST backends with a simple
restic snapshots command. Much simpler and supports all backends...
2021-01-11 20:03:46 -05:00
Jerome Charaoui
20faa6943b restic: whitespace 2021-01-11 18:31:08 -05:00
Jerome Charaoui
b012119b49 restic: make restic check run at the end
As per the restic docs, check should usually be run after prune, which
makes sense as we want to verify the consistency of the repository after
making changes.
2021-01-11 18:27:54 -05:00
Jerome Charaoui
66f488c232 restic: enable testconnect by default and add to example 2021-01-11 18:22:11 -05:00
Jerome Charaoui
356ffa210f restic: support nicelevel and ionicelevel 2021-01-11 18:21:49 -05:00
Jerome Charaoui
9b262e5b7b restic: remove rebuild-index
The command rebuild-index should only be necessary as part of an attempt
to repair a malfunctioning repository. I could not find anywhere in the
documentation recommending to run this command at regular intervals.
2021-01-11 17:54:51 -05:00
Jerome Charaoui
e8df595c9f restic: remove retry_run logic
Simplify and make program calls more consistent with other handlers. The
automatic retry mechanism shouldn't be needed for restic any more than
other backup programs. If it's implemented, it should be at the core
level.
2021-01-11 17:15:17 -05:00
Jerome Charaoui
d69fd2dc69 restic: rework sftp and rest connection tests 2021-01-11 17:14:45 -05:00
Jerome Charaoui
b1486bb3cf restic: use autotools abstraction for awk path 2021-01-10 16:26:22 -05:00
Jerome Charaoui
458c9197fc restic: name option correctly is error message 2021-01-10 16:26:22 -05:00
Jerome Charaoui
63c3d0c591 restic: debug output consistent with other handlers 2021-01-10 16:26:22 -05:00
Jerome Charaoui
bd9cc6db42 restic: support --test mode 2021-01-10 16:26:22 -05:00
Jerome Charaoui
99be27b93c restic: remove unnecessary crunchbang 2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
6c0e49689b fix(restic): unset aws session token envvar 2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
b395660fa9 fix(restic): typo 2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
a8fa5f429b change(restic): add aws_session_token introduced in restic 0.9.2 2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
ca5358bc3f fix(restc): avoid word splitting for options 2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
ff61e65be4 Fix(restic) catch attempt failure
Failure was reported even when the last attempt was successful.
2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
b09529e96b Fix(restic) wait between retries
Too quick retry could lead to locking issue.
2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
acee92fef5 Fix(restic) remove verbose option
BackupNinja does not capture command output so this option is useless,
plus it make check command fails.
2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
0b9117b39f Fix(restic) getconf retry_run 2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
bceee65ed8 restic: make number of retries configurable 2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
b148b3c9ef restic add retry function 2021-01-10 16:26:22 -05:00
Nicolas KAROLAK
052f45ebb1 restic: rename file with .in extension 2021-01-10 16:26:22 -05:00