Commit Graph

59 Commits

Author SHA1 Message Date
Jerome Charaoui
9f5952ce34 dup: streamline encryption and signing logic 2021-01-05 11:00:54 -05:00
Jerome Charaoui
d949454366 dup: bandwidthlimit is compatible with desturl
However it's not compatible with local filesystem desturl.
2021-01-05 10:59:49 -05:00
Jerome Charaoui
f007227e4c dup: execute ssh connection test in test mode
Also bring in line with the code used in other handlers.
2021-01-05 10:56:26 -05:00
Jerome Charaoui
e657d42aab dup: improve sanity checks
* also validate desthost and destuser when desturl undefined
 * move desturl vs destuser/host/dir warning in sanity checks section
 * ensure includes are specified
 * drop checks on local destination, duplicity autocreates directory
 * add some needed whitespace
2021-01-05 10:52:46 -05:00
Jerome Charaoui
eabda5615c Remove vserver support (fixes #11289)
This is probably completely unused by now, as vservers have been
superseeded by alternative technology for many years already.
2021-01-02 15:27:32 -05:00
Gabriel Filion
5c6c583181 Enable use of ionice for all handlers to alleviate IO load
On some workloads, a process creating backups should not become so
aggressive on resources that it prevents normal activity of a machine
from running. It is especially important when writing to disk.

One way to make backups have less impact on the main workload is to
force backups to a lower ionice level.

With the new ionicelevel configuration, it becomes possible for users to
activate the use of ionice and to define the level within the
best-effort class to better suit their needs.
2020-12-31 02:08:50 -05:00
Hugh Nowlan
4725d7835f Correct path 2018-04-30 13:47:30 +01:00
Hugh Nowlan
f2bc6d60aa Error out if archive dir doesn't exist 2018-04-30 12:59:21 +01:00
intrigeri
e0b4375400 Quote command output strings passed to logging functions.
Thanks to @Gackiewicz for the report!

Closes #11278
2018-01-10 10:44:33 +00:00
Matthijs Wensveen
af2b8d0b62 Symmetric encryption in dup handler is broken (#11274) 2017-10-12 11:20:31 +02:00
intrigeri
f8e1664e01 dup handler: correctly handle Dropbox access token (Closes: #11260).
Thanks to Daniel Lo Nigro for the patch.
2017-07-25 09:55:13 +00:00
intrigeri
ed864a64e3 Run duplicity in a C locales environment (Closes: #736280).
This workarounds a bug in duplicity. Quoting the reporter (thanks, Jonathan
Dupart <jonathan@dupart.org>, for the detailed report and initial patch):

The duplicity backend is broken when the gpg ecryption is set up and the
system default locale is not english (or C).

The bug reports on duplicity are here :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=565398
https://bugs.launchpad.net/duplicity/+bug/510625
2014-03-01 11:56:11 +00:00
Dominik George
c5738b11d9 Added SIGN_PASSPHRASE support for dup handler. 2014-02-22 14:56:58 +00:00
intrigeri
1017ec315f dup: Fix buggy version comparison. (Redmine#6746) 2014-02-22 14:23:22 +00:00
intrigeri
1a762885e2 Make logic consistent with what we're using elsewhere.
Without this change, e.g. 0.5.20 would not get --extra-clean, while it should.
Granted, the new test is buggy too, e.g. 0.7.1 will get --extra-clean,
while it should not. Will report that to Redmine.
2014-02-22 13:41:43 +00:00
Alexander Mette
e27654df5c Fix #6357 - Don't remove useful signature files
duplicity >=0.6.20 now correctly removes useless signature files and
therefore the cache directory doesn't grow infinitely any more. Using
--extra-clean removes all signatures except from the last chain and so
renders older chains unusable, don't use it by default any more.
See: https://bugs.launchpad.net/duplicity/+bug/519948
2014-02-22 13:39:27 +00:00
intrigeri
7a5045baf1 dup: Gracefully handle legacy spaces between -o and IdentityFile. 2013-07-23 12:01:37 +02:00
intrigeri
1790b5332b duplicity: for local backups, check that the destination directory exists.
Thanks to ulrich for the preliminary patch.

Closes Redmine#4049.
2012-09-20 00:13:18 +02:00
intrigeri
3a94e3bc59 Report duplicity failure output at error loglevel so that it is emailed. 2012-02-25 15:05:32 +01:00
intrigeri
50c2f6e02a Remove leftover FIXME that was fixed. 2012-02-25 14:41:50 +01:00
intrigeri
5bfa30bb22 Support bandwidthlimit again with new duplicity, using trickle.
duplicity 0.6.17 uses paramiko backend.
Thus, it does not support limiting bandwidth anymore.
Let's use trickle to support bandwidth shaping anyway.
2012-01-29 16:44:12 +01:00
intrigeri
f896ef3f65 dup: add precmd to every duplicity call. 2012-01-29 15:09:37 +01:00
intrigeri
357a17b155 Use --ssh-options with dup >= 0.6.17.
... and warn about unsupported options.
2012-01-29 15:09:37 +01:00
intrigeri
f351306d82 dup: add support for RackSpace's CloudFiles.
Thanks to Yuval Kogman <nothingmuch@woobling.org> for the patch.
2011-10-22 21:46:50 +02:00
intrigeri
5d94e2ad0d dup: fix incorrect duplicity version check for keepincroffulls.
Thanks to Olivier Berger <oberger@ouvaton.org> for the patch.
(Closes Redmine bug #3443)
(Closes: #641120)
2011-09-11 00:18:23 +02:00
intrigeri
7b57f84a92 Cleanup: stop supporting duplicity < 0.6.01 (Redmine#2538). 2011-08-17 12:31:30 +02:00
Olivier Berger
55fe213f9b Fix merge problem 2011-04-25 22:40:44 +02:00
Olivier Berger
ca14175210 Now that there's some removal of increments for old fulls, we can keep fulls for a longer time, for instance 1Y which becomes default 2011-04-25 22:40:44 +02:00
Olivier Berger
a1c2229e1a Proposed feature to address https://labs.riseup.net/code/issues/2492 2011-04-25 22:40:44 +02:00
intrigeri
6aca9c822b All handlers: stop using "local VAR" outside functions. (Closes: #530647) 2011-04-25 18:55:58 +02:00
intrigeri
a80d6f4a0c Make it clear duplicity >=0.4.9 is required when using a custom tmpdir. 2010-10-12 11:47:15 +02:00
intrigeri
dc7f723e5c Remove support for duplicity < 0.4.4. Even etch-backports has a newer one. 2010-10-12 11:44:35 +02:00
intrigeri
55d9452da5 dup: use --tempdir option rather than TMPDIR environment variable.
Closes Roundup bug #598.

This breaks support of Debian etch.
2010-10-12 11:15:47 +02:00
intrigeri
d6ec2b4e62 Store duplicity cache to /var/cache/backupninja/duplicity.
... instead of previous /var/backups/duplicity.
2010-05-10 22:15:41 +02:00
intrigeri
99434c8b07 Added ftp_password option.
This is the only way to securely transmit the FTP password from backupninja
to duplicity.
2010-05-06 20:05:20 +02:00
intrigeri
33365d0953 dup: use --archive-dir /var/backups/duplicity unless the user has specified it (Closes: 580213) 2010-05-06 19:27:18 +02:00
Olivier Berger
abf7a4bb65 Implement Debian #535996 to use --full-if-older-than 2010-05-02 17:45:02 +02:00
olivier
4f4ee9b0d9 Add full-if-older-than with half the keep duration 2010-05-02 12:05:15 +02:00
intrigeri
582b7521cb dup: ignore anything but digits and "." when comparing versions (Closes: #578987)
I'd love to use "dpkg --compare-versions" but we don't want backupninja to be
Debian-specific. Any similar tool?

Signed-off-by: intrigeri <intrigeri@boum.org>
2010-04-24 20:00:13 +02:00
intrigeri
1cd91839c3 dup: use duplicity's --extra-clean option when necessary
This is necessary to get rid of unnecessary old cache files when cleaning up,
when using duplicity >=0.6.01 that depends on local caching.

Closes: #572721
2010-03-06 19:25:27 +01:00
intrigeri
64c4d190a3 dup: support backups to Amazon S3 buckets
Thanks to stefan <s.freudenberg@jpberlin.de> for the patch.
This fixes Redmine bug #658.
2010-01-09 23:14:17 +01:00
intrigeri
4e0519e390 rdiff,dup: fix include/exclude paths with spaces (Closes: #398435)
This also fixes Redmine bug #1021.
2010-01-09 00:44:43 +01:00
olivier
480ace739c Convert from debug to info so that it can be reported in the email 2010-01-05 13:47:12 +01:00
olivier
61eb6a7484 Add duplicity output line by line instead of with a whole at one time. Should help fix #536360 2010-01-05 13:16:09 +01:00
intrigeri
1b991d6c15 dup: fixed bandwidth vs desturl testing 2009-07-18 10:48:10 +02:00
intrigeri
f45803230a dup: fixed bandwidthlimit test
Thanks to Ian Beckwith <ianb@erislabs.net> for the patch.
2009-07-18 10:47:55 +02:00
Matthijs Kooijman
78884142e7 Add a vim modeline with indentation settings.
The modelines added match the emacs lines already present and also set
the filetype to sh (just like the emacs lines).
2009-05-23 10:42:20 +02:00
Matthijs Kooijman
4ecaae9405 Make all indentation consistent.
Previously, there were many indentation styles in use: Real tabs, 2, 3
or 4 spaces, mixing these within the same file, function or even within
a single line.

This commit changes all bash scripts in the handlers, src and lib dirs
to use consistent indentation: three spaces are now used everywhere.
Other files (e.g. Makefiles) are left untouched.

Additionally, this commit removes all trailing whitespace.
2009-05-23 10:34:16 +02:00
intrigeri
0a6abfc3ce dup: added option --force to cleanup and remove-older-than commands, else they actually do not do anything 2008-06-29 07:26:36 +00:00
intrigeri
788e82b56a dup: set secure permissions on tmpdir when creating it 2008-06-25 09:54:45 +00:00