Commit Graph

447 Commits

Author SHA1 Message Date
Jerome Charaoui
bc9be0d576 Attempt to sanitize the database identifiers
Removing the quote and semicolon characters should be sufficient to
prevent breaking out of the shell command, but this may need reviewed
by someone more knowlegeable in shell scripting.
2018-03-16 16:52:39 -04:00
intrigeri
e0b4375400 Quote command output strings passed to logging functions.
Thanks to @Gackiewicz for the report!

Closes #11278
2018-01-10 10:44:33 +00:00
intrigeri
b15e5f6b80 Merge branch 'master' into 'master'
#11273: Exclude partitions from device list

Closes #11273

See merge request riseuplabs/backupninja!7
2018-01-10 02:13:33 -08:00
Matthijs Wensveen
af2b8d0b62 Symmetric encryption in dup handler is broken (#11274) 2017-10-12 11:20:31 +02:00
Romain Dessort
dff9ac99c5 Close #11273. Exclude partitions from device list
Use lsblk instead of sfdisk to get a list of block devices on the host.
2017-09-28 13:58:53 -04:00
intrigeri
0356db5dcc Documentation: bandwidthlimit for the dup handler needs to be given in KB/s, and not (as wrongly advertised previously) in Kbit/s.
Closes: #7603
2017-08-12 22:10:29 +00:00
intrigeri
a3ee78c057 Merge branch 'mysql' into 'master'
#11148: skip dumping information|performance_schema in mysql handler

See merge request !5
2017-08-12 18:17:36 +00:00
ibauer
711ea76dd1 #11148: skip dumping information|performance_schema in mysql handler
- Escaped single quotes as described in https://stackoverflow.com/questions/1250079/how-to-escape-single-quotes-within-single-quoted-strings
2017-08-03 15:30:51 +02:00
ibauer
436e57ec29 #11148: skip dumping information|performance_schema in mysql handler
- Replaced nested single quotes with escaped double quotes
2017-07-28 10:54:32 +02:00
intrigeri
f8e1664e01 dup handler: correctly handle Dropbox access token (Closes: #11260).
Thanks to Daniel Lo Nigro for the patch.
2017-07-25 09:55:13 +00:00
ibauer
7d7d853123 #11148: skip dumping information|performance_schema in mysql handler
- Removed escaping as it is not needed and wrong
2017-07-21 16:47:20 +02:00
ibauer
44a7ee8912 #11148: skip dumping information|performance_schema in mysql handler 2017-07-21 16:12:39 +02:00
Micah Anderson
41c3544ed5 dsync: the dsync handler incorrectly would test for >3 failures before
emitting the failure message, it should do so at =>3
2015-03-30 12:23:50 -04:00
Silvio Rhatto
3094b04da5 Rsync: check test mode should set proper dest path (#8196) 2014-11-07 15:16:30 -02:00
Silvio Rhatto
89860aa3f6 Rsync: check test mode also in prepare_storage (#8196) 2014-11-07 14:36:25 -02:00
Silvio Rhatto
c649339ba4 Rsync: support for backupninja's test option (#8196) 2014-11-05 11:18:11 -02:00
intrigeri
9b37f756f5 Exclude tmpfs filesystems from df output in the sys handler (Closes: Debian#745818). 2014-05-03 14:08:04 +00:00
intrigeri
8db80421aa Fix indentation in sys handler.
Thanks to Jools Wills <jools@oxfordinspire.co.uk> for the patch.
2014-05-03 13:45:51 +00:00
intrigeri
14eed7f751 Remove spurious quotes that broke the sys helper (Closes: Redmine#6803).
Thanks to Jools Wills <jools@oxfordinspire.co.uk> for the patch.
2014-05-03 13:38:45 +00:00
intrigeri
179eb70b8c Merge remote-tracking branch 'sarava/bug/3003'
Conflicts:
	handlers/rsync.in
2014-05-03 13:24:08 +00:00
intrigeri
9e1d98a253 Merge remote-tracking branch 'sarava/bug/3929' 2014-05-03 13:20:21 +00:00
Christian Prause
8ed2f8de3f Added suse to the list of supported OS 2014-05-03 13:12:10 +00:00
intrigeri
ed864a64e3 Run duplicity in a C locales environment (Closes: #736280).
This workarounds a bug in duplicity. Quoting the reporter (thanks, Jonathan
Dupart <jonathan@dupart.org>, for the detailed report and initial patch):

The duplicity backend is broken when the gpg ecryption is set up and the
system default locale is not english (or C).

The bug reports on duplicity are here :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=565398
https://bugs.launchpad.net/duplicity/+bug/510625
2014-03-01 11:56:11 +00:00
Dominik George
c5738b11d9 Added SIGN_PASSPHRASE support for dup handler. 2014-02-22 14:56:58 +00:00
intrigeri
1017ec315f dup: Fix buggy version comparison. (Redmine#6746) 2014-02-22 14:23:22 +00:00
intrigeri
1a762885e2 Make logic consistent with what we're using elsewhere.
Without this change, e.g. 0.5.20 would not get --extra-clean, while it should.
Granted, the new test is buggy too, e.g. 0.7.1 will get --extra-clean,
while it should not. Will report that to Redmine.
2014-02-22 13:41:43 +00:00
Alexander Mette
e27654df5c Fix #6357 - Don't remove useful signature files
duplicity >=0.6.20 now correctly removes useless signature files and
therefore the cache directory doesn't grow infinitely any more. Using
--extra-clean removes all signatures except from the last chain and so
renders older chains unusable, don't use it by default any more.
See: https://bugs.launchpad.net/duplicity/+bug/519948
2014-02-22 13:39:27 +00:00
intrigeri
e96a894bb8 mysql: fix non-qualified table name extraction (Closes: Redmine#4373). 2014-02-22 13:34:57 +00:00
intrigeri
ce4db5dd4f rdiff.helper: don't give misleading information regarding required fields (Closes: Redmine#4410). 2014-02-22 13:11:49 +00:00
intrigeri
29e2c75ede mysql: make "nodata" option compatible with compress=no. 2013-12-26 15:42:22 +00:00
Silvio Rhatto
b8b8b46fba Solve quoting issue with "su" (debian #683731) (upstream #4019)
A fix for debian #677410 on commit 29dcdbae introduces a new issue on wheezy
machines where some rsync_options gets out of the rsync command quotes when
invoked by su.

As reported, running backupninja through `bash -x` shows that the `--delete`
option from the rsync command is not included in the single quote for the `su
-c` command:

    nice -n 0 su -c '/usr/bin/rsync -av' --delete '--recursive
    --delete-excluded    //home/ /tmp/test//home//'

This patch attempt to solve that issue by using the intermediary variable
$command.
2013-10-26 13:18:19 -02:00
intrigeri
0cb6fcd647 Delete trailing whitespace. 2013-09-23 10:19:26 +00:00
Micah Anderson
54ec07be55 add additional sys backup options to provide the ability to backup the MBR for every device found, and to backup the BIOS (if the flashrom program is installed, and the mainboard is supported) 2013-09-20 16:48:13 -04:00
Micah Anderson
373c6bcced fix capitalization of LUKS 2013-09-20 13:45:57 -04:00
Micah Anderson
be4456ae3f fix missing autoconf marker for @SED@ 2013-09-20 13:45:10 -04:00
Micah Anderson
0df3c9939d fix luks header backup to properly detect partitions
previously the code was modeled off of the partition backup methodology, this resulted in the code only attempting to detect luks on actual devices, and not on partitions. The code would step through every disk on the system (sda, sdb, etc.) and do a 'cryptsetup isLuks' on that device, and then based on that output save the luks header for any device that had one. Unfortunately, in many cases, luks headers are found on the partitions of those disks. So we were failing to detect any luks partitions and thus failing to backup their luks headers.

this commit changes that, it now will look for luks headers on the devices themselves (for cases where a full disk is used without partitions), and on any partitions that are detected
2013-09-20 13:44:11 -04:00
intrigeri
7a5045baf1 dup: Gracefully handle legacy spaces between -o and IdentityFile. 2013-07-23 12:01:37 +02:00
intrigeri
b3275eb7b1 Clarify that duplicity/paramiko doesn't support spaces between -o and IdentityFile anymore. 2013-07-23 12:01:02 +02:00
intrigeri
e732e84750 rdiff.helper: add output_as_info support.
Thanks to David Gasaway <dave@gasaway.org> for the patch!
2013-07-09 21:45:44 +02:00
Pierre ROUDIER
4ebee050b4 test mode support for tar handler 2013-06-30 12:20:25 +02:00
Pierre ROUDIER
625d1424ca xz support for tar handler 2013-06-28 09:08:39 +02:00
intrigeri
1c6677ebdd Add option to include rdiff-backup output in reports.
Thanks to David Gasaway <dave@gasaway.org> for the patch.
2013-06-08 08:59:03 +02:00
Micah Anderson
0dbac2a1c1 dsync: break out of the while loop using 'break' instead of setting the failedcount number, otherwise this will trigger the warning later 2012-11-26 12:49:43 -05:00
Micah Anderson
03eadb018b dsync: fix loop number of iterations, we want to try 3 times, and we are starting at 0 2012-11-26 12:49:16 -05:00
Micah Anderson
c0e571ebb4 remove some debugging bits that snuck in 2012-11-26 12:44:27 -05:00
Micah Anderson
4c7660f201 set autotools markers and default application paths 2012-11-26 12:30:40 -05:00
Micah Anderson
9b679b71a8 the 'fatal' here was causing backups to stop after they hit a user who has
trouble, causing all subsequent backups never to fire.
2012-11-26 12:30:40 -05:00
Micah Anderson
090cef2438 fix quoting on srcconffile and destcconffile
stop attempting to sync to current_backup, because if we do this then we do this then we don't take advantage of the hardlinking that is done later
2012-11-26 12:30:40 -05:00
intrigeri
1790b5332b duplicity: for local backups, check that the destination directory exists.
Thanks to ulrich for the preliminary patch.

Closes Redmine#4049.
2012-09-20 00:13:18 +02:00
intrigeri
80a51a3e64 Do not warn when rsync exits with status 0. 2012-06-29 16:36:54 +02:00