Commit Graph

417 Commits

Author SHA1 Message Date
intrigeri
ce4db5dd4f rdiff.helper: don't give misleading information regarding required fields (Closes: Redmine#4410). 2014-02-22 13:11:49 +00:00
intrigeri
29e2c75ede mysql: make "nodata" option compatible with compress=no. 2013-12-26 15:42:22 +00:00
Silvio Rhatto
b8b8b46fba Solve quoting issue with "su" (debian #683731) (upstream #4019)
A fix for debian #677410 on commit 29dcdbae introduces a new issue on wheezy
machines where some rsync_options gets out of the rsync command quotes when
invoked by su.

As reported, running backupninja through `bash -x` shows that the `--delete`
option from the rsync command is not included in the single quote for the `su
-c` command:

    nice -n 0 su -c '/usr/bin/rsync -av' --delete '--recursive
    --delete-excluded    //home/ /tmp/test//home//'

This patch attempt to solve that issue by using the intermediary variable
$command.
2013-10-26 13:18:19 -02:00
intrigeri
0cb6fcd647 Delete trailing whitespace. 2013-09-23 10:19:26 +00:00
Micah Anderson
54ec07be55 add additional sys backup options to provide the ability to backup the MBR for every device found, and to backup the BIOS (if the flashrom program is installed, and the mainboard is supported) 2013-09-20 16:48:13 -04:00
Micah Anderson
373c6bcced fix capitalization of LUKS 2013-09-20 13:45:57 -04:00
Micah Anderson
be4456ae3f fix missing autoconf marker for @SED@ 2013-09-20 13:45:10 -04:00
Micah Anderson
0df3c9939d fix luks header backup to properly detect partitions
previously the code was modeled off of the partition backup methodology, this resulted in the code only attempting to detect luks on actual devices, and not on partitions. The code would step through every disk on the system (sda, sdb, etc.) and do a 'cryptsetup isLuks' on that device, and then based on that output save the luks header for any device that had one. Unfortunately, in many cases, luks headers are found on the partitions of those disks. So we were failing to detect any luks partitions and thus failing to backup their luks headers.

this commit changes that, it now will look for luks headers on the devices themselves (for cases where a full disk is used without partitions), and on any partitions that are detected
2013-09-20 13:44:11 -04:00
intrigeri
7a5045baf1 dup: Gracefully handle legacy spaces between -o and IdentityFile. 2013-07-23 12:01:37 +02:00
intrigeri
b3275eb7b1 Clarify that duplicity/paramiko doesn't support spaces between -o and IdentityFile anymore. 2013-07-23 12:01:02 +02:00
intrigeri
e732e84750 rdiff.helper: add output_as_info support.
Thanks to David Gasaway <dave@gasaway.org> for the patch!
2013-07-09 21:45:44 +02:00
Pierre ROUDIER
4ebee050b4 test mode support for tar handler 2013-06-30 12:20:25 +02:00
Pierre ROUDIER
625d1424ca xz support for tar handler 2013-06-28 09:08:39 +02:00
intrigeri
1c6677ebdd Add option to include rdiff-backup output in reports.
Thanks to David Gasaway <dave@gasaway.org> for the patch.
2013-06-08 08:59:03 +02:00
Micah Anderson
0dbac2a1c1 dsync: break out of the while loop using 'break' instead of setting the failedcount number, otherwise this will trigger the warning later 2012-11-26 12:49:43 -05:00
Micah Anderson
03eadb018b dsync: fix loop number of iterations, we want to try 3 times, and we are starting at 0 2012-11-26 12:49:16 -05:00
Micah Anderson
c0e571ebb4 remove some debugging bits that snuck in 2012-11-26 12:44:27 -05:00
Micah Anderson
4c7660f201 set autotools markers and default application paths 2012-11-26 12:30:40 -05:00
Micah Anderson
9b679b71a8 the 'fatal' here was causing backups to stop after they hit a user who has
trouble, causing all subsequent backups never to fire.
2012-11-26 12:30:40 -05:00
Micah Anderson
090cef2438 fix quoting on srcconffile and destcconffile
stop attempting to sync to current_backup, because if we do this then we do this then we don't take advantage of the hardlinking that is done later
2012-11-26 12:30:40 -05:00
intrigeri
1790b5332b duplicity: for local backups, check that the destination directory exists.
Thanks to ulrich for the preliminary patch.

Closes Redmine#4049.
2012-09-20 00:13:18 +02:00
intrigeri
80a51a3e64 Do not warn when rsync exits with status 0. 2012-06-29 16:36:54 +02:00
Silvio Rhatto
05f596080d Issue just warnings on non-fatal rsync errors (#3966) 2012-06-20 00:38:23 -03:00
intrigeri
29dcdbae91 Run rsync command-line through a shell, so that single-quotes around excludes are interpreted (Closes: #677410)
When --exclude 'something' is passed directly to rsync without going through
a shell, rsync tries to match a file whose name contains single quotes, which is
definitely not what we want it to do: exclude arguments protected with single
quotes are meant to be passed to a shell.
2012-06-15 20:30:25 +02:00
intrigeri
1b48bc4444 rsync: stop passing $excludes as a single argument. 2012-06-15 20:27:01 +02:00
intrigeri
f7488968c0 rsync: generate excludes command-line snippet the same way as the duplicity handler does.
The latter has a robust history wrt. dealing with excludes / glob / quoting
etc., let's use that instead of the shiny new sed-based way.
2012-06-15 20:21:09 +02:00
Micah Anderson
cd3abeab35 add experimental dsync handler, heavily based on maildir handler 2012-06-11 10:22:08 -04:00
Micah Anderson
1eabbe5de7 dont run lspci and modinfo when hwinfo==no 2012-06-11 10:07:53 -04:00
Micah Anderson
f8e69f738e Merge branch 'master' of labs.riseup.net:backupninja 2012-06-11 10:02:34 -04:00
intrigeri
b05065625c mysql: use --skip-events when backing up the performance_schema database (Closes: #673572) 2012-05-20 13:11:12 +02:00
intrigeri
7e6a79c3d2 Install handlers as pkgdata_DATA, instead of their .in files. 2012-05-15 17:52:49 +02:00
intrigeri
d464a9742d Have "make dist" package handlers/*.in instead of make results. 2012-05-15 17:07:15 +02:00
Silvio Rhatto
5b319008da Updating pipefail branch so it can merge with master (#3892) 2012-05-15 10:00:45 -03:00
intrigeri
7c66b699f5 Always use explicit sed's -e.
Hopefully this fixes http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656968#31
and future incarnations of this class of bugs.
2012-05-14 16:30:02 +02:00
Silvio Rhatto
118d7587b6 Changing pipefail just when it's really needed 2012-05-12 21:48:43 -03:00
intrigeri
c522391404 Merge remote-tracking branch 'sarava/bug/3721' 2012-05-13 02:33:37 +02:00
intrigeri
38a0fc572a Merge remote-tracking branch 'sarava/bug/3838' 2012-05-13 02:31:06 +02:00
intrigeri
64b4d1c9f6 Merge remote-tracking branch 'sarava/bug/3840' 2012-05-13 02:29:48 +02:00
intrigeri
8e3981f444 Merge remote-tracking branch 'sarava/bug/3882' 2012-05-13 02:11:27 +02:00
Silvio Rhatto
b7a92b20f8 Fixing typos (#3868) 2012-05-10 21:26:38 -03:00
Silvio Rhatto
fbf25018be Set/restore pipefail to not mess with other scripts (#3892) 2012-05-10 21:03:37 -03:00
Silvio Rhatto
c43bac5911 Ensure that a non-zero rsync exit status is caught by our handler (#3892) 2012-05-10 18:47:11 -03:00
Silvio Rhatto
f2f7e8cdb3 Merge branches 'master' and 'bug/3840' into bug/3840 2012-05-10 18:16:32 -03:00
Silvio Rhatto
5af9b96371 Removing duplicated locking support (#3838) 2012-05-10 17:25:34 -03:00
Silvio Rhatto
ba3e37595d Changing a 'fatal' to a 'warning' on rsync handler.
Using 'warning' and 'return' instead of a fatal at rotate_long if
backuproot doesn't exist. Using a warning ensures that the backup
action can process the other includes and not just exit.
2012-05-10 17:00:58 -03:00
Silvio Rhatto
bf5ada0f03 Changing remaining 'exit' to 'fatal' at rsync handler (#3721) 2012-05-10 16:53:52 -03:00
Silvio Rhatto
39bb9e605f Trying additional quoting on excludes (upstream #3882) 2012-04-13 09:58:18 -03:00
Silvio Rhatto
5ea13f4c24 Using @SED@ for #3882 2012-04-13 00:31:03 -03:00
Silvio Rhatto
aa8d0f8648 Quoting $exclude and $excludes and avoiding a for loop on $exclude to not expand wildcards in beforehand (upstream #3882) 2012-04-12 21:29:57 -03:00
Silvio Rhatto
e22107cf09 Validate created date on long_rotation to avoid too many arguments at comparison (upstream #3868) 2012-04-12 20:52:05 -03:00