Commit Graph

15 Commits

Author SHA1 Message Date
intrigeri
e0b4375400 Quote command output strings passed to logging functions.
Thanks to @Gackiewicz for the report!

Closes #11278
2018-01-10 10:44:33 +00:00
intrigeri
db168e41fd pgsql: don't produce empty uncompressed backups (Redmine#3820). 2012-02-25 13:30:09 +01:00
intrigeri
6aca9c822b All handlers: stop using "local VAR" outside functions. (Closes: #530647) 2011-04-25 18:55:58 +02:00
intrigeri
13f247afeb Fix reliance on bash for pipefail. (Closes: #602374)
Thanks to Sergio Talens-Oliag <sto@debian.org> for the bug report and patch.
2010-11-07 13:07:26 +01:00
Jacob Anawalt
0b60b58153 Removed extra '.' in plain/sql dumps
Removed an extra '.' in file names introduced by the pg_dump options
patch, resulting in names like db..sql or db..sql.gz instead of just
db.sql or db.sql.gz.
2010-10-19 22:52:03 +02:00
Jacob Anawalt
7355535ee1 Enable pg_dump format option.
The format option of pg_dump enables tar and custom archive file formats in
addition to the default plain-text file containing SQL commands.

When either the tar or custom format are selected the behaviour of database=all is changed to no longer dump a single file via pg_dumpall. Instead pg_dumpall
is called once to export the "global" data (roles & tablespaces) and then
pg_dump is called once for each non-template table in the database.

To support the GZIP and GZIP_OPTS variables in backupninja and to give the
default --rsyncable gzip compression flag a chance at working on a PostgreSQL
backup, the custom output is forced to not use compression. Instead compression
is done via a pipe to gzip. Hopefully this benefits rsync and rdiff-backup
style backups for reduced backup and storage costs that outweigh the
restoration ones.
2010-10-12 10:49:34 +02:00
intrigeri
aeca6912a8 Added GZIP_OPTS option, defaulting to --rsyncable.
... so that this option can be disabled on systems that don't support it.
This also allows to use another compression program, such as pbzip2 on SMP
machines (closes Roundup bug #2405).
2010-06-14 19:06:59 +02:00
intrigeri
47313bca65 ldap,mysql,pgsql: use bash pipefail option so that failed dumps are reported as such
This should fix Redmine bug #1340.

This option makes pipelines return as status the value of the last (rightmost)
command to exit with a non-zero status, or zero if all commands exit
successfully. See bash(1) for details.

E.g. this prevents the following from exiting with status 0 (!) if pg_dumpall
fails:

        pg_dumpall | gzip
2010-01-08 23:40:23 +01:00
intrigeri
f4ab3148f1 mysql, pgsql: Quote output filenames
... to support shell meta-characters in database names.
Closes Redmine bug #617.
2009-12-25 02:33:13 +01:00
intrigeri
f967264717 ldap, mysql, pgsql: use gzip's --rsyncable option 2009-11-19 20:27:46 +01:00
Matthijs Kooijman
78884142e7 Add a vim modeline with indentation settings.
The modelines added match the emacs lines already present and also set
the filetype to sh (just like the emacs lines).
2009-05-23 10:42:20 +02:00
Matthijs Kooijman
4ecaae9405 Make all indentation consistent.
Previously, there were many indentation styles in use: Real tabs, 2, 3
or 4 spaces, mixing these within the same file, function or even within
a single line.

This commit changes all bash scripts in the handlers, src and lib dirs
to use consistent indentation: three spaces are now used everywhere.
Other files (e.g. Makefiles) are left untouched.

Additionally, this commit removes all trailing whitespace.
2009-05-23 10:34:16 +02:00
intrigeri
88b787718d pgsql, mysql, svn: use new vservers_running function from lib/vserver (factorization++) 2008-06-24 15:55:10 +00:00
intrigeri
1330b16c99 pgsql: clarify error message when backupdir does not exist 2008-06-24 15:01:35 +00:00
intrigeri
579ea902ba fixed autotools build, broken since r466, inhandlers/Makefile.am 2007-10-12 17:06:09 +00:00