Mirrors/brackets
1
0
Fork 0
mirror of https://github.com/adobe/brackets.git synced 2024-11-20 18:02:54 +01:00
Code Issues Releases Activity

Addressed comments

Browse Source 
Signed-off-by: Pete Nykanen <pete.a.nykanen@gmail.com>
This commit is contained in:
Pete Nykanen 2017-07-13 23:07:44 +03:00
parent 5d0f0e9de2
commit 8bd7adb2a0
No known key found for this signature in database
GPG Key ID: 00259E80AC64931F
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/editor/CodeHintList.js
View File

@ -326,9 +326,9 @@ define(function (require, exports, module) {
* Convert keydown events into hint list navigation actions.
*
* @param {KeyBoardEvent} keyEvent
* @param {bool} isFakeCallUp - True if faked call up (for example calling CTRL+Space while hints are open)
* @param {bool} isFakeKeydown - True if faked key down call (for example calling CTRL+Space while hints are open)
*/
CodeHintList.prototype._keydownHook = function (event, isFakeCallUp) {
CodeHintList.prototype._keydownHook = function (event, isFakeKeydown) {
var keyCode,
self = this;
@ -390,13 +390,13 @@ define(function (require, exports, module) {
}
// (page) up, (page) down, enter and tab key are handled by the list
if (event.type === "keydown" && this.isHandlingKeyCode(event) || isFakeCallUp) {
if ((event.type === "keydown" || isFakeKeydown) && this.isHandlingKeyCode(event)) {
keyCode = event.keyCode;
if (event.keyCode === KeyEvent.DOM_VK_ESCAPE) {
event.stopImmediatePropagation();
this.handleClose();
return false;
} else if (event.shiftKey &&
(event.keyCode === KeyEvent.DOM_VK_UP ||
@ -409,7 +409,7 @@ define(function (require, exports, module) {
} else if (keyCode === KeyEvent.DOM_VK_UP) {
_rotateSelection.call(this, -1);
} else if (keyCode === KeyEvent.DOM_VK_DOWN ||
(event.ctrlKey && keyCode === KeyEvent.DOM_VK_SPACE) || isFakeCallUp) {
(event.ctrlKey && keyCode === KeyEvent.DOM_VK_SPACE)) {
_rotateSelection.call(this, 1);
} else if (keyCode === KeyEvent.DOM_VK_PAGE_UP) {
_rotateSelection.call(this, -_itemsPerPage());