Mirrors/brackets
1
0
Fork 0
mirror of https://github.com/adobe/brackets.git synced 2024-11-20 09:53:00 +01:00
Code Issues Releases Activity

UI Tweaks and bug fixes in JS Refactoring (#14046)

Browse Source 
* Change shortcut for extract to variable and extract to function

* Tweak UI of inlinemenu widget

* Fix alignment issue in submenu

* Change string of getters/setters
This commit is contained in:
Boopesh Mahendran 2018-01-19 14:59:49 +05:30 committed by Prashanth Nethi
parent d518e7b278
commit a3b6d6ccd1
5 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/command/Menus.js
View File

@ -807,7 +807,7 @@ define(function (require, exports, module) {
// create MenuItem DOM
if (_isHTMLMenu(this.id)) {
// Create the HTML MenuItem
var $menuItem = $("<li><a href='#' id='" + menuItemID + "'>" +
var $menuItem = $("<li><a href='#' id='" + menuItemID + "'> " +
"<span class='menu-name'>" + name + "</span>" +
"<span style='float: right'>&rtrif;</span>" +
"</a></li>");

4
src/extensions/default/JavaScriptRefactoring/keyboard.json
View File

@ -1,9 +1,9 @@
{
"extractToVariable": [
"Ctrl-Shift-V"
"Ctrl-Alt-V"
],
"extractToFunction": [
"Ctrl-Shift-M"
"Ctrl-Alt-M"
],
"renameIdentifier": [
{

2
src/nls/root/strings.js
View File

@ -688,7 +688,7 @@ define({
"CMD_REFACTORING_RENAME" : "Rename",
"CMD_REFACTORING_TRY_CATCH" : "Wrap in Try Catch",
"CMD_REFACTORING_CONDITION" : "Wrap in Condition",
"CMD_REFACTORING_GETTERS_SETTERS" : "Create Getters Setters",
"CMD_REFACTORING_GETTERS_SETTERS" : "Create Getters/Setters",
"CMD_REFACTORING_ARROW_FUNCTION" : "Convert to Arrow Function",
"DESCRIPTION_CODE_REFACTORING" : "Enable/disable JavaScript Code Refactoring",
"ERROR_TRY_CATCH" : "Select valid code to wrap in a Try-catch block",

4
src/styles/brackets_core_ui_variables.less
View File

@ -67,7 +67,7 @@
@bc-menu-separator: #eaeaea;
// inline menu widget
@bc-inlinemenu-bg: #d7d7d7;
@bc-inlinemenu-text: #d4d4d4;
// Warning
@bc-warning-bg: #fdf5cc;
@ -157,7 +157,7 @@
@dark-bc-menu-separator: #343434;
// inline menu widget
@dark-bc-inlinemenu-bg: #47484b;
@dark-bc-inlinemenu-text: #d4d4d4;
// Warning
@dark-bc-warning-bg: #c95800;

18
src/styles/brackets_patterns_override.less
View File

@ -501,17 +501,25 @@ a:focus {
// Styles used for inlinemenu widget header
li.inlinemenu-header a {
background-color: @bc-inlinemenu-bg;
background-color: @bc-bg-tool-bar;
color: @bc-inlinemenu-text;
padding-bottom: 5px;
.dark & {
background-color: @dark-bc-inlinemenu-bg;
background-color: @dark-bc-bg-tool-bar;
color: @dark-bc-inlinemenu-text;
padding-bottom: 5px;
}
&:hover {
background-color: @bc-inlinemenu-bg;
background-color: @bc-bg-tool-bar;
color: @bc-inlinemenu-text;
padding-bottom: 5px;
.dark & {
background-color: @dark-bc-inlinemenu-bg;
background-color: @dark-bc-bg-tool-bar;
color: @dark-bc-inlinemenu-text;
padding-bottom: 5px;
}
}
}
@ -520,7 +528,7 @@ a:focus {
a {
// Less padding than on menus. More padding on top than bottom
// to center font within its bg highlight better.
padding: 2px 20px 0 0;
padding: 2px 20px 4px 0;
// Don't show highlighting on hover for code hints...
&:hover {