1
0
mirror of https://github.com/adobe/brackets.git synced 2024-11-20 09:53:00 +01:00
Commit Graph

2718 Commits

Author SHA1 Message Date
Pete Nykänen
32300dc3a5
Issue #11261: keep the search bar open (#14141)
* It fixes issue #11261 by preventing  the search bar from closing as a result of clicking in the main editor. This is done by commenting out the code in line 256. The search bar will also close when the ESC key is pressed while the main editor has focus

* Commented out unnecessary code around line 256

* [issue#11261] * Added in a menu option to allow find bar to stay open/automatically close
* Add a close icon to the search bar (for completeness)
* Fix escape key for in-editor searches
* Remember last search phrase if no selection for in-editor searches

* [issue#11261] Code clean up of initial mistakes of the previous commit

* [issue#11261] Strange issue with spacing in src/nls/fr/strings.js...

* [issue#11261] Strange issue with spacing in src/nls/fr/strings.js...

* [issue#11261] Further merge conflict resolution and clean up

* [issue#11261] Fix to branch and to testing

* [issue#11261] Fixes for incorrect regexp processing

* [issue#11261] Why does JSLint keep changing its own file

* [issue#11261] Not sure about the french one, let's exclude it for now until I can confirm with a Quebecois at work

* [issue#11261] Test left test file with change...

* [issue #11261] Minor fixes as per conversation of pull request

* [Issue #11261] Fixes mainly to the regular expression side of things

* [Issue #11261] Revert accidental change in JSLint

* [issue #11261] Remove loosy TODO and wording consistency change

* [Issue #11261] Remove Find Next on 'Find' option (we already have Find Next)

* [Issue #11261] (Retry the Travis CI build)

* Totally forgot to actually save the merge conflict resolution. Here it is.

* Merged master incorrectly - fix bad merge

* Fix test

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
2018-03-02 16:56:14 +02:00
Simon de Almeida
528f5a51a0 Merge branch 'master' of https://github.com/duplicates/brackets into issue-13099 2018-02-08 14:30:33 -05:00
Swagatam Mitra
24417e185a
Update README.md
Dummy change to create a new commit head. This is required to generate newer 1.12 builds with new build number
2018-02-01 16:46:17 +05:30
Sailesh Ramayanam
d518e7b278 Added a unit test whose intent is to ensure that we are able to parse the JSON returned by the actual URL. (#14050) 2018-01-19 11:30:55 +05:30
Boopesh Mahendran
6a3feaf77d Add Extract to Variable and Extract to Function features in js (#13980)
* Add extract to variable and extract to function features

* Fix lint errors

* Handle return statement in extract to function

* Format comments

* Format inline menu code

* Fix extract to function bug

For extract to function, check the props of scopes from src scope to
dest scope(including dest scope) for computing the return parameters

* Move inlinemenu widget to brackets core

* Externalize strings and create constants for command ids

* Return on multicursor error

* Move keyboard bindings to keyboard json

* Add keyboard json

* Add styles for inlinemenu widget

* Show function body prefix for nameless functions

* Externalize UI strings

* Fix bug in sort function for list of expressions

* Fix bug in scope position for function expressions

* Close inline menu on ESC

* Add class name for named class expressions

* Remove extra line breaks

* If only one scope, extract to function without menu

* Check identifiers of all surrounding scopes for unique identier name

* Clone ASTNode object before return in findSurroundASTNode

The node object must be cloned because we change the node object
afterwards and if not cloned, it will changed the ast and will
cause issues

* Create getAST function in refactoringUtils

* Check erroneous function declarations

* Allow function and class expressions also as statement

* Display multi-line expressions also for extract to variable

* Check if expns is null

* Check variable declaration for find name of class expn

* Change ecmaVersion in ternOption

* Move command and menu creation to javscriptrefactoring/main and add submenu

* Add refactor to strings and remove redundant keybinding lines

* Add extract to variable tests

* Remove wrong test case

* Add extract to function tests

* Add more tests

* Add unit tests for rename, wrap selection,getter/setter and convert to arrow function (#14022)
2018-01-11 11:46:56 +05:30
Jeonghyunsu
a74095f012 Correct typo (Peformance -> Performance) (#13902)
* Correct typo

* test

* Correct typo
2018-01-10 22:47:24 +02:00
Prashanth Nethi
ea94c8b4d2
Merge pull request #13824 from adobe/boopeshmahendran/ContextSubMenu
Add api for adding context submenus
2017-12-13 14:46:33 +05:30
Naveen Choudhary
2422097f09 Resolving merge conflict 2017-12-11 14:55:53 +05:30
ficristo
51417390f9
Add wrapper functions to call the fs-extra ones. (#13830)
fs-extra.copy doesn't seem to be called correctly.
Apparently NodeDomain doesn't work on functions which have optional
arguments like fs-extra.copy
2017-12-07 17:30:56 +01:00
Naveen Choudhary
12b4fed078 Moving Session.js to JSUtils 2017-12-07 20:46:58 +05:30
Naveen Choudhary
bcdce8c431 Fixting test cases 2017-12-06 16:15:29 +05:30
Prashanth Nethi
63e07fd375
Merge pull request #13852 from toryherman/13774-find-replace-prefs-fix
Don't allow find/replace if read only (#13774)
2017-12-05 10:03:46 +05:30
JungGaBin
cf8dc16872 Correct typo (#13938)
Inpsector -> Inspector
2017-11-28 21:16:09 +02:00
JungGaBin
3988b07dd4 Fix typo (#13939)
the the -> the
2017-11-28 21:15:57 +02:00
JungGaBin
28dfa30209 resuts -> results (#13865) 2017-11-17 18:56:12 +02:00
Tory Herman
c1ed83c446 Add find/replace test for read only 2017-11-16 21:47:08 -06:00
Boopesh Mahendran
392fedd201 Add tests 2017-11-08 14:35:19 +05:30
Boopesh Mahendran
1b378819e7 Change Preact require to thirdparty/preact (#13664)
* Change Preact require to thirdparty/preact

* Address review comments
2017-09-12 19:06:00 +05:30
Boopesh Mahendran
c0c1b677d6 Remove react and add preact (#13608)
* Add Preact library

* Change react to preact

* Fix problems caused by replacing react with preact

* Add Preact test utils and dependencies

* Change requires from react to preact in FileTreeView-test

* Fix problems caused by replacing react test utils with preact test utils

* Remove react

* Make findRenderedDOMComponentWithTag function as helper function

* Find and Replace react with preact

* Make preact, preact-compat, preact-test-utils as node_modules

* Change preact-compat dependency to point to adobe's fork
2017-08-29 16:40:07 +05:30
Swagatam Mitra
92819092bd JSUtils modification to handle es6 constructs (#13635)
* JSUtils modification to handle es6 constructs

* Addressed review comments and added es6 test cases

* Address Code review comments and add support for ArrowFunctionExpressions with new test case

* Update comments

* Refactor to remove extra variables
2017-08-28 10:31:42 +05:30
Saurabh Kathpalia
8ecb5edba5 Now BOM is preserved for UTF-8 files (#13477)
* Now BOM is preserved for UTF-8 files

* Added error strings for failure in encode/decode and utf-16

* Removed utf-16 from encodings list

* Addressed review comments
2017-06-27 16:37:01 +05:30
Saurabh Kathpalia
48a58fea83 Saurabh95/encoding support (#13412)
* Now encoding is passed as parameter on file read and it is used by writefile in order to preserve encoding

* UI wiring

* Code Cleanup

* Fixed failing tests

* Added warning Dialog while changing encoding

* Added some Linux specific changes

* Fixed some linting errors

* Reverted last commit

* Minor changes

* Now selected encoding is stored in state

* Fixed lint error

* Added some more encodings

* Added some more encodings

* Fixed lint errors

* Removed duplicate encodings

* Fixed failing tests

* Used externalized strings

* Addressed review comments

* Added supported encodings file

* Addressed review comments

* Addressed review comments
2017-06-23 15:12:07 +05:30
Saurabh Kathpalia
038bcb6a51 Add option for first highlight index in Quick Open and Search History (#13444)
* Fixed #13437

* minor change

* Passed first highlight index as paramater to QuickSearchField

* Added jsdocs
2017-06-15 16:53:56 +02:00
Saurabh Kathpalia
886678eb90 Fixed Project Manager failing tests 2017-05-09 14:06:09 +05:30
Martin Zagora
c8c3adde08 Merge pull request #13342 from adobe/saurabh95/SearchHistory
Now initial query is also added to searchHistory queue
2017-05-05 14:51:06 +10:00
Swagatam Mitra
5562adcbd8 Merge pull request #13339 from adobe/saurabh95/linux-native-menus
Changed Global.js to enable Native Menus for Linux
2017-05-03 11:50:36 +05:30
Saurabh Kathpalia
cd50b5106b Added test 2017-05-03 09:30:45 +05:30
ficristo
51e9e8c65b Editor command handlers test (#13337)
* EditorCommandHandlers-test: use testToggleLine everywhere

* EditorCommandHandlers-test: use testToggleBlock everywhere
2017-04-27 22:57:24 +03:00
Saurabh Kathpalia
306b10ee00 Enabled tests for Native Menus in Linux 2017-04-27 13:25:24 +05:30
Randy Edmunds
9b03593127 Merge pull request #13254 from ficristo/comments
Support indent block comments on line comment command
2017-04-24 13:21:54 -07:00
ficristo
dc9f3af513 Check also if it is a line comment command 2017-04-16 18:44:35 +02:00
ficristo
cd78916f6d Correct a test 2017-04-16 14:43:35 +02:00
ficristo
bd392a679b Add test for block comments 2017-04-16 14:25:40 +02:00
ficristo
15588c2733 Use a single preference 2017-04-15 12:42:47 +02:00
Saurabh Kathpalia
1e5d906d2e Added JSDocs and updated tests 2017-04-12 18:50:54 +05:30
ficristo
79c2bfd709 Check for useTabChar and correct a comment. Add some tests 2017-04-11 20:55:14 +02:00
ficristo
e7ed43d09c Add indentBlockComment preference. Support indent block comments on line comment command 2017-04-09 14:27:30 +02:00
Simon de Almeida
935028e3a0 Added test cases 2017-04-02 15:15:51 -04:00
Saurabh Kathpalia
b99b4ddb22 Addressed review comments and also added tests 2017-03-28 15:00:27 +05:30
Lee Yi Min
8ddead0d5e Create tests for Disabled context menu items for unsaved files / #12806 #13134 (#13178)
* Add test case for disabled items in unsaved file

* add saved file test case
2017-03-14 23:23:03 +02:00
Martin Zagora
d00e46476f eslint stylistic rules (#13177)
* add some styling rules

* fix trailing commas
2017-03-13 20:27:39 +01:00
Martin Zagora
8adb530f43 add support for universal (language independent) code inspector 2017-03-07 11:42:03 +11:00
Saurabh Kathpalia
885b97acc4 Fixed #13072: Now Preferences objects are extended from initial values defined in defaultPreferences.json (#13132)
* Fixed #13072: Now Preferences objects are extended from initial values defined in defaultPreferences.json

* Added test for PreferencesBase
2017-03-01 13:35:52 +05:30
ficristo
7dd7a75f80 Merge pull request #13116 from adobe/cm-5.24.0
update codemirror to 5.24.0
2017-02-28 10:27:22 +01:00
ficristo
eb0198a4ba Remove node dependencies 2017-02-22 21:12:52 +01:00
Martin Zagora
c590f02485 fix unit tests because of new sticky flag 2017-02-22 12:22:27 +11:00
Saurabh Kathpalia
2954858128 Added Extension Sorting capability according to downloads and last published date (#13080)
* Added Extension Sorting capability according to downloads and last published date

* Passed sort criteria to sortRegistry function in registy_utils

* Added some tests

* Added check for existence of downloadCount in extension-manager

* Added test for checking downloadCount in ExtensionManager view

* Added svg image for download icon in Extension Manager
2017-02-20 11:42:52 +05:30
Martin Zagora
74c5306e51 use npm to download extension dependencies after installing from registry (#10602)
* use npm to download extension dependencies

add shrinkwrap

* exec npm instead of using internal API

refactor

refactor 2

* update npm

* initialize exitCode

* move fail and finish blocks out

* do not use ternary ifs

* little fix

* update npm-shrinkwrap

* move npm installation to the package extraction step

* consistent function style

* add proxy support

* npm-shrinkwrap.json
2017-02-15 09:16:47 +05:30
Patrick Oladimeji
40f96c3c34 APIs for manipulating gutters (#12742)
* Added apis for manipulating gutters in Editor

* fix bug with line number  initialisation

* enabled filtering the gutter displayed based on  the language    of the current editor

* Addressed CR comments.
registering/unregistering/getting registered gutters are now `static` objects on the editor class.
modified code folding gutter to use new api.

* added tests for gutter apis

* addressing code review comments

* revert space

* addressed more missed code review comments
2017-02-14 00:21:19 +02:00
Swagatam Mitra
3e5ca74228 Merge pull request #12248 from petetnt/petetnt/flip-view-same-doc-fix
When flipping views, if the doc is already open on the other view, show it without closing the original pane
2017-02-10 13:28:39 +05:30