1
0
mirror of https://github.com/adobe/brackets.git synced 2024-11-20 09:53:00 +01:00
Commit Graph

97 Commits

Author SHA1 Message Date
Subhash Jha
df7aea423a Language Server Protocol Support for Brackets (#14606)
* LSP Initial set of changes

* Adding comments and a bit of cleanup

* Adding php client for lsp

* further cleanup

* removing dependency on HintUtils

* removing phpClient extension from this branch

* Cleanup

* fixing eslint errors

* Refactoring code- Removing dependency on JSUtils ANd adding basic structure for client capabilities

* Bug Fix: too many listeners were getting attached to node process + code cleanup

* putting null check and settign capabilities to default values

* reinitializing server on workspace change and moving out capabilities from client code

* cleanup

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Added error checks to the auto update mechanism. So in case the auto update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605)

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Removing custom comments

* Removing custom comments

* Fixing Typo

* Fixing Typo

* Add missing Params in function call

* Add missing Params in function call

* Correcting message type, handlers

* Correcting message type, handlers

* Minor correction on active project change

* Minor correction on active project change

* Correcting the message format for didChange

* Correcting the message format for didChange

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Stop Creation of Multiple Language Servers

* Stop Creation of Multiple Language Servers

* Make Language Client Generic, address review comments

* Make Language Client Generic, address review comments

* Correcting param descriptions

* Correcting param descriptions

* Modifying events handling logic for Language Client, add formatting option for communication params

* Modifying events handling logic for Language Client, add formatting option for communication params

* Add handlers for node side

* Add handlers for node side

* Removing explicit param creation, substituting with appropriate checks

* Removing explicit param creation, substituting with appropriate checks

* Fixing lint errors in MessageHandler.js

* Fixing lint errors in MessageHandler.js

* Messaging related cleanup

* Messaging related cleanup

* Adding default providers and feature managers

* Adding default providers and feature managers

* Adding banner and fixing lint error

* Adding banner and fixing lint error

* fix spacing issue

* fix spacing issue

* Fix spacing issues

* Fix spacing issues

* Add filetype checks for all events, minor server info corrections

* Add filetype checks for all events, minor server info corrections

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Correcting Typo

* Correcting Typo

* Adding bug fixes

* Adding bug fixes

* Adding bug fixes 2

* Adding bug fixes 2

* Addressing Review: Fixing minor typo

* Addressing Review: Fixing minor typo

* Minor bug fixes, functionality enhancements

* Minor bug fixes, functionality enhancements

* Adding tests for Language Server Support: first cut

* Adding tests for Language Server Support: first cut

* Adding banner, fixing lint errors

* Adding banner, fixing lint errors

* Adding dependency related tasks

* Adding dependency related tasks

* Fixing npm environment string

* Fixing npm environment string

* Changing handler name

* Changing handler name

* Changing file name to ClientLoader

* Changing file name to ClientLoader

* Changing variable name appropriately

* Changing variable name appropriately

* Grunt related changes for build

* Grunt related changes for build

* Adding additional requests and notifications for handling various scenarios

* Adding additional requests and notifications for handling various scenarios

* Adding Path Converter Utilities

* Adding Path Converter Utilities

* Changing Ternary operator to OR operater

* Changing Ternary operator to OR operater

* Addressing review comments

* Addressing review comments

* Removing the handler for editor change, will be handled explicitely

* Removing the handler for editor change, will be handled explicitely

* Patching JavaScriptCodeHints

* Patching JavaScriptCodeHints

* Preferences infra for LanguageTools

* Preferences infra for LanguageTools

* Fixing JS ParameterHints

* Fixing JS ParameterHints

* Fixing Default Parameter Hints Provider

* Fixing Default Parameter Hints Provider

* Fixing Path Converters

* Fixing Path Converters

* Fixing Lint in PathConverters

* Fixing Lint in PathConverters

* Retaining Posix Path on Win

* Retaining Posix Path on Win

* Fixing lint errors

* Fixing lint errors

* Fixing Node side Utils

* Fixing Node side Utils

* Fixing Promise related Issues

* Fixing Promise related Issues

* Set Server Capability in Start call

* Set Server Capability in Start call

* Review Comments & Bug Fixes

* Review Comments & Bug Fixes

* Addressing Review Comments

* Addressing Review Comments

* Fixing Lint

* Fixing Lint
2019-04-02 15:05:43 +05:30
Hassan Aslam
7732d934c3 Issue #12859 Keyboard modifiers support for simulateKeyEvent (#12863)
* Update simulateKeyEvent() to accept additional options

* Fix missing ; error

* Update error text

* Add KeyboardEvent global to fix no-undef error

* API limits . . .

* Add requested changes & unit test

* Remove object.assign()

* Update method comments
2016-12-23 17:07:22 +02:00
ficristo
074382aaa2 Move most inline jslint directives to config files 2016-08-12 09:22:41 +02:00
Prayag Verma
f6d2ea5354 Make test folder license evergreen 2016-01-27 19:49:10 +05:30
Martin Zagora
14ad0cf3d5 Revert "Move PathUtils to Brackets core code" 2015-09-26 12:55:54 +10:00
ficristo
25b358050b Use the core PathUtils and remove the external dependency 2015-09-23 21:54:28 +02:00
Amin Ullah Khan
75f3b5362f Add Code Hints for Preferences 2015-05-31 18:51:21 +05:00
Peter Flynn
f341ff5af1 Merge remote-tracking branch 'origin/master' into pflynn/better-quicksearch-field
Reimplements the fixes from PR #9624 & #9153 in a simpler way: instead of
trying to selectively suppress ModalBar's scroll pos adjustments, in cases
where we need to revert scroll pos in one file, just wait until ModalBar is
done adjusting scroll pos and *then* reset the one we care about. Made
possible by the fact that we now listen for ModalBar's "close" event and
the event passes info on the reason for closing.

Removes delay before results list opens: in CEF 2171 it seems both unneeded
(animation is smooth without it) and it triggers an apparent Chrome bug where
the post-animation state is displayed during the delay period even though
the computed style reflects the pre-animation state.

Conflicts:
    src/search/QuickOpen.js
    src/styles/brackets.less
    src/styles/brackets_colors.less
    src/widgets/ModalBar.js
2015-03-24 02:39:17 -07:00
Randy Edmunds
ba96598c2d Merge pull request #10294 from sprintr/master
SVG Code Hints (#10084)
2015-01-14 08:56:55 -08:00
Amin Ullah Khan
4b927bd171 Merge SVG extension in the core
Update copyright notice.

Change SVGTags.json to newer format.

Adjust to the new format.

Remove color from hints

Add new line to unittests.js

Format

Simplify attribute options exclusion list

More simplification to SVGUtils.js

Updated comment

Updated unittests.js for the changes.

Improved format of SVGTags.json

Refactoring

Removed an error

Remove alias properties to increase simplicity

Add missing SVG attributes

Cleanup

Some more refactoring

Updated unit tests

Moved XMLUtils to core

Added XMLUtils to brackets.js

Added tests for XMLUtils-test.js

Require XMLUtils

Removed tabs

Removed some more tabs.

New line at the end.

Removed tab.

Removed unused variables.

Remove XMLUtils from integration testing modules.

Correct whitespace regex.

Made proposed changes.

Removed unused variables.

Use a better name for attribute groups.

Removed mistakes in unit tests

Implement caching of attributes

More optimization

Refactor XMLUtils

Sort cached attributes.

Move preferences up

Some more restrictions in XMLUtils

Add fuzzy hinting

Format

Fix a bug with hinting

Merge SVG code hints
2015-01-14 08:47:41 +05:00
Jeff Booher
f0b4e9835c Merge pull request #10087 from adobe/jeff/fix-7420
Re-enable ViewCommandHandlers test
2015-01-07 09:03:23 -08:00
Jeff Booher
54bb0bb994 re-enable ViewCommandHandlers test 2014-12-04 16:14:06 -08:00
Sebastian Salvucci
58cab1898d Merge remote-tracking branch 'upstream/master' into multibrowser-livedev 2014-12-03 20:39:13 -03:00
Sebastian Salvucci
c612199fdf Merge remote-tracking branch 'upstream/master' into multibrowser-livedev 2014-12-02 17:50:41 -03:00
Randy Edmunds
67e6b88970 Revert "Re-enable ViewCommandHandlers tests" 2014-12-01 15:49:40 -08:00
Ingo Richter
52de9cad2b Merge pull request #9973 from adobe/randy/reenable-vch-tests
Re-enable ViewCommandHandlers tests
2014-12-01 14:32:56 -08:00
Sebastian Salvucci
235c5517c3 Add experimental multi-browser LiveDevelopment
Brings in new LiveDevelopment implementation incubated at
njx/brackets-livedev2 which allows running on multiple browsers.
2014-11-24 21:33:53 -03:00
Randy Edmunds
2dbc749f67 re-enable ViewCommandHandlers test 2014-11-19 12:00:34 -08:00
Peter Flynn
b4a2c01419 * Reimplement new event system based on our own code instead of jQuery. Adds
better exception robustness, and should be faster & more memory-efficient.
makeEventDispatcher() can now be called safely on prototype objects.
* Add unit tests for new event system.
2014-11-13 00:59:55 -08:00
Kevin Dangoor
430eaa6e1b Merge branch 'master' into ProjectManager
Conflicts:
	src/project/ProjectManager.js
	src/styles/brackets.less
2014-09-16 09:05:04 -04:00
RaymondLim
812fe37c08 less and scss unit tests 2014-09-12 11:57:39 -07:00
Kevin Dangoor
5181528d6f Rebased project manager 2014-09-08 09:21:24 -07:00
Jeff Booher
af55f97b93 Implement Splitview 2014-08-29 13:05:49 -07:00
Miguel Castillo
b3f1ece1f0 Adding unit tests for themes core functionality 2014-07-09 00:18:22 -04:00
Narciso Jaramillo
78296b7bc2 Merge from master 2014-06-12 18:08:48 -07:00
Ingo Richter
04b579e324 - disable failing ViewCommandHandlerTest while investigating the issue 2014-05-28 10:26:35 -07:00
Narciso Jaramillo
ffc5ffb48b Move FindInFiles tests into a separate file 2014-05-13 18:16:45 -07:00
Peter Flynn
72aa41211b Merge remote-tracking branch 'origin/master' into pflynn/better-quicksearch-field 2014-04-01 00:24:53 -07:00
Peter Flynn
210a28242f Remove smart-auto-complete from codebase. Add unit tests for QuickSearchField.
Remove logging code and old TODOs. Round out documentation.

Fix bug where pressing enter in Goto Line mode did nothing if a previous
search mode had been used earlier (currentPlugin was stale).
2014-04-01 00:24:41 -07:00
Randy Edmunds
1b1a60450d start ValidationUtils module 2014-03-12 15:54:09 -07:00
Peter Flynn
7a96840899 Fix bug that snuck into last FileFilters commit at last minute.
Small starter set of unit tests for FileFilters auto-prefix/suffix behavior.

Also fix whitespace JSLint glitch in unrelated unit-test file.
2014-02-26 17:11:26 -08:00
Kevin Dangoor
f3c30fff0f Merge branch 'master' into PreferencesModel
Conflicts:
	src/language/CodeInspection.js
2014-01-10 08:57:03 -05:00
Peter Flynn
fe94d19c1f Merge remote-tracking branch 'origin/master' into irichter/code-inspection-improvements
* origin/master: (187 commits)
  improve comments
  update comments
  Fix a comment typo and just log the unhandled exception instead of trying to reject the promise, which probably won't work anyway.
  Enable Quick Docs for LESS
  Return a promise from ProjectManager.getAllFiles that is resiliant to misbehaving done handlers
  Updated by ALF automation.
  Revert LiveDev timeout changes
  Use Brackets shell for copying files to reduce the number of external watcher notifications and increase timeouts
  Don't refresh the file tree on change events for directories outside of the project root, but when we do refresh the file tree, also clear the change queue (using a new PromiseQueue.removeAll method) and use a debounced refreshFileTree call
  fix check for added and removed files in fs change event handler
  always hide dirty dot if there is no doc
  Fix selection update after fs change event. Remove unnecessary updates when no added or removed files are present.
  backout change for dismissing list
  Right aligning numbers column.
  Removed most inline css.
  Adding LOCALE_KO
  Initial commit.
  Fixed some dutch spelling/translation errors.
  Bump up timeouts to account for additional Project Manager synchronization
  Made canvas height 300 to stop weird rounding.
  ...

Conflicts:
	src/language/CodeInspection.js
2014-01-08 19:44:19 -08:00
Kevin Dangoor
2cb3d98ec3 Merge branch 'master' into PreferencesModel 2014-01-02 12:47:36 -05:00
Lance Campbell
6cd9418a20 Add UrlParams unit tests 2013-12-13 17:01:19 -08:00
Kevin Dangoor
9e445341a3 Merge branch 'master' into PreferencesModel 2013-11-20 11:35:32 -05:00
Ingo Richter
9e92cf0b6e Merge branch 'master' into irichter/code-inspection-improvements
Conflicts:
	src/language/CodeInspection.js
2013-11-10 23:34:15 -08:00
Ingo Richter
88ea4554cc - added support for multiple code linter per file type 2013-11-05 18:21:20 -08:00
Kevin Dangoor
73c57712bf Merge branch 'master' into PreferencesModel
Conflicts:
	src/preferences/PreferencesManager.js
2013-10-29 09:55:50 -04:00
Glenn Ruehle
04e4c6c6ea Remove NativeFileSystem tests 2013-10-28 16:24:19 -07:00
Glenn Ruehle
4a0929e916 Remove FileIndexManager tests. 2013-10-28 15:48:41 -07:00
Ian Wehrman
67c19d0266 Merge branch 'brackets' into glenn/file-system
Conflicts:
	src/document/DocumentCommandHandlers.js
	src/document/DocumentManager.js
	src/editor/ImageViewer.js
	src/utils/DragAndDrop.js
2013-10-25 17:08:34 -07:00
Ian Wehrman
2ab57c068b Merge branch 'brackets' into glenn/file-system
Conflicts:
	src/document/DocumentCommandHandlers.js
	src/document/DocumentManager.js
	src/editor/CSSInlineEditor.js
	src/file/FileUtils.js
	src/project/ProjectManager.js
	test/spec/DocumentCommandHandlers-test.js
2013-10-24 12:16:14 -07:00
RaymondLim
90b8194650 Unit tests for dropping image files in Brackets. 2013-10-23 19:56:40 -07:00
Ian Wehrman
181278c5b4 Re-disable the FileIndexManager tests 2013-10-23 16:33:13 -07:00
Ian Wehrman
7756ce1fdd Re-enable LowLevelFile-IO, NativeFileSystem and FileIndexManager tests 2013-10-22 17:04:02 -07:00
Ian Wehrman
bfb113d5a9 Merge branch 'brackets' into glenn/file-system
Conflicts:
	src/document/DocumentManager.js
	src/language/JSUtils.js
	src/project/ProjectManager.js
	src/search/FindInFiles.js
2013-10-21 12:20:33 -07:00
Kevin Dangoor
247aab941d Merge branch 'master' into PreferencesModel
Conflicts:
	src/preferences/PreferencesManager.js
2013-10-19 21:21:50 -04:00
Jochen Hagenstroem
0304ce1cab Merge branch 'master' into couzteau/preview-images-review
Conflicts resolved
	test/UnitTestSuite.js
2013-10-17 17:54:08 -07:00
Narciso Jaramillo
df1d141f27 Add contentChange event to TextRange. Make it so original change event doesn't fire if boundaries don't actually change. 2013-10-16 20:13:16 -07:00